CC: [email protected]
BCC: [email protected]
CC: [email protected]
TO: Pavan Chebbi <[email protected]>
CC: Somnath Kotur <[email protected]>
CC: Michael Chan <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   1831fed559732b132aef0ea8261ac77e73f7eadf
commit: 24ac1ecd524065cdcf8c27dc85ae37eccce8f2f6 bnxt_en: Add driver support to 
use Real Time Counter for PTP
date:   2 months ago
:::::: branch date: 11 hours ago
:::::: commit date: 2 months ago
config: xtensa-randconfig-m031-20220407 
(https://download.01.org/0day-ci/archive/20220409/[email protected]/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:838 bnxt_ptp_init() warn: missing 
error code 'rc'

Old smatch warnings:
arch/xtensa/include/asm/thread_info.h:91 current_thread_info() warn: 
inconsistent indenting

vim +/rc +838 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c

740c342e399981b Pavan Chebbi 2022-01-25  796  
24ac1ecd524065c Pavan Chebbi 2022-01-25  797  int bnxt_ptp_init(struct bnxt 
*bp, bool phc_cfg)
118612d519d83b9 Michael Chan 2021-06-27  798  {
118612d519d83b9 Michael Chan 2021-06-27  799    struct bnxt_ptp_cfg *ptp = 
bp->ptp_cfg;
118612d519d83b9 Michael Chan 2021-06-27  800    int rc;
118612d519d83b9 Michael Chan 2021-06-27  801  
118612d519d83b9 Michael Chan 2021-06-27  802    if (!ptp)
118612d519d83b9 Michael Chan 2021-06-27  803            return 0;
118612d519d83b9 Michael Chan 2021-06-27  804  
118612d519d83b9 Michael Chan 2021-06-27  805    rc = bnxt_map_ptp_regs(bp);
118612d519d83b9 Michael Chan 2021-06-27  806    if (rc)
118612d519d83b9 Michael Chan 2021-06-27  807            return rc;
118612d519d83b9 Michael Chan 2021-06-27  808  
24ac1ecd524065c Pavan Chebbi 2022-01-25  809    if (bp->fw_cap & 
BNXT_FW_CAP_PTP_RTC) {
24ac1ecd524065c Pavan Chebbi 2022-01-25  810            
bnxt_ptp_timecounter_init(bp, false);
24ac1ecd524065c Pavan Chebbi 2022-01-25  811            rc = 
bnxt_ptp_init_rtc(bp, phc_cfg);
24ac1ecd524065c Pavan Chebbi 2022-01-25  812            if (rc)
24ac1ecd524065c Pavan Chebbi 2022-01-25  813                    goto out;
24ac1ecd524065c Pavan Chebbi 2022-01-25  814    }
24ac1ecd524065c Pavan Chebbi 2022-01-25  815  
caf3eedbcd8d326 Pavan Chebbi 2021-07-28  816    if (ptp->ptp_clock && 
bnxt_pps_config_ok(bp))
a521c8a01d267bc Michael Chan 2021-07-28  817            return 0;
a521c8a01d267bc Michael Chan 2021-07-28  818  
740c342e399981b Pavan Chebbi 2022-01-25  819    bnxt_ptp_free(bp);
740c342e399981b Pavan Chebbi 2022-01-25  820  
118612d519d83b9 Michael Chan 2021-06-27  821    atomic_set(&ptp->tx_avail, 
BNXT_MAX_TX_TS);
118612d519d83b9 Michael Chan 2021-06-27  822    spin_lock_init(&ptp->ptp_lock);
118612d519d83b9 Michael Chan 2021-06-27  823  
24ac1ecd524065c Pavan Chebbi 2022-01-25  824    if (!(bp->fw_cap & 
BNXT_FW_CAP_PTP_RTC))
740c342e399981b Pavan Chebbi 2022-01-25  825            
bnxt_ptp_timecounter_init(bp, true);
118612d519d83b9 Michael Chan 2021-06-27  826  
118612d519d83b9 Michael Chan 2021-06-27  827    ptp->ptp_info = bnxt_ptp_caps;
caf3eedbcd8d326 Pavan Chebbi 2021-07-28  828    if ((bp->fw_cap & 
BNXT_FW_CAP_PTP_PPS)) {
caf3eedbcd8d326 Pavan Chebbi 2021-07-28  829            if 
(bnxt_ptp_pps_init(bp))
caf3eedbcd8d326 Pavan Chebbi 2021-07-28  830                    
netdev_err(bp->dev, "1pps not initialized, continuing without 1pps support\n");
caf3eedbcd8d326 Pavan Chebbi 2021-07-28  831    }
118612d519d83b9 Michael Chan 2021-06-27  832    ptp->ptp_clock = 
ptp_clock_register(&ptp->ptp_info, &bp->pdev->dev);
118612d519d83b9 Michael Chan 2021-06-27  833    if (IS_ERR(ptp->ptp_clock)) {
118612d519d83b9 Michael Chan 2021-06-27  834            int err = 
PTR_ERR(ptp->ptp_clock);
118612d519d83b9 Michael Chan 2021-06-27  835  
118612d519d83b9 Michael Chan 2021-06-27  836            ptp->ptp_clock = NULL;
24ac1ecd524065c Pavan Chebbi 2022-01-25  837            rc = err;
24ac1ecd524065c Pavan Chebbi 2022-01-25 @838            goto out;
118612d519d83b9 Michael Chan 2021-06-27  839    }
d7859afb6880249 Michael Chan 2021-07-18  840    if (bp->flags & 
BNXT_FLAG_CHIP_P5) {
d7859afb6880249 Michael Chan 2021-07-18  841            
spin_lock_bh(&ptp->ptp_lock);
30e96f487f64c60 Michael Chan 2021-07-28  842            bnxt_refclk_read(bp, 
NULL, &ptp->current_time);
d7859afb6880249 Michael Chan 2021-07-18  843            
WRITE_ONCE(ptp->old_time, ptp->current_time);
d7859afb6880249 Michael Chan 2021-07-18  844            
spin_unlock_bh(&ptp->ptp_lock);
d7859afb6880249 Michael Chan 2021-07-18  845            
ptp_schedule_worker(ptp->ptp_clock, 0);
d7859afb6880249 Michael Chan 2021-07-18  846    }
118612d519d83b9 Michael Chan 2021-06-27  847    return 0;
24ac1ecd524065c Pavan Chebbi 2022-01-25  848  
24ac1ecd524065c Pavan Chebbi 2022-01-25  849  out:
24ac1ecd524065c Pavan Chebbi 2022-01-25  850    bnxt_ptp_free(bp);
24ac1ecd524065c Pavan Chebbi 2022-01-25  851    bnxt_unmap_ptp_regs(bp);
24ac1ecd524065c Pavan Chebbi 2022-01-25  852    return rc;
118612d519d83b9 Michael Chan 2021-06-27  853  }
118612d519d83b9 Michael Chan 2021-06-27  854  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to