CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Maxime Ripard <[email protected]> TO: Mike Turquette <[email protected]> TO: Stephen Boyd <[email protected]> TO: [email protected] CC: Naresh Kamboju <[email protected]> CC: Alexander Stein <[email protected]> CC: Marek Szyprowski <[email protected]> CC: Tony Lindgren <[email protected]> CC: Jerome Brunet <[email protected]> CC: Yassine Oudjana <[email protected]> CC: Neil Armstrong <[email protected]> CC: Maxime Ripard <[email protected]>
Hi Maxime, I love your patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on linus/master v5.18-rc1 next-20220408] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/clk-More-clock-rate-fixes-and-tests/20220408-171635 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next :::::: branch date: 16 hours ago :::::: commit date: 16 hours ago config: riscv-randconfig-m031-20220408 (https://download.01.org/0day-ci/archive/20220409/[email protected]/config) compiler: riscv64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/clk/clk_test.c:801 clk_test_orphan_transparent_multiple_parent_mux_set_range_set_parent_get_rate() warn: ignoring unreachable code. Old smatch warnings: drivers/clk/clk_test.c:929 clk_test_single_parent_mux_set_range_disjoint_child_last() warn: ignoring unreachable code. drivers/clk/clk_test.c:959 clk_test_single_parent_mux_set_range_disjoint_parent_last() warn: ignoring unreachable code. vim +801 drivers/clk/clk_test.c d61deb9e36bc91 Maxime Ripard 2022-04-08 780 2f0b8e802c7321 Maxime Ripard 2022-04-08 781 /* 2f0b8e802c7321 Maxime Ripard 2022-04-08 782 * Test that, for a mux that started orphan, was assigned and rate and 2f0b8e802c7321 Maxime Ripard 2022-04-08 783 * then got switched to a valid parent, its rate is eventually within 2f0b8e802c7321 Maxime Ripard 2022-04-08 784 * range. 2f0b8e802c7321 Maxime Ripard 2022-04-08 785 * 2f0b8e802c7321 Maxime Ripard 2022-04-08 786 * FIXME: Even though we update the rate as part of clk_set_parent(), we 2f0b8e802c7321 Maxime Ripard 2022-04-08 787 * don't evaluate whether that new rate is within range and needs to be 2f0b8e802c7321 Maxime Ripard 2022-04-08 788 * adjusted. 2f0b8e802c7321 Maxime Ripard 2022-04-08 789 */ 2f0b8e802c7321 Maxime Ripard 2022-04-08 790 static void 2f0b8e802c7321 Maxime Ripard 2022-04-08 791 clk_test_orphan_transparent_multiple_parent_mux_set_range_set_parent_get_rate(struct kunit *test) 2f0b8e802c7321 Maxime Ripard 2022-04-08 792 { 2f0b8e802c7321 Maxime Ripard 2022-04-08 793 struct clk_multiple_parent_ctx *ctx = test->priv; 2f0b8e802c7321 Maxime Ripard 2022-04-08 794 struct clk_hw *hw = &ctx->hw; 2f0b8e802c7321 Maxime Ripard 2022-04-08 795 struct clk *clk = hw->clk, *parent; 2f0b8e802c7321 Maxime Ripard 2022-04-08 796 unsigned long rate; 2f0b8e802c7321 Maxime Ripard 2022-04-08 797 int ret; 2f0b8e802c7321 Maxime Ripard 2022-04-08 798 2f0b8e802c7321 Maxime Ripard 2022-04-08 799 kunit_skip(test, "This needs to be fixed in the core."); 2f0b8e802c7321 Maxime Ripard 2022-04-08 800 2f0b8e802c7321 Maxime Ripard 2022-04-08 @801 parent = clk_hw_get_clk(&ctx->parents_ctx[1].hw, NULL); 2f0b8e802c7321 Maxime Ripard 2022-04-08 802 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, parent); 2f0b8e802c7321 Maxime Ripard 2022-04-08 803 2f0b8e802c7321 Maxime Ripard 2022-04-08 804 ret = clk_set_rate_range(clk, DUMMY_CLOCK_RATE_1, DUMMY_CLOCK_RATE_2); 2f0b8e802c7321 Maxime Ripard 2022-04-08 805 KUNIT_ASSERT_EQ(test, ret, 0); 2f0b8e802c7321 Maxime Ripard 2022-04-08 806 2f0b8e802c7321 Maxime Ripard 2022-04-08 807 ret = clk_set_parent(clk, parent); 2f0b8e802c7321 Maxime Ripard 2022-04-08 808 KUNIT_ASSERT_EQ(test, ret, 0); 2f0b8e802c7321 Maxime Ripard 2022-04-08 809 2f0b8e802c7321 Maxime Ripard 2022-04-08 810 rate = clk_get_rate(clk); 2f0b8e802c7321 Maxime Ripard 2022-04-08 811 KUNIT_ASSERT_GT(test, rate, 0); 2f0b8e802c7321 Maxime Ripard 2022-04-08 812 KUNIT_EXPECT_GE(test, rate, DUMMY_CLOCK_RATE_1); 2f0b8e802c7321 Maxime Ripard 2022-04-08 813 KUNIT_EXPECT_LE(test, rate, DUMMY_CLOCK_RATE_2); 2f0b8e802c7321 Maxime Ripard 2022-04-08 814 2f0b8e802c7321 Maxime Ripard 2022-04-08 815 clk_put(parent); 2f0b8e802c7321 Maxime Ripard 2022-04-08 816 } 2f0b8e802c7321 Maxime Ripard 2022-04-08 817 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
