CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Marek Vasut <[email protected]> TO: [email protected] CC: Marek Vasut <[email protected]> CC: Peng Fan <[email protected]> CC: Alexander Stein <[email protected]> CC: [email protected] CC: Laurent Pinchart <[email protected]> CC: Robby Cai <[email protected]> CC: Sam Ravnborg <[email protected]>
Hi Marek, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip tegra-drm/drm/tegra/for-next v5.18-rc1 next-20220408] [cannot apply to airlied/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Marek-Vasut/drm-mxsfb-Implement-LCDIF-scanout-CRC32-support/20220410-071222 base: git://anongit.freedesktop.org/drm/drm drm-next :::::: branch date: 28 hours ago :::::: commit date: 28 hours ago config: i386-randconfig-m021-20220411 (https://download.01.org/0day-ci/archive/20220411/[email protected]/config) compiler: gcc-11 (Debian 11.2.0-19) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/gpu/drm/mxsfb/mxsfb_kms.c:444 mxsfb_crtc_set_crc_source() warn: variable dereferenced before check 'crtc' (see line 442) vim +/crtc +444 drivers/gpu/drm/mxsfb/mxsfb_kms.c ae1ed009328193 Laurent Pinchart 2020-07-27 439 5797982b2ba894 Marek Vasut 2022-04-10 440 static int mxsfb_crtc_set_crc_source(struct drm_crtc *crtc, const char *source) 5797982b2ba894 Marek Vasut 2022-04-10 441 { 5797982b2ba894 Marek Vasut 2022-04-10 @442 struct mxsfb_drm_private *mxsfb = to_mxsfb_drm_private(crtc->dev); 5797982b2ba894 Marek Vasut 2022-04-10 443 5797982b2ba894 Marek Vasut 2022-04-10 @444 if (!crtc) 5797982b2ba894 Marek Vasut 2022-04-10 445 return -ENODEV; 5797982b2ba894 Marek Vasut 2022-04-10 446 5797982b2ba894 Marek Vasut 2022-04-10 447 if (source && strcmp(source, "auto") == 0) 5797982b2ba894 Marek Vasut 2022-04-10 448 mxsfb->crc_active = true; 5797982b2ba894 Marek Vasut 2022-04-10 449 else if (!source) 5797982b2ba894 Marek Vasut 2022-04-10 450 mxsfb->crc_active = false; 5797982b2ba894 Marek Vasut 2022-04-10 451 else 5797982b2ba894 Marek Vasut 2022-04-10 452 return -EINVAL; 5797982b2ba894 Marek Vasut 2022-04-10 453 5797982b2ba894 Marek Vasut 2022-04-10 454 return 0; 5797982b2ba894 Marek Vasut 2022-04-10 455 } 5797982b2ba894 Marek Vasut 2022-04-10 456 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
