CC: [email protected] BCC: [email protected] CC: Linux Memory Management List <[email protected]> TO: Jeff LaBundy <[email protected]> CC: Dmitry Torokhov <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 40354149f4d738dc3492d9998e45b3f02950369a commit: e505edaedcb9e7d16eefddc62d2189afaea0febc [2484/4328] Input: add support for Azoteq IQS7222A/B/C :::::: branch date: 33 hours ago :::::: commit date: 7 days ago config: s390-randconfig-m031-20220414 (https://download.01.org/0day-ci/archive/20220415/[email protected]/config) compiler: s390-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/input/misc/iqs7222.c:1404 iqs7222_dev_init() error: uninitialized symbol 'error'. vim +/error +1404 drivers/input/misc/iqs7222.c e505edaedcb9e7 Jeff LaBundy 2022-04-08 1329 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1330 static int iqs7222_dev_init(struct iqs7222_private *iqs7222, int dir) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1331 { e505edaedcb9e7 Jeff LaBundy 2022-04-08 1332 const struct iqs7222_dev_desc *dev_desc = iqs7222->dev_desc; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1333 int comms_offset = dev_desc->comms_offset; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1334 int error, i, j, k; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1335 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1336 /* e505edaedcb9e7 Jeff LaBundy 2022-04-08 1337 * Take advantage of the stop-bit disable function, if available, to e505edaedcb9e7 Jeff LaBundy 2022-04-08 1338 * save the trouble of having to reopen a communication window after e505edaedcb9e7 Jeff LaBundy 2022-04-08 1339 * each burst read or write. e505edaedcb9e7 Jeff LaBundy 2022-04-08 1340 */ e505edaedcb9e7 Jeff LaBundy 2022-04-08 1341 if (comms_offset) { e505edaedcb9e7 Jeff LaBundy 2022-04-08 1342 u16 comms_setup; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1343 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1344 error = iqs7222_read_word(iqs7222, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1345 IQS7222_SYS_SETUP + comms_offset, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1346 &comms_setup); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1347 if (error) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1348 return error; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1349 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1350 error = iqs7222_write_word(iqs7222, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1351 IQS7222_SYS_SETUP + comms_offset, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1352 comms_setup | IQS7222_COMMS_HOLD); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1353 if (error) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1354 return error; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1355 } e505edaedcb9e7 Jeff LaBundy 2022-04-08 1356 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1357 for (i = 0; i < IQS7222_NUM_REG_GRPS; i++) { e505edaedcb9e7 Jeff LaBundy 2022-04-08 1358 int num_row = dev_desc->reg_grps[i].num_row; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1359 int num_col = dev_desc->reg_grps[i].num_col; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1360 u16 reg = dev_desc->reg_grps[i].base; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1361 __le16 *val_buf; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1362 u16 *val; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1363 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1364 if (!num_col) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1365 continue; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1366 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1367 val = iqs7222_setup(iqs7222, i, 0); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1368 if (!val) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1369 continue; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1370 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1371 val_buf = kcalloc(num_col, sizeof(__le16), GFP_KERNEL); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1372 if (!val_buf) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1373 return -ENOMEM; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1374 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1375 for (j = 0; j < num_row; j++) { e505edaedcb9e7 Jeff LaBundy 2022-04-08 1376 switch (dir) { e505edaedcb9e7 Jeff LaBundy 2022-04-08 1377 case READ: e505edaedcb9e7 Jeff LaBundy 2022-04-08 1378 error = iqs7222_read_burst(iqs7222, reg, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1379 val_buf, num_col); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1380 for (k = 0; k < num_col; k++) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1381 val[k] = le16_to_cpu(val_buf[k]); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1382 break; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1383 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1384 case WRITE: e505edaedcb9e7 Jeff LaBundy 2022-04-08 1385 for (k = 0; k < num_col; k++) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1386 val_buf[k] = cpu_to_le16(val[k]); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1387 error = iqs7222_write_burst(iqs7222, reg, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1388 val_buf, num_col); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1389 break; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1390 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1391 default: e505edaedcb9e7 Jeff LaBundy 2022-04-08 1392 error = -EINVAL; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1393 } e505edaedcb9e7 Jeff LaBundy 2022-04-08 1394 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1395 if (error) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1396 break; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1397 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1398 reg += IQS7222_REG_OFFSET; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1399 val += iqs7222_max_cols[i]; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1400 } e505edaedcb9e7 Jeff LaBundy 2022-04-08 1401 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1402 kfree(val_buf); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1403 e505edaedcb9e7 Jeff LaBundy 2022-04-08 @1404 if (error) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1405 return error; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1406 } e505edaedcb9e7 Jeff LaBundy 2022-04-08 1407 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1408 if (comms_offset) { e505edaedcb9e7 Jeff LaBundy 2022-04-08 1409 u16 comms_setup; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1410 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1411 error = iqs7222_read_word(iqs7222, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1412 IQS7222_SYS_SETUP + comms_offset, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1413 &comms_setup); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1414 if (error) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1415 return error; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1416 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1417 error = iqs7222_write_word(iqs7222, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1418 IQS7222_SYS_SETUP + comms_offset, e505edaedcb9e7 Jeff LaBundy 2022-04-08 1419 comms_setup & ~IQS7222_COMMS_HOLD); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1420 if (error) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1421 return error; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1422 } e505edaedcb9e7 Jeff LaBundy 2022-04-08 1423 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1424 if (dir == READ) e505edaedcb9e7 Jeff LaBundy 2022-04-08 1425 return 0; e505edaedcb9e7 Jeff LaBundy 2022-04-08 1426 e505edaedcb9e7 Jeff LaBundy 2022-04-08 1427 return iqs7222_ati_trigger(iqs7222); e505edaedcb9e7 Jeff LaBundy 2022-04-08 1428 } e505edaedcb9e7 Jeff LaBundy 2022-04-08 1429 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
