CC: [email protected] BCC: [email protected] TO: Liu Yi L <[email protected]>
tree: https://github.com/luxis1999/iommufd iommufd-v5.17-rc6 head: 71a58479a11e89a480ebc59ed5163440d3e2772c commit: 32c7255422ff37fe8423f0065860803f8e1ec0e0 [3/28] vfio/mdev: Add mdev available instance checking to the core :::::: branch date: 3 days ago :::::: commit date: 4 weeks ago compiler: sparc-linux-gcc (GCC) 11.2.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout 32c7255422ff37fe8423f0065860803f8e1ec0e0 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/vfio/mdev/mdev_sysfs.c:239:32: warning: Uninitialized variables: >> ltype.kobj, ltype.devices_kobj, ltype.parent, ltype.available, >> ltype.type_group_id [uninitvar] remove_mdev_supported_type(ltype); ^ >> drivers/vfio/mdev/mdev_sysfs.c:255:30: warning: Uninitialized variables: >> type.kobj, type.devices_kobj, type.parent, type.available, >> type.type_group_id [uninitvar] remove_mdev_supported_type(type); ^ -- >> drivers/vfio/vfio.c:306:49: warning: Parameter 'iommu_group' can be declared >> with const [constParameter] __vfio_group_get_from_iommu(struct iommu_group *iommu_group) ^ >> drivers/vfio/vfio.c:479:23: warning: Parameter 'dev' can be declared with >> const [constParameter] struct device *dev) ^ >> drivers/vfio/vfio.c:1492:56: warning: Parameter 'test_group' can be declared >> with const [constParameter] bool vfio_external_group_match_file(struct vfio_group *test_group, ^ >> drivers/vfio/vfio.c:244:12: warning: Uninitialized variable: tmp->ops >> [uninitvar] if (tmp->ops == ops) { ^ drivers/vfio/vfio.c:235:6: note: Assuming condition is false if (!driver) ^ drivers/vfio/vfio.c:244:12: note: Uninitialized variable: tmp->ops if (tmp->ops == ops) { ^ >> drivers/vfio/vfio.c:265:15: warning: Uninitialized variable: driver->ops >> [uninitvar] if (driver->ops == ops) { ^ >> drivers/vfio/vfio.c:311:14: warning: Uninitialized variable: >> group->iommu_group [uninitvar] if (group->iommu_group == iommu_group) { ^ >> drivers/vfio/vfio.c:854:45: warning: Uninitialized variables: driver.ops, >> driver.vfio_next [uninitvar] if (!vfio_iommu_driver_allowed(container, driver)) ^ drivers/vfio/vfio.c:845:41: note: Assuming condition is false if (list_empty(&container->group_list) || container->iommu_driver) { ^ drivers/vfio/vfio.c:845:41: note: Assuming condition is false if (list_empty(&container->group_list) || container->iommu_driver) { ^ drivers/vfio/vfio.c:854:45: note: Uninitialized variables: driver.ops, driver.vfio_next if (!vfio_iommu_driver_allowed(container, driver)) ^ vim +239 drivers/vfio/mdev/mdev_sysfs.c 7b96953bc640b6 Kirti Wankhede 2016-11-17 224 42930553a7c11f Alex Williamson 2016-12-30 225 static int add_mdev_supported_type_groups(struct mdev_parent *parent) 7b96953bc640b6 Kirti Wankhede 2016-11-17 226 { 7b96953bc640b6 Kirti Wankhede 2016-11-17 227 int i; 7b96953bc640b6 Kirti Wankhede 2016-11-17 228 7b96953bc640b6 Kirti Wankhede 2016-11-17 229 for (i = 0; parent->ops->supported_type_groups[i]; i++) { 7b96953bc640b6 Kirti Wankhede 2016-11-17 230 struct mdev_type *type; 7b96953bc640b6 Kirti Wankhede 2016-11-17 231 15fcc44be0c7af Jason Gunthorpe 2021-04-06 232 type = add_mdev_supported_type(parent, i); 7b96953bc640b6 Kirti Wankhede 2016-11-17 233 if (IS_ERR(type)) { 7b96953bc640b6 Kirti Wankhede 2016-11-17 234 struct mdev_type *ltype, *tmp; 7b96953bc640b6 Kirti Wankhede 2016-11-17 235 7b96953bc640b6 Kirti Wankhede 2016-11-17 236 list_for_each_entry_safe(ltype, tmp, &parent->type_list, 7b96953bc640b6 Kirti Wankhede 2016-11-17 237 next) { 7b96953bc640b6 Kirti Wankhede 2016-11-17 238 list_del(<ype->next); 7b96953bc640b6 Kirti Wankhede 2016-11-17 @239 remove_mdev_supported_type(ltype); 7b96953bc640b6 Kirti Wankhede 2016-11-17 240 } 7b96953bc640b6 Kirti Wankhede 2016-11-17 241 return PTR_ERR(type); 7b96953bc640b6 Kirti Wankhede 2016-11-17 242 } 7b96953bc640b6 Kirti Wankhede 2016-11-17 243 list_add(&type->next, &parent->type_list); 7b96953bc640b6 Kirti Wankhede 2016-11-17 244 } 7b96953bc640b6 Kirti Wankhede 2016-11-17 245 return 0; 7b96953bc640b6 Kirti Wankhede 2016-11-17 246 } 7b96953bc640b6 Kirti Wankhede 2016-11-17 247 7b96953bc640b6 Kirti Wankhede 2016-11-17 248 /* mdev sysfs functions */ 42930553a7c11f Alex Williamson 2016-12-30 249 void parent_remove_sysfs_files(struct mdev_parent *parent) 7b96953bc640b6 Kirti Wankhede 2016-11-17 250 { 7b96953bc640b6 Kirti Wankhede 2016-11-17 251 struct mdev_type *type, *tmp; 7b96953bc640b6 Kirti Wankhede 2016-11-17 252 7b96953bc640b6 Kirti Wankhede 2016-11-17 253 list_for_each_entry_safe(type, tmp, &parent->type_list, next) { 7b96953bc640b6 Kirti Wankhede 2016-11-17 254 list_del(&type->next); 7b96953bc640b6 Kirti Wankhede 2016-11-17 @255 remove_mdev_supported_type(type); 7b96953bc640b6 Kirti Wankhede 2016-11-17 256 } 7b96953bc640b6 Kirti Wankhede 2016-11-17 257 7b96953bc640b6 Kirti Wankhede 2016-11-17 258 sysfs_remove_groups(&parent->dev->kobj, parent->ops->dev_attr_groups); 7b96953bc640b6 Kirti Wankhede 2016-11-17 259 kset_unregister(parent->mdev_types_kset); 7b96953bc640b6 Kirti Wankhede 2016-11-17 260 } 7b96953bc640b6 Kirti Wankhede 2016-11-17 261 :::::: The code at line 239 was first introduced by commit :::::: 7b96953bc640b6b25665fe17ffca4b668b371f14 vfio: Mediated device Core driver :::::: TO: Kirti Wankhede <[email protected]> :::::: CC: Alex Williamson <[email protected]> -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
