CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Russ Weight <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: Russ Weight <[email protected]>
Hi Russ, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on shuah-kselftest/next mcgrof/sysctl-next linus/master v5.18-rc3 next-20220419] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220419-064126 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3123109284176b1532874591f7c81f3837bbdc17 :::::: branch date: 14 hours ago :::::: commit date: 14 hours ago compiler: mipsel-linux-gcc (GCC) 11.2.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout 2cf984eba934c1a6b1bcfc317886e89180bcb5e3 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> lib/test_firmware.c:1071:18: warning: Uninitialized variables: tst.name, >> tst.buf, tst.size, tst.cancel_request, tst.inject, tst.fwl [uninitvar] upload_release(tst); ^ vim +1071 lib/test_firmware.c cb4d12e8d75964 Russ Weight 2022-04-18 1064 cb4d12e8d75964 Russ Weight 2022-04-18 1065 static void upload_release_all(void) cb4d12e8d75964 Russ Weight 2022-04-18 1066 { cb4d12e8d75964 Russ Weight 2022-04-18 1067 struct test_firmware_upload *tst, *tmp; cb4d12e8d75964 Russ Weight 2022-04-18 1068 cb4d12e8d75964 Russ Weight 2022-04-18 1069 list_for_each_entry_safe(tst, tmp, &test_upload_list, node) { cb4d12e8d75964 Russ Weight 2022-04-18 1070 list_del(&tst->node); cb4d12e8d75964 Russ Weight 2022-04-18 @1071 upload_release(tst); cb4d12e8d75964 Russ Weight 2022-04-18 1072 } cb4d12e8d75964 Russ Weight 2022-04-18 1073 test_fw_config->upload_name = NULL; cb4d12e8d75964 Russ Weight 2022-04-18 1074 } cb4d12e8d75964 Russ Weight 2022-04-18 1075 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
