CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: "Eric W. Biederman" <[email protected]>
Hi "Eric, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on linus/master] [also build test WARNING on v5.18-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Eric-W-Biederman/ptrace-Don-t-change-__state/20220421-045703 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b253435746d9a4a701b5f09211b9c14d3370d0da :::::: branch date: 16 hours ago :::::: commit date: 16 hours ago config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220421/[email protected]/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: kernel/ptrace.c:894 ptrace_resume() error: uninitialized symbol 'need_siglock'. vim +/need_siglock +894 kernel/ptrace.c 36df29d7994180 Roland McGrath 2008-01-30 868 5b88abbf770a0e Roland McGrath 2008-01-30 869 if (is_singleblock(request)) { 5b88abbf770a0e Roland McGrath 2008-01-30 870 if (unlikely(!arch_has_block_step())) 5b88abbf770a0e Roland McGrath 2008-01-30 871 return -EIO; 5b88abbf770a0e Roland McGrath 2008-01-30 872 user_enable_block_step(child); 5b88abbf770a0e Roland McGrath 2008-01-30 873 } else if (is_singlestep(request) || is_sysemu_singlestep(request)) { 36df29d7994180 Roland McGrath 2008-01-30 874 if (unlikely(!arch_has_single_step())) 36df29d7994180 Roland McGrath 2008-01-30 875 return -EIO; 36df29d7994180 Roland McGrath 2008-01-30 876 user_enable_single_step(child); 3a709703538c47 Roland McGrath 2009-04-07 877 } else { 36df29d7994180 Roland McGrath 2008-01-30 878 user_disable_single_step(child); 3a709703538c47 Roland McGrath 2009-04-07 879 } 36df29d7994180 Roland McGrath 2008-01-30 880 b72c186999e689 Oleg Nesterov 2015-04-16 881 /* b72c186999e689 Oleg Nesterov 2015-04-16 882 * Change ->exit_code and ->state under siglock to avoid the race b72c186999e689 Oleg Nesterov 2015-04-16 883 * with wait_task_stopped() in between; a non-zero ->exit_code will b72c186999e689 Oleg Nesterov 2015-04-16 884 * wrongly look like another report from tracee. b72c186999e689 Oleg Nesterov 2015-04-16 885 * b72c186999e689 Oleg Nesterov 2015-04-16 886 * Note that we need siglock even if ->exit_code == data and/or this b72c186999e689 Oleg Nesterov 2015-04-16 887 * status was not reported yet, the new status must not be cleared by b72c186999e689 Oleg Nesterov 2015-04-16 888 * wait_task_stopped() after resume. b72c186999e689 Oleg Nesterov 2015-04-16 889 * b72c186999e689 Oleg Nesterov 2015-04-16 890 * If data == 0 we do not care if wait_task_stopped() reports the old b72c186999e689 Oleg Nesterov 2015-04-16 891 * status and clears the code too; this can't race with the tracee, it b72c186999e689 Oleg Nesterov 2015-04-16 892 * takes siglock after resume. b72c186999e689 Oleg Nesterov 2015-04-16 893 */ b72c186999e689 Oleg Nesterov 2015-04-16 @894 if (need_siglock) b72c186999e689 Oleg Nesterov 2015-04-16 895 spin_lock_irq(&child->sighand->siglock); 36df29d7994180 Roland McGrath 2008-01-30 896 child->exit_code = data; 0666fb51b1483f Oleg Nesterov 2011-05-25 897 wake_up_state(child, __TASK_TRACED); b72c186999e689 Oleg Nesterov 2015-04-16 898 if (need_siglock) b72c186999e689 Oleg Nesterov 2015-04-16 899 spin_unlock_irq(&child->sighand->siglock); 36df29d7994180 Roland McGrath 2008-01-30 900 36df29d7994180 Roland McGrath 2008-01-30 901 return 0; 36df29d7994180 Roland McGrath 2008-01-30 902 } 36df29d7994180 Roland McGrath 2008-01-30 903 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
