CC: [email protected]
BCC: [email protected]
CC: [email protected]
TO: Gabriel Niebler <[email protected]>
CC: David Sterba <[email protected]>

tree:   https://github.com/kdave/btrfs-devel.git for-next
head:   6a298ff0407012ed97f9464bf9bd37d91783ee95
commit: a8f70c56701d0f7d487b13baba02191423704a78 [144/164] btrfs: convert 
delayed_nodes_tree into an xarray
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: i386-randconfig-c021 
(https://download.01.org/0day-ci/archive/20220422/[email protected]/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Julia Lawall <[email protected]>


cocci warnings: (new ones prefixed by >>)
>> fs/btrfs/delayed-inode.c:144:2-11: second lock on line 144

vim +144 fs/btrfs/delayed-inode.c

2f7e33d432d097a Miao Xie        2011-06-23  121  
79787eaab46121d Jeff Mahoney    2012-03-12  122  /* Will return either the node 
or PTR_ERR(-ENOMEM) */
2f7e33d432d097a Miao Xie        2011-06-23  123  static struct 
btrfs_delayed_node *btrfs_get_or_create_delayed_node(
e5517a7bffafdeb Nikolay Borisov 2017-01-10  124                 struct 
btrfs_inode *btrfs_inode)
2f7e33d432d097a Miao Xie        2011-06-23  125  {
2f7e33d432d097a Miao Xie        2011-06-23  126         struct 
btrfs_delayed_node *node;
2f7e33d432d097a Miao Xie        2011-06-23  127         struct btrfs_root *root 
= btrfs_inode->root;
4a0cc7ca6c40b60 Nikolay Borisov 2017-01-10  128         u64 ino = 
btrfs_ino(btrfs_inode);
2f7e33d432d097a Miao Xie        2011-06-23  129         int ret;
2f7e33d432d097a Miao Xie        2011-06-23  130  
a8f70c56701d0f7 Gabriel Niebler 2022-04-19  131         do {
340c6ca9fd07703 Nikolay Borisov 2017-01-10  132                 node = 
btrfs_get_delayed_node(btrfs_inode);
2f7e33d432d097a Miao Xie        2011-06-23  133                 if (node)
2f7e33d432d097a Miao Xie        2011-06-23  134                         return 
node;
2f7e33d432d097a Miao Xie        2011-06-23  135  
352dd9c8d3b34e4 Alexandru Moise 2015-10-25  136                 node = 
kmem_cache_zalloc(delayed_node_cache, GFP_NOFS);
16cdcec736cd214 Miao Xie        2011-04-22  137                 if (!node)
16cdcec736cd214 Miao Xie        2011-04-22  138                         return 
ERR_PTR(-ENOMEM);
0d0ca30f1809062 Chris Mason     2011-05-22  139                 
btrfs_init_delayed_node(node, root, ino);
16cdcec736cd214 Miao Xie        2011-04-22  140  
a8f70c56701d0f7 Gabriel Niebler 2022-04-19  141                 /* Cached in 
the btrfs inode and can be accessed */
6de5f18e7b0da0c Elena Reshetova 2017-03-03  142                 
refcount_set(&node->refs, 2);
16cdcec736cd214 Miao Xie        2011-04-22  143  
16cdcec736cd214 Miao Xie        2011-04-22 @144                 
spin_lock(&root->inode_lock);
a8f70c56701d0f7 Gabriel Niebler 2022-04-19  145                 ret = 
xa_insert(&root->delayed_nodes, ino, node, GFP_NOFS);
a8f70c56701d0f7 Gabriel Niebler 2022-04-19  146                 if (ret) {
16cdcec736cd214 Miao Xie        2011-04-22  147                         
spin_unlock(&root->inode_lock);
964930312aec583 Jeff Mahoney    2014-05-27  148                         
kmem_cache_free(delayed_node_cache, node);
a8f70c56701d0f7 Gabriel Niebler 2022-04-19  149                         if (ret 
!= -EBUSY)
a8f70c56701d0f7 Gabriel Niebler 2022-04-19  150                                 
return ERR_PTR(ret);
16cdcec736cd214 Miao Xie        2011-04-22  151                 }
a8f70c56701d0f7 Gabriel Niebler 2022-04-19  152         } while (ret);
16cdcec736cd214 Miao Xie        2011-04-22  153         
btrfs_inode->delayed_node = node;
16cdcec736cd214 Miao Xie        2011-04-22  154         
spin_unlock(&root->inode_lock);
16cdcec736cd214 Miao Xie        2011-04-22  155  
16cdcec736cd214 Miao Xie        2011-04-22  156         return node;
16cdcec736cd214 Miao Xie        2011-04-22  157  }
16cdcec736cd214 Miao Xie        2011-04-22  158  

:::::: The code at line 144 was first introduced by commit
:::::: 16cdcec736cd214350cdb591bf1091f8beedefa0 btrfs: implement delayed inode 
items operation

:::::: TO: Miao Xie <[email protected]>
:::::: CC: Chris Mason <[email protected]>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to