CC: [email protected] BCC: [email protected] CC: "GNU/Weeb Mailing List" <[email protected]> CC: [email protected] TO: David Howells <[email protected]>
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-maple head: 931e50676c6598d0eda1954ead465519ff91874d commit: d1c47ebbbed8921181b4573ba5736595bc3b787c [30/44] netfs: Support decryption on DIO read :::::: branch date: 12 hours ago :::::: commit date: 14 hours ago config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220423/[email protected]/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: fs/netfs/direct_read.c:198 netfs_direct_read_iter() warn: statement has no effect 3 vim +198 fs/netfs/direct_read.c 4efd404b77925f9 David Howells 2022-01-14 116 4efd404b77925f9 David Howells 2022-01-14 117 /** 4efd404b77925f9 David Howells 2022-01-14 118 * netfs_direct_read_iter - Perform a direct I/O read 4efd404b77925f9 David Howells 2022-01-14 119 * @iocb: The I/O control descriptor describing the read 4efd404b77925f9 David Howells 2022-01-14 120 * @iter: The output buffer (also specifies read length) 4efd404b77925f9 David Howells 2022-01-14 121 */ 4efd404b77925f9 David Howells 2022-01-14 122 ssize_t netfs_direct_read_iter(struct kiocb *iocb, struct iov_iter *iter) 4efd404b77925f9 David Howells 2022-01-14 123 { 4efd404b77925f9 David Howells 2022-01-14 124 struct netfs_io_request *rreq; d1c47ebbbed8921 David Howells 2022-02-17 125 struct netfs_i_context *ctx; d1c47ebbbed8921 David Howells 2022-02-17 126 ssize_t n, ret; 4efd404b77925f9 David Howells 2022-01-14 127 4efd404b77925f9 David Howells 2022-01-14 128 _enter(""); 4efd404b77925f9 David Howells 2022-01-14 129 4efd404b77925f9 David Howells 2022-01-14 130 rreq = netfs_alloc_request(iocb->ki_filp->f_mapping, iocb->ki_filp, 4efd404b77925f9 David Howells 2022-01-14 131 iocb->ki_pos, iov_iter_count(iter), 4efd404b77925f9 David Howells 2022-01-14 132 NETFS_DIO_READ); 4efd404b77925f9 David Howells 2022-01-14 133 if (IS_ERR(rreq)) 4efd404b77925f9 David Howells 2022-01-14 134 return PTR_ERR(rreq); 4efd404b77925f9 David Howells 2022-01-14 135 d1c47ebbbed8921 David Howells 2022-02-17 136 ctx = netfs_i_context(rreq->inode); 4efd404b77925f9 David Howells 2022-01-14 137 netfs_stat(&netfs_n_rh_dio_read); 4efd404b77925f9 David Howells 2022-01-14 138 trace_netfs_read(rreq, rreq->start, rreq->len, netfs_read_trace_dio_read); 4efd404b77925f9 David Howells 2022-01-14 139 d1c47ebbbed8921 David Howells 2022-02-17 140 rreq->buffering = NETFS_DIRECT; d1c47ebbbed8921 David Howells 2022-02-17 141 if (test_bit(NETFS_RREQ_CONTENT_ENCRYPTION, &rreq->flags)) { d1c47ebbbed8921 David Howells 2022-02-17 142 static const enum netfs_buffering buffering[2][2] = { d1c47ebbbed8921 David Howells 2022-02-17 143 /* [async][aligned] */ d1c47ebbbed8921 David Howells 2022-02-17 144 [false][false] = NETFS_BOUNCE_DEC_COPY, d1c47ebbbed8921 David Howells 2022-02-17 145 [false][true] = NETFS_BOUNCE_DEC_TO_DIRECT, d1c47ebbbed8921 David Howells 2022-02-17 146 [true ][false] = NETFS_BOUNCE_DEC_COPY_BV, d1c47ebbbed8921 David Howells 2022-02-17 147 [true ][true] = NETFS_BOUNCE_DEC_TO_DIRECT_BV, d1c47ebbbed8921 David Howells 2022-02-17 148 }; d1c47ebbbed8921 David Howells 2022-02-17 149 bool aligned = netfs_is_crypto_aligned(rreq, iter); d1c47ebbbed8921 David Howells 2022-02-17 150 bool async = !is_sync_kiocb(iocb); d1c47ebbbed8921 David Howells 2022-02-17 151 d1c47ebbbed8921 David Howells 2022-02-17 152 rreq->buffering = buffering[async][aligned]; d1c47ebbbed8921 David Howells 2022-02-17 153 } d1c47ebbbed8921 David Howells 2022-02-17 154 d1c47ebbbed8921 David Howells 2022-02-17 155 kdebug("remote_i %llx %llx %llx", d1c47ebbbed8921 David Howells 2022-02-17 156 ctx->remote_i_size, rreq->i_size, i_size_read(netfs_inode(ctx))); 4efd404b77925f9 David Howells 2022-01-14 157 4efd404b77925f9 David Howells 2022-01-14 158 /* If this is an async op, we have to keep track of the destination 4efd404b77925f9 David Howells 2022-01-14 159 * buffer for ourselves as the caller's iterator will be trashed when 4efd404b77925f9 David Howells 2022-01-14 160 * we return. 4efd404b77925f9 David Howells 2022-01-14 161 * 4efd404b77925f9 David Howells 2022-01-14 162 * In such a case, extract an iterator to represent as much of the the 4efd404b77925f9 David Howells 2022-01-14 163 * output buffer as we can manage. Note that the extraction might not 4efd404b77925f9 David Howells 2022-01-14 164 * be able to allocate a sufficiently large bvec array and may shorten 4efd404b77925f9 David Howells 2022-01-14 165 * the request. 4efd404b77925f9 David Howells 2022-01-14 166 */ 4efd404b77925f9 David Howells 2022-01-14 167 switch (rreq->buffering) { 4efd404b77925f9 David Howells 2022-01-14 168 case NETFS_DIRECT: d1c47ebbbed8921 David Howells 2022-02-17 169 case NETFS_BOUNCE_DEC_TO_DIRECT: d1c47ebbbed8921 David Howells 2022-02-17 170 case NETFS_BOUNCE_DEC_COPY: 4efd404b77925f9 David Howells 2022-01-14 171 rreq->direct_iter = *iter; 4efd404b77925f9 David Howells 2022-01-14 172 rreq->len = iov_iter_count(&rreq->direct_iter); 4efd404b77925f9 David Howells 2022-01-14 173 break; 4efd404b77925f9 David Howells 2022-01-14 174 case NETFS_DIRECT_BV: d1c47ebbbed8921 David Howells 2022-02-17 175 case NETFS_BOUNCE_DEC_TO_DIRECT_BV: d1c47ebbbed8921 David Howells 2022-02-17 176 case NETFS_BOUNCE_DEC_COPY_BV: 4efd404b77925f9 David Howells 2022-01-14 177 n = extract_iter_to_iter(iter, rreq->len, &rreq->direct_iter, 4efd404b77925f9 David Howells 2022-01-14 178 &rreq->direct_bv); 4efd404b77925f9 David Howells 2022-01-14 179 if (n < 0) { d1c47ebbbed8921 David Howells 2022-02-17 180 ret = n; d1c47ebbbed8921 David Howells 2022-02-17 181 goto out; 4efd404b77925f9 David Howells 2022-01-14 182 } 4efd404b77925f9 David Howells 2022-01-14 183 rreq->direct_bv_count = n; 4efd404b77925f9 David Howells 2022-01-14 184 rreq->len = iov_iter_count(&rreq->direct_iter); 4efd404b77925f9 David Howells 2022-01-14 185 break; 4efd404b77925f9 David Howells 2022-01-14 186 default: 4efd404b77925f9 David Howells 2022-01-14 187 BUG(); 4efd404b77925f9 David Howells 2022-01-14 188 } 4efd404b77925f9 David Howells 2022-01-14 189 d1c47ebbbed8921 David Howells 2022-02-17 190 /* If we're going to use a bounce buffer, we need to set it up. We d1c47ebbbed8921 David Howells 2022-02-17 191 * will then need to pad the request out to the minimum block size. d1c47ebbbed8921 David Howells 2022-02-17 192 */ d1c47ebbbed8921 David Howells 2022-02-17 193 switch (rreq->buffering) { d1c47ebbbed8921 David Howells 2022-02-17 194 case NETFS_BOUNCE_DEC_TO_DIRECT: d1c47ebbbed8921 David Howells 2022-02-17 195 case NETFS_BOUNCE_DEC_COPY: d1c47ebbbed8921 David Howells 2022-02-17 196 case NETFS_BOUNCE_DEC_TO_DIRECT_BV: d1c47ebbbed8921 David Howells 2022-02-17 197 case NETFS_BOUNCE_DEC_COPY_BV: d1c47ebbbed8921 David Howells 2022-02-17 @198 unsigned int min_bsize = 1ULL << ctx->min_bshift; -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
