CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: zhenwei pi <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: zhenwei pi <[email protected]>
Hi zhenwei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on herbert-cryptodev-2.6/master] [also build test WARNING on linus/master v5.18-rc3 next-20220422] [cannot apply to herbert-crypto-2.6/master linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/virtio-crypto-Improve-performance/20220424-184732 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master :::::: branch date: 5 hours ago :::::: commit date: 5 hours ago config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220424/[email protected]/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:165 virtio_crypto_alg_akcipher_init_session() error: potentially dereferencing uninitialized 'input'. drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:230 virtio_crypto_alg_akcipher_close_session() error: uninitialized symbol 'vc_ctrl_req'. drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:232 virtio_crypto_alg_akcipher_close_session() error: potentially dereferencing uninitialized 'ctrl_status'. drivers/crypto/virtio/virtio_crypto_akcipher_algs.c:232 virtio_crypto_alg_akcipher_close_session() error: potentially dereferencing uninitialized 'destroy_session'. vim +/input +165 drivers/crypto/virtio/virtio_crypto_akcipher_algs.c 59ca6c93387d32 zhenwei pi 2022-03-02 98 59ca6c93387d32 zhenwei pi 2022-03-02 99 static int virtio_crypto_alg_akcipher_init_session(struct virtio_crypto_akcipher_ctx *ctx, 59ca6c93387d32 zhenwei pi 2022-03-02 100 struct virtio_crypto_ctrl_header *header, void *para, 59ca6c93387d32 zhenwei pi 2022-03-02 101 const uint8_t *key, unsigned int keylen) 59ca6c93387d32 zhenwei pi 2022-03-02 102 { 59ca6c93387d32 zhenwei pi 2022-03-02 103 struct scatterlist outhdr_sg, key_sg, inhdr_sg, *sgs[3]; 59ca6c93387d32 zhenwei pi 2022-03-02 104 struct virtio_crypto *vcrypto = ctx->vcrypto; 59ca6c93387d32 zhenwei pi 2022-03-02 105 uint8_t *pkey; 59ca6c93387d32 zhenwei pi 2022-03-02 106 unsigned int inlen; 59ca6c93387d32 zhenwei pi 2022-03-02 107 int err; 59ca6c93387d32 zhenwei pi 2022-03-02 108 unsigned int num_out = 0, num_in = 0; bb26cab9a7c25d zhenwei pi 2022-04-24 109 struct virtio_crypto_op_ctrl_req *ctrl; bb26cab9a7c25d zhenwei pi 2022-04-24 110 struct virtio_crypto_session_input *input; 286da9ed04239c zhenwei pi 2022-04-24 111 struct virtio_crypto_ctrl_request *vc_ctrl_req; 59ca6c93387d32 zhenwei pi 2022-03-02 112 59ca6c93387d32 zhenwei pi 2022-03-02 113 pkey = kmemdup(key, keylen, GFP_ATOMIC); 59ca6c93387d32 zhenwei pi 2022-03-02 114 if (!pkey) 59ca6c93387d32 zhenwei pi 2022-03-02 115 return -ENOMEM; 59ca6c93387d32 zhenwei pi 2022-03-02 116 286da9ed04239c zhenwei pi 2022-04-24 117 vc_ctrl_req = kzalloc(sizeof(*vc_ctrl_req), GFP_KERNEL); 286da9ed04239c zhenwei pi 2022-04-24 118 if (!vc_ctrl_req) { 286da9ed04239c zhenwei pi 2022-04-24 119 err = -ENOMEM; 286da9ed04239c zhenwei pi 2022-04-24 120 goto out; 286da9ed04239c zhenwei pi 2022-04-24 121 } 286da9ed04239c zhenwei pi 2022-04-24 122 286da9ed04239c zhenwei pi 2022-04-24 123 ctrl = &vc_ctrl_req->ctrl; bb26cab9a7c25d zhenwei pi 2022-04-24 124 memcpy(&ctrl->header, header, sizeof(ctrl->header)); bb26cab9a7c25d zhenwei pi 2022-04-24 125 memcpy(&ctrl->u, para, sizeof(ctrl->u)); 286da9ed04239c zhenwei pi 2022-04-24 126 input = &vc_ctrl_req->input; bb26cab9a7c25d zhenwei pi 2022-04-24 127 input->status = cpu_to_le32(VIRTIO_CRYPTO_ERR); 59ca6c93387d32 zhenwei pi 2022-03-02 128 bb26cab9a7c25d zhenwei pi 2022-04-24 129 sg_init_one(&outhdr_sg, ctrl, sizeof(*ctrl)); 59ca6c93387d32 zhenwei pi 2022-03-02 130 sgs[num_out++] = &outhdr_sg; 59ca6c93387d32 zhenwei pi 2022-03-02 131 59ca6c93387d32 zhenwei pi 2022-03-02 132 sg_init_one(&key_sg, pkey, keylen); 59ca6c93387d32 zhenwei pi 2022-03-02 133 sgs[num_out++] = &key_sg; 59ca6c93387d32 zhenwei pi 2022-03-02 134 bb26cab9a7c25d zhenwei pi 2022-04-24 135 sg_init_one(&inhdr_sg, input, sizeof(*input)); 59ca6c93387d32 zhenwei pi 2022-03-02 136 sgs[num_out + num_in++] = &inhdr_sg; 59ca6c93387d32 zhenwei pi 2022-03-02 137 286da9ed04239c zhenwei pi 2022-04-24 138 spin_lock(&vcrypto->ctrl_lock); 59ca6c93387d32 zhenwei pi 2022-03-02 139 err = virtqueue_add_sgs(vcrypto->ctrl_vq, sgs, num_out, num_in, vcrypto, GFP_ATOMIC); 286da9ed04239c zhenwei pi 2022-04-24 140 if (err < 0) { 286da9ed04239c zhenwei pi 2022-04-24 141 spin_unlock(&vcrypto->ctrl_lock); 59ca6c93387d32 zhenwei pi 2022-03-02 142 goto out; 286da9ed04239c zhenwei pi 2022-04-24 143 } 59ca6c93387d32 zhenwei pi 2022-03-02 144 59ca6c93387d32 zhenwei pi 2022-03-02 145 virtqueue_kick(vcrypto->ctrl_vq); 59ca6c93387d32 zhenwei pi 2022-03-02 146 while (!virtqueue_get_buf(vcrypto->ctrl_vq, &inlen) && 59ca6c93387d32 zhenwei pi 2022-03-02 147 !virtqueue_is_broken(vcrypto->ctrl_vq)) 59ca6c93387d32 zhenwei pi 2022-03-02 148 cpu_relax(); 286da9ed04239c zhenwei pi 2022-04-24 149 spin_unlock(&vcrypto->ctrl_lock); 59ca6c93387d32 zhenwei pi 2022-03-02 150 bb26cab9a7c25d zhenwei pi 2022-04-24 151 if (le32_to_cpu(input->status) != VIRTIO_CRYPTO_OK) { 59ca6c93387d32 zhenwei pi 2022-03-02 152 err = -EINVAL; 59ca6c93387d32 zhenwei pi 2022-03-02 153 goto out; 59ca6c93387d32 zhenwei pi 2022-03-02 154 } 59ca6c93387d32 zhenwei pi 2022-03-02 155 bb26cab9a7c25d zhenwei pi 2022-04-24 156 ctx->session_id = le64_to_cpu(input->session_id); 59ca6c93387d32 zhenwei pi 2022-03-02 157 ctx->session_valid = true; 59ca6c93387d32 zhenwei pi 2022-03-02 158 err = 0; 59ca6c93387d32 zhenwei pi 2022-03-02 159 59ca6c93387d32 zhenwei pi 2022-03-02 160 out: 286da9ed04239c zhenwei pi 2022-04-24 161 kfree(vc_ctrl_req); 59ca6c93387d32 zhenwei pi 2022-03-02 162 kfree_sensitive(pkey); 59ca6c93387d32 zhenwei pi 2022-03-02 163 59ca6c93387d32 zhenwei pi 2022-03-02 164 if (err < 0) 59ca6c93387d32 zhenwei pi 2022-03-02 @165 pr_err("virtio_crypto: Create session failed status: %u\n", bb26cab9a7c25d zhenwei pi 2022-04-24 166 le32_to_cpu(input->status)); 59ca6c93387d32 zhenwei pi 2022-03-02 167 59ca6c93387d32 zhenwei pi 2022-03-02 168 return err; 59ca6c93387d32 zhenwei pi 2022-03-02 169 } 59ca6c93387d32 zhenwei pi 2022-03-02 170 59ca6c93387d32 zhenwei pi 2022-03-02 171 static int virtio_crypto_alg_akcipher_close_session(struct virtio_crypto_akcipher_ctx *ctx) 59ca6c93387d32 zhenwei pi 2022-03-02 172 { 59ca6c93387d32 zhenwei pi 2022-03-02 173 struct scatterlist outhdr_sg, inhdr_sg, *sgs[2]; 59ca6c93387d32 zhenwei pi 2022-03-02 174 struct virtio_crypto_destroy_session_req *destroy_session; 59ca6c93387d32 zhenwei pi 2022-03-02 175 struct virtio_crypto *vcrypto = ctx->vcrypto; 59ca6c93387d32 zhenwei pi 2022-03-02 176 unsigned int num_out = 0, num_in = 0, inlen; 59ca6c93387d32 zhenwei pi 2022-03-02 177 int err; bb26cab9a7c25d zhenwei pi 2022-04-24 178 struct virtio_crypto_op_ctrl_req *ctrl; bb26cab9a7c25d zhenwei pi 2022-04-24 179 struct virtio_crypto_inhdr *ctrl_status; 286da9ed04239c zhenwei pi 2022-04-24 180 struct virtio_crypto_ctrl_request *vc_ctrl_req; 59ca6c93387d32 zhenwei pi 2022-03-02 181 59ca6c93387d32 zhenwei pi 2022-03-02 182 if (!ctx->session_valid) { 59ca6c93387d32 zhenwei pi 2022-03-02 183 err = 0; 59ca6c93387d32 zhenwei pi 2022-03-02 184 goto out; 59ca6c93387d32 zhenwei pi 2022-03-02 185 } 286da9ed04239c zhenwei pi 2022-04-24 186 286da9ed04239c zhenwei pi 2022-04-24 187 vc_ctrl_req = kzalloc(sizeof(*vc_ctrl_req), GFP_KERNEL); 286da9ed04239c zhenwei pi 2022-04-24 188 if (!vc_ctrl_req) { 286da9ed04239c zhenwei pi 2022-04-24 189 err = -ENOMEM; 286da9ed04239c zhenwei pi 2022-04-24 190 goto out; 286da9ed04239c zhenwei pi 2022-04-24 191 } 286da9ed04239c zhenwei pi 2022-04-24 192 286da9ed04239c zhenwei pi 2022-04-24 193 ctrl_status = &vc_ctrl_req->ctrl_status; bb26cab9a7c25d zhenwei pi 2022-04-24 194 ctrl_status->status = VIRTIO_CRYPTO_ERR; 286da9ed04239c zhenwei pi 2022-04-24 195 ctrl = &vc_ctrl_req->ctrl; bb26cab9a7c25d zhenwei pi 2022-04-24 196 ctrl->header.opcode = cpu_to_le32(VIRTIO_CRYPTO_AKCIPHER_DESTROY_SESSION); bb26cab9a7c25d zhenwei pi 2022-04-24 197 ctrl->header.queue_id = 0; 59ca6c93387d32 zhenwei pi 2022-03-02 198 bb26cab9a7c25d zhenwei pi 2022-04-24 199 destroy_session = &ctrl->u.destroy_session; 59ca6c93387d32 zhenwei pi 2022-03-02 200 destroy_session->session_id = cpu_to_le64(ctx->session_id); 59ca6c93387d32 zhenwei pi 2022-03-02 201 bb26cab9a7c25d zhenwei pi 2022-04-24 202 sg_init_one(&outhdr_sg, ctrl, sizeof(*ctrl)); 59ca6c93387d32 zhenwei pi 2022-03-02 203 sgs[num_out++] = &outhdr_sg; 59ca6c93387d32 zhenwei pi 2022-03-02 204 bb26cab9a7c25d zhenwei pi 2022-04-24 205 sg_init_one(&inhdr_sg, &ctrl_status->status, sizeof(ctrl_status->status)); 59ca6c93387d32 zhenwei pi 2022-03-02 206 sgs[num_out + num_in++] = &inhdr_sg; 59ca6c93387d32 zhenwei pi 2022-03-02 207 286da9ed04239c zhenwei pi 2022-04-24 208 spin_lock(&vcrypto->ctrl_lock); 59ca6c93387d32 zhenwei pi 2022-03-02 209 err = virtqueue_add_sgs(vcrypto->ctrl_vq, sgs, num_out, num_in, vcrypto, GFP_ATOMIC); 286da9ed04239c zhenwei pi 2022-04-24 210 if (err < 0) { 286da9ed04239c zhenwei pi 2022-04-24 211 spin_unlock(&vcrypto->ctrl_lock); 59ca6c93387d32 zhenwei pi 2022-03-02 212 goto out; 286da9ed04239c zhenwei pi 2022-04-24 213 } 59ca6c93387d32 zhenwei pi 2022-03-02 214 59ca6c93387d32 zhenwei pi 2022-03-02 215 virtqueue_kick(vcrypto->ctrl_vq); 59ca6c93387d32 zhenwei pi 2022-03-02 216 while (!virtqueue_get_buf(vcrypto->ctrl_vq, &inlen) && 59ca6c93387d32 zhenwei pi 2022-03-02 217 !virtqueue_is_broken(vcrypto->ctrl_vq)) 59ca6c93387d32 zhenwei pi 2022-03-02 218 cpu_relax(); 286da9ed04239c zhenwei pi 2022-04-24 219 spin_unlock(&vcrypto->ctrl_lock); 59ca6c93387d32 zhenwei pi 2022-03-02 220 bb26cab9a7c25d zhenwei pi 2022-04-24 221 if (ctrl_status->status != VIRTIO_CRYPTO_OK) { 59ca6c93387d32 zhenwei pi 2022-03-02 222 err = -EINVAL; 59ca6c93387d32 zhenwei pi 2022-03-02 223 goto out; 59ca6c93387d32 zhenwei pi 2022-03-02 224 } 59ca6c93387d32 zhenwei pi 2022-03-02 225 59ca6c93387d32 zhenwei pi 2022-03-02 226 err = 0; 59ca6c93387d32 zhenwei pi 2022-03-02 227 ctx->session_valid = false; 59ca6c93387d32 zhenwei pi 2022-03-02 228 59ca6c93387d32 zhenwei pi 2022-03-02 229 out: 286da9ed04239c zhenwei pi 2022-04-24 @230 kfree(vc_ctrl_req); 59ca6c93387d32 zhenwei pi 2022-03-02 231 if (err < 0) { 59ca6c93387d32 zhenwei pi 2022-03-02 @232 pr_err("virtio_crypto: Close session failed status: %u, session_id: 0x%llx\n", bb26cab9a7c25d zhenwei pi 2022-04-24 233 ctrl_status->status, destroy_session->session_id); 59ca6c93387d32 zhenwei pi 2022-03-02 234 } 59ca6c93387d32 zhenwei pi 2022-03-02 235 59ca6c93387d32 zhenwei pi 2022-03-02 236 return err; 59ca6c93387d32 zhenwei pi 2022-03-02 237 } 59ca6c93387d32 zhenwei pi 2022-03-02 238 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
