CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Konrad Dybcio <[email protected]> TO: ~postmarketos/[email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: Konrad Dybcio <[email protected]> CC: Amit Kucheria <[email protected]> CC: Thara Gopinath <[email protected]> CC: Andy Gross <[email protected]> CC: Bjorn Andersson <[email protected]> CC: "Rafael J. Wysocki" <[email protected]> CC: Daniel Lezcano <[email protected]> CC: Zhang Rui <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected]
Hi Konrad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rafael-pm/thermal] [also build test WARNING on robh/for-next v5.18-rc5 next-20220429] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/dt-bindings-thermal-tsens-Add-msm8992-4-compatibles/20220502-042413 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal :::::: branch date: 3 hours ago :::::: commit date: 3 hours ago compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout db030f5538c8beb36e6cde82bead3c57131c58b5 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/thermal/qcom/tsens-v1.c:465:5: warning: Mismatching assignment and >> comparison, comparison 'calib_redun_sel==0x3' is always false. >> [assignIfError] if (calib_redun_sel == BKP_SEL) { ^ drivers/thermal/qcom/tsens-v1.c:462:18: note: Mismatching assignment and comparison, comparison 'calib_redun_sel==0x3' is always false. calib_redun_sel = calib_rsel[0] & MSM8994_CAL_SEL_REDUN_MASK; ^ drivers/thermal/qcom/tsens-v1.c:465:5: note: Mismatching assignment and comparison, comparison 'calib_redun_sel==0x3' is always false. if (calib_redun_sel == BKP_SEL) { ^ drivers/thermal/qcom/tsens-v1.c:239:15: warning: Parameter 'p1' can be declared with const [constParameter] u32 *p1, u32 *p2, u32 mode) ^ >> drivers/thermal/qcom/tsens-v1.c:264:37: warning: Parameter 'p' can be >> declared with const [constParameter] u32 base0, u32 base1, u32 *p, u32 mode) ^ vim +465 drivers/thermal/qcom/tsens-v1.c 0e580290170dfb AngeloGioacchino Del Regno 2019-10-05 415 db030f5538c8be Konrad Dybcio 2022-05-01 416 static int calibrate_8994(struct tsens_priv *priv) db030f5538c8be Konrad Dybcio 2022-05-01 417 { db030f5538c8be Konrad Dybcio 2022-05-01 418 int base0 = 0, base1 = 0; db030f5538c8be Konrad Dybcio 2022-05-01 419 u32 p[16] = { [0 ... 15] = 532 }; /* HW-specific, undocumented magic value */ db030f5538c8be Konrad Dybcio 2022-05-01 420 int mode = 0; db030f5538c8be Konrad Dybcio 2022-05-01 421 u32 *calib0, *calib1, *calib2, *calib_mode, *calib_rsel; db030f5538c8be Konrad Dybcio 2022-05-01 422 u32 calib_redun_sel; db030f5538c8be Konrad Dybcio 2022-05-01 423 db030f5538c8be Konrad Dybcio 2022-05-01 424 /* 0x40d0-0x40dc */ db030f5538c8be Konrad Dybcio 2022-05-01 425 calib0 = (u32 *)qfprom_read(priv->dev, "calib"); db030f5538c8be Konrad Dybcio 2022-05-01 426 if (IS_ERR(calib0)) db030f5538c8be Konrad Dybcio 2022-05-01 427 return PTR_ERR(calib0); db030f5538c8be Konrad Dybcio 2022-05-01 428 db030f5538c8be Konrad Dybcio 2022-05-01 429 dev_dbg(priv->dev, "%s: calib0: [0] = %u, [1] = %u, [2] = %u\n", db030f5538c8be Konrad Dybcio 2022-05-01 430 __func__, calib0[0], calib0[1], calib0[2]); db030f5538c8be Konrad Dybcio 2022-05-01 431 db030f5538c8be Konrad Dybcio 2022-05-01 432 /* 0x41c0-0x41c8 */ db030f5538c8be Konrad Dybcio 2022-05-01 433 calib1 = (u32 *)qfprom_read(priv->dev, "calib_redun1_2"); db030f5538c8be Konrad Dybcio 2022-05-01 434 if (IS_ERR(calib1)) db030f5538c8be Konrad Dybcio 2022-05-01 435 return PTR_ERR(calib1); db030f5538c8be Konrad Dybcio 2022-05-01 436 db030f5538c8be Konrad Dybcio 2022-05-01 437 dev_dbg(priv->dev, "%s: calib1: [0] = %u, [1] = %u\n", db030f5538c8be Konrad Dybcio 2022-05-01 438 __func__, calib1[0], calib1[1]); db030f5538c8be Konrad Dybcio 2022-05-01 439 db030f5538c8be Konrad Dybcio 2022-05-01 440 /* 0x41cc-0x41d0 */ db030f5538c8be Konrad Dybcio 2022-05-01 441 calib2 = (u32 *)qfprom_read(priv->dev, "calib_redun3"); db030f5538c8be Konrad Dybcio 2022-05-01 442 if (IS_ERR(calib2)) db030f5538c8be Konrad Dybcio 2022-05-01 443 return PTR_ERR(calib2); db030f5538c8be Konrad Dybcio 2022-05-01 444 db030f5538c8be Konrad Dybcio 2022-05-01 445 dev_dbg(priv->dev, "%s: calib2: [0] = %u\n", __func__, calib2[0]); db030f5538c8be Konrad Dybcio 2022-05-01 446 db030f5538c8be Konrad Dybcio 2022-05-01 447 /* 0x4440-0x4448 */ db030f5538c8be Konrad Dybcio 2022-05-01 448 calib_mode = (u32 *)qfprom_read(priv->dev, "calib_redun4_5"); db030f5538c8be Konrad Dybcio 2022-05-01 449 if (IS_ERR(calib_mode)) db030f5538c8be Konrad Dybcio 2022-05-01 450 return PTR_ERR(calib_mode); db030f5538c8be Konrad Dybcio 2022-05-01 451 db030f5538c8be Konrad Dybcio 2022-05-01 452 dev_dbg(priv->dev, "%s: calib_mode: [0] = %u, [1] = %u\n", db030f5538c8be Konrad Dybcio 2022-05-01 453 __func__, calib1[0], calib1[1]); db030f5538c8be Konrad Dybcio 2022-05-01 454 db030f5538c8be Konrad Dybcio 2022-05-01 455 /* 0x4464-0x4468 */ db030f5538c8be Konrad Dybcio 2022-05-01 456 calib_rsel = (u32 *)qfprom_read(priv->dev, "calib_rsel"); db030f5538c8be Konrad Dybcio 2022-05-01 457 if (IS_ERR(calib_mode)) db030f5538c8be Konrad Dybcio 2022-05-01 458 return PTR_ERR(calib_mode); db030f5538c8be Konrad Dybcio 2022-05-01 459 db030f5538c8be Konrad Dybcio 2022-05-01 460 dev_dbg(priv->dev, "%s: calib_rsel: [0] = %u\n", __func__, calib_rsel[0]); db030f5538c8be Konrad Dybcio 2022-05-01 461 db030f5538c8be Konrad Dybcio 2022-05-01 462 calib_redun_sel = calib_rsel[0] & MSM8994_CAL_SEL_REDUN_MASK; db030f5538c8be Konrad Dybcio 2022-05-01 463 calib_redun_sel >>= MSM8994_CAL_SEL_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 464 db030f5538c8be Konrad Dybcio 2022-05-01 @465 if (calib_redun_sel == BKP_SEL) { db030f5538c8be Konrad Dybcio 2022-05-01 466 dev_dbg(priv->dev, "%s: Calibrating in REDUN mode, calib_redun_sel = %u", db030f5538c8be Konrad Dybcio 2022-05-01 467 __func__, calib_redun_sel); db030f5538c8be Konrad Dybcio 2022-05-01 468 mode = calib_mode[1] & MSM8994_REDUN_SEL_MASK; db030f5538c8be Konrad Dybcio 2022-05-01 469 db030f5538c8be Konrad Dybcio 2022-05-01 470 if (mode == TWO_PT_CALIB) { db030f5538c8be Konrad Dybcio 2022-05-01 471 dev_dbg(priv->dev, "%s: REDUN TWO_PT mode, mode = %u", __func__, mode); db030f5538c8be Konrad Dybcio 2022-05-01 472 base0 = (calib1[0] & MSM8994_BASE0_REDUN_MASK) >> MSM8994_BASE0_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 473 base1 = (calib1[0] & MSM8994_BASE1_BIT0_REDUN_MASK) >> MSM8994_BASE1_BIT0_REDUN_SHIFT_COMPUTE; db030f5538c8be Konrad Dybcio 2022-05-01 474 base1 |= calib1[1] & MSM8994_BASE1_BIT1_9_REDUN_MASK; db030f5538c8be Konrad Dybcio 2022-05-01 475 p[0] = (calib1[1] & MSM8994_S0_REDUN_MASK) >> MSM8994_S0_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 476 p[1] = (calib1[1] & MSM8994_S1_REDUN_MASK) >> MSM8994_S1_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 477 p[2] = (calib1[1] & MSM8994_S2_REDUN_MASK) >> MSM8994_S2_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 478 p[3] = (calib1[1] & MSM8994_S3_REDUN_MASK) >> MSM8994_S3_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 479 p[4] = (calib1[1] & MSM8994_S4_REDUN_MASK) >> MSM8994_S4_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 480 p[5] = (calib1[1] & MSM8994_S5_REDUN_MASK_BIT0_2) >> MSM8994_S5_REDUN_SHIFT_BIT0_2; db030f5538c8be Konrad Dybcio 2022-05-01 481 p[5] |= (calib2[0] & MSM8994_S5_REDUN_MASK_BIT3) >> MSM8994_S5_REDUN_SHIFT_BIT3; db030f5538c8be Konrad Dybcio 2022-05-01 482 p[6] = (calib2[0] & MSM8994_S6_REDUN_MASK) >> MSM8994_S6_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 483 p[7] = (calib2[0] & MSM8994_S7_REDUN_MASK) >> MSM8994_S7_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 484 p[8] = (calib2[0] & MSM8994_S8_REDUN_MASK) >> MSM8994_S8_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 485 p[9] = (calib2[0] & MSM8994_S9_REDUN_MASK) >> MSM8994_S9_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 486 p[10] = (calib2[0] & MSM8994_S10_REDUN_MASK) >> MSM8994_S10_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 487 p[11] = (calib2[0] & MSM8994_S11_REDUN_MASK) >> MSM8994_S11_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 488 p[12] = (calib2[0] & MSM8994_S12_REDUN_MASK) >> MSM8994_S12_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 489 p[13] = (calib2[0] & MSM8994_S13_REDUN_MASK) >> MSM8994_S13_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 490 p[14] = (calib2[0] & MSM8994_S14_REDUN_MASK) >> MSM8994_S14_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 491 p[15] = (calib2[0] & MSM8994_S15_REDUN_MASK) >> MSM8994_S15_REDUN_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 492 } else { db030f5538c8be Konrad Dybcio 2022-05-01 493 dev_dbg(priv->dev, "%s: REDUN NON-TWO_PT mode, mode = %u", __func__, mode); db030f5538c8be Konrad Dybcio 2022-05-01 494 } db030f5538c8be Konrad Dybcio 2022-05-01 495 } else { db030f5538c8be Konrad Dybcio 2022-05-01 496 dev_dbg(priv->dev, "%s: Calibrating in NOT-REDUN mode, calib_redun_sel = %u", db030f5538c8be Konrad Dybcio 2022-05-01 497 __func__, calib_redun_sel); db030f5538c8be Konrad Dybcio 2022-05-01 498 mode = (calib0[2] & MSM8994_CAL_SEL_MASK) >> MSM8994_CAL_SEL_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 499 db030f5538c8be Konrad Dybcio 2022-05-01 500 if (mode == TWO_PT_CALIB) { db030f5538c8be Konrad Dybcio 2022-05-01 501 dev_dbg(priv->dev, "%s: NOT-REDUN TWO_PT mode, mode = %u", __func__, mode); db030f5538c8be Konrad Dybcio 2022-05-01 502 base0 = (calib0[0] & MSM8994_BASE0_MASK) >> MSM8994_BASE0_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 503 base1 = (calib0[0] & MSM8994_BASE1_MASK) >> MSM8994_BASE1_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 504 p[0] = (calib0[0] & MSM8994_S0_MASK) >> MSM8994_S0_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 505 p[1] = (calib0[0] & MSM8994_S1_MASK) >> MSM8994_S1_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 506 p[2] = (calib0[1] & MSM8994_S2_MASK) >> MSM8994_S2_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 507 p[3] = (calib0[1] & MSM8994_S3_MASK) >> MSM8994_S3_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 508 p[4] = (calib0[1] & MSM8994_S4_MASK) >> MSM8994_S4_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 509 p[5] = (calib0[1] & MSM8994_S5_MASK) >> MSM8994_S5_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 510 p[6] = (calib0[1] & MSM8994_S6_MASK) >> MSM8994_S6_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 511 p[7] = (calib0[1] & MSM8994_S7_MASK) >> MSM8994_S7_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 512 p[8] = (calib0[1] & MSM8994_S8_MASK) >> MSM8994_S8_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 513 p[9] = (calib0[1] & MSM8994_S9_MASK) >> MSM8994_S9_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 514 p[10] = (calib0[1] & MSM8994_S10_MASK) >> MSM8994_S10_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 515 p[11] = (calib0[2] & MSM8994_S11_MASK) >> MSM8994_S11_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 516 p[12] = (calib0[2] & MSM8994_S12_MASK) >> MSM8994_S12_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 517 p[13] = (calib0[2] & MSM8994_S13_MASK) >> MSM8994_S13_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 518 p[14] = (calib0[2] & MSM8994_S14_MASK) >> MSM8994_S14_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 519 p[15] = (calib0[2] & MSM8994_S15_MASK) >> MSM8994_S15_SHIFT; db030f5538c8be Konrad Dybcio 2022-05-01 520 } else { db030f5538c8be Konrad Dybcio 2022-05-01 521 dev_dbg(priv->dev, "%s: NOT-REDUN NON-TWO_PT mode, mode = %u", __func__, mode); db030f5538c8be Konrad Dybcio 2022-05-01 522 /* Keep the init-time 532 value */ db030f5538c8be Konrad Dybcio 2022-05-01 523 } db030f5538c8be Konrad Dybcio 2022-05-01 524 } db030f5538c8be Konrad Dybcio 2022-05-01 525 db030f5538c8be Konrad Dybcio 2022-05-01 526 /* 8992 features less sensors and remaps some */ db030f5538c8be Konrad Dybcio 2022-05-01 527 if (priv->num_sensors == 13) { db030f5538c8be Konrad Dybcio 2022-05-01 528 p[6] = p[7]; db030f5538c8be Konrad Dybcio 2022-05-01 529 p[7] = p[9]; db030f5538c8be Konrad Dybcio 2022-05-01 530 p[8] = p[10]; db030f5538c8be Konrad Dybcio 2022-05-01 531 p[9] = p[11]; db030f5538c8be Konrad Dybcio 2022-05-01 532 p[10] = p[12]; db030f5538c8be Konrad Dybcio 2022-05-01 533 p[11] = p[13]; db030f5538c8be Konrad Dybcio 2022-05-01 534 p[12] = p[14]; db030f5538c8be Konrad Dybcio 2022-05-01 535 } db030f5538c8be Konrad Dybcio 2022-05-01 536 db030f5538c8be Konrad Dybcio 2022-05-01 537 compute_intercept_slope_8994(priv, base0, base1, p, mode); db030f5538c8be Konrad Dybcio 2022-05-01 538 kfree(calib0); db030f5538c8be Konrad Dybcio 2022-05-01 539 kfree(calib1); db030f5538c8be Konrad Dybcio 2022-05-01 540 kfree(calib2); db030f5538c8be Konrad Dybcio 2022-05-01 541 kfree(calib_mode); db030f5538c8be Konrad Dybcio 2022-05-01 542 kfree(calib_rsel); db030f5538c8be Konrad Dybcio 2022-05-01 543 db030f5538c8be Konrad Dybcio 2022-05-01 544 return 0; db030f5538c8be Konrad Dybcio 2022-05-01 545 } db030f5538c8be Konrad Dybcio 2022-05-01 546 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
