CC: [email protected] BCC: [email protected] In-Reply-To: <861c003318dce3d2bef4061711643bb04f5ec14f.1652201921.git.william.g...@linaro.org> References: <861c003318dce3d2bef4061711643bb04f5ec14f.1652201921.git.william.g...@linaro.org> TO: William Breathitt Gray <[email protected]> TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: William Breathitt Gray <[email protected]> CC: Syed Nayyar Waris <[email protected]>
Hi William, I love your patch! Perhaps something to improve: [auto build test WARNING on ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e] url: https://github.com/intel-lab-lkp/linux/commits/William-Breathitt-Gray/Utilize-iomap-interface-for-PC104-and-friends/20220511-013247 base: ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e :::::: branch date: 15 hours ago :::::: commit date: 15 hours ago config: i386-randconfig-m021-20220509 (https://download.01.org/0day-ci/archive/20220511/[email protected]/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/counter/104-quad-8.c:154 quad8_count_read() warn: should 'ioread8(base_offset) << (8 * i)' be a 64 bit type? vim +154 drivers/counter/104-quad-8.c f1d8a071d45bf1 William Breathitt Gray 2019-04-02 128 f1d8a071d45bf1 William Breathitt Gray 2019-04-02 129 static int quad8_count_read(struct counter_device *counter, aaec1a0f76ec25 William Breathitt Gray 2021-08-27 130 struct counter_count *count, u64 *val) f1d8a071d45bf1 William Breathitt Gray 2019-04-02 131 { aea8334b24feb0 Uwe Kleine-König 2021-12-30 132 struct quad8 *const priv = counter_priv(counter); 744c2317cf8c1f William Breathitt Gray 2022-05-10 133 void __iomem *const base_offset = priv->base + 2 * count->id; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 134 unsigned int flags; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 135 unsigned int borrow; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 136 unsigned int carry; 09db4678bfbb42 William Breathitt Gray 2021-09-29 137 unsigned long irqflags; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 138 int i; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 139 744c2317cf8c1f William Breathitt Gray 2022-05-10 140 flags = ioread8(base_offset + 1); f1d8a071d45bf1 William Breathitt Gray 2019-04-02 141 borrow = flags & QUAD8_FLAG_BT; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 142 carry = !!(flags & QUAD8_FLAG_CT); f1d8a071d45bf1 William Breathitt Gray 2019-04-02 143 f1d8a071d45bf1 William Breathitt Gray 2019-04-02 144 /* Borrow XOR Carry effectively doubles count range */ d49e6ee2d6c2b6 William Breathitt Gray 2019-10-06 145 *val = (unsigned long)(borrow ^ carry) << 24; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 146 09db4678bfbb42 William Breathitt Gray 2021-09-29 147 spin_lock_irqsave(&priv->lock, irqflags); fc069262261c43 Syed Nayyar Waris 2020-03-16 148 f1d8a071d45bf1 William Breathitt Gray 2019-04-02 149 /* Reset Byte Pointer; transfer Counter to Output Latch */ 744c2317cf8c1f William Breathitt Gray 2022-05-10 150 iowrite8(QUAD8_CTR_RLD | QUAD8_RLD_RESET_BP | QUAD8_RLD_CNTR_OUT, f1d8a071d45bf1 William Breathitt Gray 2019-04-02 151 base_offset + 1); f1d8a071d45bf1 William Breathitt Gray 2019-04-02 152 f1d8a071d45bf1 William Breathitt Gray 2019-04-02 153 for (i = 0; i < 3; i++) 744c2317cf8c1f William Breathitt Gray 2022-05-10 @154 *val |= (unsigned long)ioread8(base_offset) << (8 * i); f1d8a071d45bf1 William Breathitt Gray 2019-04-02 155 09db4678bfbb42 William Breathitt Gray 2021-09-29 156 spin_unlock_irqrestore(&priv->lock, irqflags); fc069262261c43 Syed Nayyar Waris 2020-03-16 157 f1d8a071d45bf1 William Breathitt Gray 2019-04-02 158 return 0; f1d8a071d45bf1 William Breathitt Gray 2019-04-02 159 } f1d8a071d45bf1 William Breathitt Gray 2019-04-02 160 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
