CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Bart Van Assche <[email protected]>
Hi Bart, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on jejb-scsi/for-next next-20220511] [cannot apply to krzk/for-next linus/master v5.18-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/scsi-ufs-Split-the-drivers-scsi-ufs-directory/20220512-052804 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next :::::: branch date: 12 hours ago :::::: commit date: 12 hours ago config: parisc-randconfig-m031-20220509 (https://download.01.org/0day-ci/archive/20220512/[email protected]/config) compiler: hppa-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/ufs/core/ufshcd.c:5283 ufshcd_uic_cmd_compl() error: we previously assumed 'hba->active_uic_cmd' could be null (see line 5271) vim +5283 drivers/ufs/core/ufshcd.c a45f937110fa6b drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5253 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5254 /** 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5255 * ufshcd_uic_cmd_compl - handle completion of uic command 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5256 * @hba: per adapter instance 53b3d9c3fdda94 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-08-31 5257 * @intr_status: interrupt status generated by the controller 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5258 * 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5259 * Returns 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5260 * IRQ_HANDLED - If interrupt is valid 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5261 * IRQ_NONE - If invalid interrupt 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5262 */ 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5263 static irqreturn_t ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status) 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5264 { 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5265 irqreturn_t retval = IRQ_NONE; 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5266 a45f937110fa6b drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5267 spin_lock(hba->host->host_lock); a45f937110fa6b drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5268 if (ufshcd_is_auto_hibern8_error(hba, intr_status)) a45f937110fa6b drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5269 hba->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status); a45f937110fa6b drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5270 53b3d9c3fdda94 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-08-31 @5271 if ((intr_status & UIC_COMMAND_COMPL) && hba->active_uic_cmd) { 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5272 hba->active_uic_cmd->argument2 |= 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5273 ufshcd_get_uic_cmd_result(hba); 12b4fdb4f6bccb drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-08-31 5274 hba->active_uic_cmd->argument3 = 12b4fdb4f6bccb drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-08-31 5275 ufshcd_get_dme_attr_val(hba); 0f52fcb99ea273 drivers/scsi/ufs/ufshcd.c Can Guo 2020-11-02 5276 if (!hba->uic_async_done) 0f52fcb99ea273 drivers/scsi/ufs/ufshcd.c Can Guo 2020-11-02 5277 hba->active_uic_cmd->cmd_active = 0; 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5278 complete(&hba->active_uic_cmd->done); 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5279 retval = IRQ_HANDLED; 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5280 } 53b3d9c3fdda94 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-08-31 5281 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5282 if ((intr_status & UFSHCD_UIC_PWR_MASK) && hba->uic_async_done) { 0f52fcb99ea273 drivers/scsi/ufs/ufshcd.c Can Guo 2020-11-02 @5283 hba->active_uic_cmd->cmd_active = 0; 57d104c153d3d6 drivers/scsi/ufs/ufshcd.c Subhash Jadavani 2014-09-25 5284 complete(hba->uic_async_done); 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5285 retval = IRQ_HANDLED; 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5286 } aa5c697988b4c7 drivers/scsi/ufs/ufshcd.c Stanley Chu 2020-06-15 5287 aa5c697988b4c7 drivers/scsi/ufs/ufshcd.c Stanley Chu 2020-06-15 5288 if (retval == IRQ_HANDLED) aa5c697988b4c7 drivers/scsi/ufs/ufshcd.c Stanley Chu 2020-06-15 5289 ufshcd_add_uic_command_trace(hba, hba->active_uic_cmd, 28fa68fc557a7e drivers/scsi/ufs/ufshcd.c Bean Huo 2021-01-05 5290 UFS_CMD_COMP); a45f937110fa6b drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5291 spin_unlock(hba->host->host_lock); 9333d77573485c drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5292 return retval; 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5293 } 6ccf44fe4cd7c4 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5294 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
