CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Jimmy Su <[email protected]> TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi Jimmy, I love your patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on v5.18-rc6 next-20220512] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Jimmy-Su/UPSTREAM-media-ov8856-skip-OTP-read-in-non-zero-ACPI-D-state/20220510-232606 base: git://linuxtv.org/media_tree.git master :::::: branch date: 3 days ago :::::: commit date: 3 days ago config: nios2-randconfig-m031-20220512 (https://download.01.org/0day-ci/archive/20220513/[email protected]/config) compiler: nios2-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/media/i2c/ov8856.c:1715 ov8856_identify_module() warn: maybe use && instead of & vim +1715 drivers/media/i2c/ov8856.c 879347f0c258cf Ben Kao 2019-01-15 1693 0e014f1a8d546f Bingbu Cao 2021-12-15 1694 static int ov8856_identify_module(struct ov8856 *ov8856) 0e014f1a8d546f Bingbu Cao 2021-12-15 1695 { 0e014f1a8d546f Bingbu Cao 2021-12-15 1696 struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd); 0e014f1a8d546f Bingbu Cao 2021-12-15 1697 int ret; 25bf233398211c Jimmy Su 2022-05-10 1698 u32 val, width; 0e014f1a8d546f Bingbu Cao 2021-12-15 1699 0e014f1a8d546f Bingbu Cao 2021-12-15 1700 if (ov8856->identified) 0e014f1a8d546f Bingbu Cao 2021-12-15 1701 return 0; 0e014f1a8d546f Bingbu Cao 2021-12-15 1702 0e014f1a8d546f Bingbu Cao 2021-12-15 1703 ret = ov8856_read_reg(ov8856, OV8856_REG_CHIP_ID, 0e014f1a8d546f Bingbu Cao 2021-12-15 1704 OV8856_REG_VALUE_24BIT, &val); 0e014f1a8d546f Bingbu Cao 2021-12-15 1705 if (ret) 0e014f1a8d546f Bingbu Cao 2021-12-15 1706 return ret; 0e014f1a8d546f Bingbu Cao 2021-12-15 1707 0e014f1a8d546f Bingbu Cao 2021-12-15 1708 if (val != OV8856_CHIP_ID) { 0e014f1a8d546f Bingbu Cao 2021-12-15 1709 dev_err(&client->dev, "chip id mismatch: %x!=%x", 0e014f1a8d546f Bingbu Cao 2021-12-15 1710 OV8856_CHIP_ID, val); 0e014f1a8d546f Bingbu Cao 2021-12-15 1711 return -ENXIO; 0e014f1a8d546f Bingbu Cao 2021-12-15 1712 } 0e014f1a8d546f Bingbu Cao 2021-12-15 1713 25bf233398211c Jimmy Su 2022-05-10 1714 width = ov8856->cur_mode->width; 25bf233398211c Jimmy Su 2022-05-10 @1715 if (ov8856->acpi_skip_otp & ((width == 3280) | (width == 1640))) 25bf233398211c Jimmy Su 2022-05-10 1716 goto otp_skip; 25bf233398211c Jimmy Su 2022-05-10 1717 0e014f1a8d546f Bingbu Cao 2021-12-15 1718 ret = ov8856_write_reg(ov8856, OV8856_REG_MODE_SELECT, 0e014f1a8d546f Bingbu Cao 2021-12-15 1719 OV8856_REG_VALUE_08BIT, OV8856_MODE_STREAMING); 0e014f1a8d546f Bingbu Cao 2021-12-15 1720 if (ret) 0e014f1a8d546f Bingbu Cao 2021-12-15 1721 return ret; 0e014f1a8d546f Bingbu Cao 2021-12-15 1722 0e014f1a8d546f Bingbu Cao 2021-12-15 1723 ret = ov8856_write_reg(ov8856, OV8856_OTP_MODE_CTRL, 0e014f1a8d546f Bingbu Cao 2021-12-15 1724 OV8856_REG_VALUE_08BIT, OV8856_OTP_MODE_AUTO); 0e014f1a8d546f Bingbu Cao 2021-12-15 1725 if (ret) { 0e014f1a8d546f Bingbu Cao 2021-12-15 1726 dev_err(&client->dev, "failed to set otp mode"); 0e014f1a8d546f Bingbu Cao 2021-12-15 1727 return ret; 0e014f1a8d546f Bingbu Cao 2021-12-15 1728 } 0e014f1a8d546f Bingbu Cao 2021-12-15 1729 0e014f1a8d546f Bingbu Cao 2021-12-15 1730 ret = ov8856_write_reg(ov8856, OV8856_OTP_LOAD_CTRL, 0e014f1a8d546f Bingbu Cao 2021-12-15 1731 OV8856_REG_VALUE_08BIT, 0e014f1a8d546f Bingbu Cao 2021-12-15 1732 OV8856_OTP_LOAD_CTRL_ENABLE); 0e014f1a8d546f Bingbu Cao 2021-12-15 1733 if (ret) { 0e014f1a8d546f Bingbu Cao 2021-12-15 1734 dev_err(&client->dev, "failed to enable load control"); 0e014f1a8d546f Bingbu Cao 2021-12-15 1735 return ret; 0e014f1a8d546f Bingbu Cao 2021-12-15 1736 } 0e014f1a8d546f Bingbu Cao 2021-12-15 1737 0e014f1a8d546f Bingbu Cao 2021-12-15 1738 ret = ov8856_read_reg(ov8856, OV8856_MODULE_REVISION, 0e014f1a8d546f Bingbu Cao 2021-12-15 1739 OV8856_REG_VALUE_08BIT, &val); 0e014f1a8d546f Bingbu Cao 2021-12-15 1740 if (ret) { 0e014f1a8d546f Bingbu Cao 2021-12-15 1741 dev_err(&client->dev, "failed to read module revision"); 0e014f1a8d546f Bingbu Cao 2021-12-15 1742 return ret; 0e014f1a8d546f Bingbu Cao 2021-12-15 1743 } 0e014f1a8d546f Bingbu Cao 2021-12-15 1744 0e014f1a8d546f Bingbu Cao 2021-12-15 1745 dev_info(&client->dev, "OV8856 revision %x (%s) at address 0x%02x\n", 0e014f1a8d546f Bingbu Cao 2021-12-15 1746 val, 0e014f1a8d546f Bingbu Cao 2021-12-15 1747 val == OV8856_2A_MODULE ? "2A" : 0e014f1a8d546f Bingbu Cao 2021-12-15 1748 val == OV8856_1B_MODULE ? "1B" : "unknown revision", 0e014f1a8d546f Bingbu Cao 2021-12-15 1749 client->addr); 0e014f1a8d546f Bingbu Cao 2021-12-15 1750 0e014f1a8d546f Bingbu Cao 2021-12-15 1751 ret = ov8856_write_reg(ov8856, OV8856_REG_MODE_SELECT, 0e014f1a8d546f Bingbu Cao 2021-12-15 1752 OV8856_REG_VALUE_08BIT, OV8856_MODE_STANDBY); 0e014f1a8d546f Bingbu Cao 2021-12-15 1753 if (ret) { 0e014f1a8d546f Bingbu Cao 2021-12-15 1754 dev_err(&client->dev, "failed to exit streaming mode"); 0e014f1a8d546f Bingbu Cao 2021-12-15 1755 return ret; 0e014f1a8d546f Bingbu Cao 2021-12-15 1756 } 0e014f1a8d546f Bingbu Cao 2021-12-15 1757 0e014f1a8d546f Bingbu Cao 2021-12-15 1758 ov8856->identified = true; 0e014f1a8d546f Bingbu Cao 2021-12-15 1759 25bf233398211c Jimmy Su 2022-05-10 1760 return 0; 25bf233398211c Jimmy Su 2022-05-10 1761 25bf233398211c Jimmy Su 2022-05-10 1762 otp_skip: 25bf233398211c Jimmy Su 2022-05-10 1763 ov8856->identified = true; 25bf233398211c Jimmy Su 2022-05-10 1764 0e014f1a8d546f Bingbu Cao 2021-12-15 1765 return 0; 0e014f1a8d546f Bingbu Cao 2021-12-15 1766 } 0e014f1a8d546f Bingbu Cao 2021-12-15 1767 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
