CC: [email protected] BCC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Ville Syrjala <[email protected]>
Hi Ville, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on drm/drm-next next-20220516] [cannot apply to drm-intel/for-linux-next v5.18-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-i915-bios-PNPID-panel_type-matching/20220510-184449 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip :::::: branch date: 6 days ago :::::: commit date: 6 days ago config: x86_64-randconfig-m001-20220516 (https://download.01.org/0day-ci/archive/20220517/[email protected]/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/gpu/drm/i915/display/intel_bios.c:662 pnpid_get_panel_type() error: memcmp() 'edid_id' too small (2 vs 10) Old smatch warnings: drivers/gpu/drm/i915/display/intel_bios.c:1457 parse_psr() warn: impossible condition '(psr_table->idle_frames < 0) => (0-15 < 0)' drivers/gpu/drm/i915/display/intel_bios.c:1458 parse_psr() warn: impossible condition '(psr_table->idle_frames > 15) => (0-15 > 15)' vim +/edid_id +662 drivers/gpu/drm/i915/display/intel_bios.c 719f4c51e2c9198 Ville Syrjälä 2022-05-04 630 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 631 static int pnpid_get_panel_type(struct drm_i915_private *i915, e7fd01f6ea7075a Ville Syrjälä 2022-05-10 632 const struct edid *edid) e7fd01f6ea7075a Ville Syrjälä 2022-05-10 633 { e7fd01f6ea7075a Ville Syrjälä 2022-05-10 634 const struct bdb_lvds_lfp_data *data; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 635 const struct bdb_lvds_lfp_data_ptrs *ptrs; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 636 const struct lvds_pnp_id *edid_id; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 637 struct lvds_pnp_id edid_id_nodate; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 638 int i, best = -1; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 639 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 640 if (!edid) e7fd01f6ea7075a Ville Syrjälä 2022-05-10 641 return -1; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 642 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 643 edid_id = (const void *)&edid->mfg_id[0]; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 644 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 645 edid_id_nodate = *edid_id; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 646 edid_id_nodate.mfg_week = 0; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 647 edid_id_nodate.mfg_year = 0; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 648 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 649 ptrs = find_section(i915, BDB_LVDS_LFP_DATA_PTRS); e7fd01f6ea7075a Ville Syrjälä 2022-05-10 650 if (!ptrs) e7fd01f6ea7075a Ville Syrjälä 2022-05-10 651 return -1; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 652 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 653 data = find_section(i915, BDB_LVDS_LFP_DATA); e7fd01f6ea7075a Ville Syrjälä 2022-05-10 654 if (!data) e7fd01f6ea7075a Ville Syrjälä 2022-05-10 655 return -1; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 656 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 657 for (i = 0; i < 16; i++) { e7fd01f6ea7075a Ville Syrjälä 2022-05-10 658 const struct lvds_pnp_id *vbt_id = e7fd01f6ea7075a Ville Syrjälä 2022-05-10 659 get_lvds_pnp_id(data, ptrs, i); e7fd01f6ea7075a Ville Syrjälä 2022-05-10 660 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 661 /* full match? */ e7fd01f6ea7075a Ville Syrjälä 2022-05-10 @662 if (!memcmp(vbt_id, edid_id, sizeof(*vbt_id))) e7fd01f6ea7075a Ville Syrjälä 2022-05-10 663 return i; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 664 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 665 /* e7fd01f6ea7075a Ville Syrjälä 2022-05-10 666 * Accept a match w/o date if no full match is found, e7fd01f6ea7075a Ville Syrjälä 2022-05-10 667 * and the VBT entry does not specify a date. e7fd01f6ea7075a Ville Syrjälä 2022-05-10 668 */ e7fd01f6ea7075a Ville Syrjälä 2022-05-10 669 if (best < 0 && e7fd01f6ea7075a Ville Syrjälä 2022-05-10 670 !memcmp(vbt_id, &edid_id_nodate, sizeof(*vbt_id))) e7fd01f6ea7075a Ville Syrjälä 2022-05-10 671 best = i; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 672 } e7fd01f6ea7075a Ville Syrjälä 2022-05-10 673 e7fd01f6ea7075a Ville Syrjälä 2022-05-10 674 return best; e7fd01f6ea7075a Ville Syrjälä 2022-05-10 675 } e7fd01f6ea7075a Ville Syrjälä 2022-05-10 676 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
