CC: [email protected] BCC: [email protected] TO: [email protected] TO: Guenter Roeck <[email protected]>
From: kernel test robot <[email protected]> drivers/hid/hid-nintendo.c:318:11-15: Move constant to right. drivers/hid/hid-nintendo.c:319:11-15: Move constant to right. drivers/hid/hid-nintendo.c:320:11-15: Move constant to right. Move constants to the right of binary operators. Semantic patch information: Depends on personal taste in some cases. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Daniel J. Ogorchock <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4 head: 7dda0570f391f24b3a62963b89d8e252ab55bf95 commit: ec6866324231b225d800ccda7868d565c65c60af [6/10] UPSTREAM: HID: nintendo: add nintendo switch controller driver :::::: branch date: 25 hours ago :::::: commit date: 3 weeks ago Please take the patch only if it's a positive warning. Thanks! drivers/hid/hid-nintendo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/hid/hid-nintendo.c +++ b/drivers/hid/hid-nintendo.c @@ -315,9 +315,9 @@ static int joycon_request_calibration(st req->subcmd_id = JC_SUBCMD_SPI_FLASH_READ; data = req->data; data[0] = 0xFF & JC_CAL_DATA_START; - data[1] = 0xFF & (JC_CAL_DATA_START >> 8); - data[2] = 0xFF & (JC_CAL_DATA_START >> 16); - data[3] = 0xFF & (JC_CAL_DATA_START >> 24); + data[1] = (JC_CAL_DATA_START >> 8) & 0xFF; + data[2] = (JC_CAL_DATA_START >> 16) & 0xFF; + data[3] = (JC_CAL_DATA_START >> 24) & 0xFF; data[4] = JC_CAL_DATA_SIZE; hid_dbg(ctlr->hdev, "requesting cal data\n"); _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
