CC: [email protected]
BCC: [email protected]
CC: Linux Memory Management List <[email protected]>
TO: Jeff LaBundy <[email protected]>
CC: Dmitry Torokhov <[email protected]>
CC: [email protected]
CC: [email protected]

From: kernel test robot <[email protected]>

drivers/input/misc/iqs7222.c:2418:9-34: WARNING: Threaded IRQ with no primary 
handler requested without IRQF_ONESHOT (unless it is nested IRQ)

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

CC: Jeff LaBundy <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
master
head:   d3fde8ff50ab265749704bd7fbcf70d35235421f
commit: e505edaedcb9e7d16eefddc62d2189afaea0febc [2115/14198] Input: add 
support for Azoteq IQS7222A/B/C
:::::: branch date: 25 hours ago
:::::: commit date: 7 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/input/misc/iqs7222.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/input/misc/iqs7222.c
+++ b/drivers/input/misc/iqs7222.c
@@ -2416,7 +2416,8 @@ static int iqs7222_probe(struct i2c_clie
        irq_flags |= IRQF_ONESHOT;
 
        error = devm_request_threaded_irq(&client->dev, irq, NULL, iqs7222_irq,
-                                         irq_flags, client->name, iqs7222);
+                                         irq_flags | IRQF_ONESHOT,
+                                         client->name, iqs7222);
        if (error)
                dev_err(&client->dev, "Failed to request IRQ: %d\n", error);
 
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to