CC: [email protected] BCC: [email protected] CC: [email protected] TO: Namjae Jeon <[email protected]> CC: Christoph Hellwig <[email protected]> CC: Steve French <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e1cbc3b96a9974746b2a80c3a6c8a0f7eff7b1b5 commit: 1a93084b9a89818aec0ac7b59a5a51f2112bf203 ksmbd: move fs/cifsd to fs/ksmbd date: 11 months ago :::::: branch date: 5 hours ago :::::: commit date: 11 months ago config: arm64-randconfig-m031-20220531 (https://download.01.org/0day-ci/archive/20220601/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: fs/ksmbd/transport_ipc.c:235 ipc_msg_alloc() warn: Please consider using kvzalloc instead of kvmalloc fs/ksmbd/transport_ipc.c:274 handle_response() warn: Please consider using kvzalloc instead of kvmalloc fs/ksmbd/smb2pdu.c:556 smb2_allocate_rsp_buf() warn: Please consider using kvzalloc instead of kvmalloc fs/ksmbd/smb2pdu.c:5817 smb2_read_pipe() warn: Please consider using kvzalloc instead of kvmalloc fs/ksmbd/smb2pdu.c:5931 smb2_read() warn: Please consider using kvzalloc instead of kvmalloc fs/ksmbd/smb2pdu.c:6104 smb2_write_rdma_channel() warn: Please consider using kvzalloc instead of kvmalloc fs/ksmbd/vfs.c:426 ksmbd_vfs_stream_write() warn: Please consider using kvzalloc instead of kvmalloc fs/ksmbd/vfs.c:908 ksmbd_vfs_listxattr() warn: Please consider using kvzalloc instead of kvmalloc Old smatch warnings: fs/ksmbd/smb2pdu.c:1717 smb2_sess_setup() error: uninitialized symbol 'sess'. fs/ksmbd/smb2pdu.c:3102 smb2_open() warn: Function too hairy. No more merges. fs/ksmbd/smb2pdu.c:6628 smb2_lock() warn: inconsistent indenting fs/ksmbd/smb2pdu.c:6636 smb2_lock() warn: inconsistent indenting fs/ksmbd/vfs.c:1700 ksmbd_vfs_xattr_stream_name() warn: inconsistent indenting vim +235 fs/ksmbd/transport_ipc.c 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 229 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 230 static struct ksmbd_ipc_msg *ipc_msg_alloc(size_t sz) 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 231 { 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 232 struct ksmbd_ipc_msg *msg; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 233 size_t msg_sz = sz + sizeof(struct ksmbd_ipc_msg); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 234 79f6b11a104f3a fs/cifsd/transport_ipc.c Namjae Jeon 2021-04-02 @235 msg = kvmalloc(msg_sz, GFP_KERNEL | __GFP_ZERO); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 236 if (msg) 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 237 msg->sz = sz; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 238 return msg; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 239 } 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 240 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 241 static void ipc_msg_free(struct ksmbd_ipc_msg *msg) 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 242 { 79f6b11a104f3a fs/cifsd/transport_ipc.c Namjae Jeon 2021-04-02 243 kvfree(msg); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 244 } 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 245 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 246 static void ipc_msg_handle_free(int handle) 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 247 { 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 248 if (handle >= 0) d40012a83f87f4 fs/cifsd/transport_ipc.c Namjae Jeon 2021-04-13 249 ksmbd_release_id(&ipc_ida, handle); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 250 } 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 251 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 252 static int handle_response(int type, void *payload, size_t sz) 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 253 { 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 254 int handle = KSMBD_IPC_MSG_HANDLE(payload); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 255 struct ipc_msg_table_entry *entry; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 256 int ret = 0; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 257 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 258 ipc_update_last_active(); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 259 down_read(&ipc_msg_table_lock); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 260 hash_for_each_possible(ipc_msg_table, entry, ipc_table_hlist, handle) { 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 261 if (handle != entry->handle) 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 262 continue; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 263 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 264 entry->response = NULL; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 265 /* 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 266 * Response message type value should be equal to 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 267 * request message type + 1. 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 268 */ 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 269 if (entry->type + 1 != type) { bde1694aecdb53 fs/cifsd/transport_ipc.c Namjae Jeon 2021-06-28 270 pr_err("Waiting for IPC type %d, got %d. Ignore.\n", 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 271 entry->type + 1, type); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 272 } 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 273 79f6b11a104f3a fs/cifsd/transport_ipc.c Namjae Jeon 2021-04-02 @274 entry->response = kvmalloc(sz, GFP_KERNEL | __GFP_ZERO); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 275 if (!entry->response) { 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 276 ret = -ENOMEM; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 277 break; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 278 } 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 279 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 280 memcpy(entry->response, payload, sz); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 281 wake_up_interruptible(&entry->wait); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 282 ret = 0; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 283 break; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 284 } 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 285 up_read(&ipc_msg_table_lock); 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 286 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 287 return ret; 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 288 } 0626e6641f6b46 fs/cifsd/transport_ipc.c Namjae Jeon 2021-03-16 289 :::::: The code at line 235 was first introduced by commit :::::: 79f6b11a104f3a32f4f4a6f7808a02c301c19710 cifsd: remove wrappers of kvmalloc/kvfree :::::: TO: Namjae Jeon <[email protected]> :::::: CC: Steve French <[email protected]> -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
