:::::: :::::: Manual check reason: "low confidence static check warning: drivers/net/ethernet/intel/ice/ice_ptp.c:109:17: warning: Value stored to 'dev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]" ::::::
CC: [email protected] CC: [email protected] BCC: [email protected] CC: [email protected] TO: Jacob Keller <[email protected]> CC: Tony Nguyen <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d1dc87763f406d4e67caf16dbe438a5647692395 commit: 67569a7f940130fcfe9041e07a614a5263a9944d ice: report the PTP clock index in ethtool .get_ts_info date: 12 months ago :::::: branch date: 6 hours ago :::::: commit date: 12 months ago config: s390-randconfig-c005-20220524 (https://download.01.org/0day-ci/archive/20220602/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 134d7f9a4b97e9035150d970bd9e376043c4577e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install s390 cross compiling tool for clang build # apt-get install binutils-s390x-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=67569a7f940130fcfe9041e07a614a5263a9944d git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 67569a7f940130fcfe9041e07a614a5263a9944d # save the config file COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 clang-analyzer If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> clang-analyzer warnings: (new ones prefixed by >>) ^ include/linux/spinlock.h:250:2: note: expanded from macro 'raw_spin_lock_irqsave' do { \ ^ drivers/ata/libata-eh.c:530:2: note: Loop condition is false. Exiting loop spin_lock_irqsave(host->host_lock, flags); ^ include/linux/spinlock.h:382:43: note: expanded from macro 'spin_lock_irqsave' #define spin_lock_irqsave(lock, flags) \ ^ drivers/ata/libata-eh.c:538:2: note: Calling 'ata_scsi_port_error_handler' ata_scsi_port_error_handler(host, ap); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/ata/libata-eh.c:654:6: note: Assuming field 'error_handler' is non-null if (ap->ops->error_handler) { ^~~~~~~~~~~~~~~~~~~~~~ drivers/ata/libata-eh.c:654:2: note: Taking true branch if (ap->ops->error_handler) { ^ drivers/ata/libata-eh.c:658:3: note: Calling 'ata_eh_acquire' ata_eh_acquire(ap); ^~~~~~~~~~~~~~~~~~ drivers/ata/libata-eh.c:464:2: note: Assuming field 'eh_owner' is null WARN_ON_ONCE(ap->host->eh_owner); ^ include/asm-generic/bug.h:102:23: note: expanded from macro 'WARN_ON_ONCE' int __ret_warn_on = !!(condition); \ ^~~~~~~~~~~~ drivers/ata/libata-eh.c:464:2: note: Taking false branch WARN_ON_ONCE(ap->host->eh_owner); ^ include/asm-generic/bug.h:103:2: note: expanded from macro 'WARN_ON_ONCE' if (unlikely(__ret_warn_on)) \ ^ drivers/ata/libata-eh.c:465:23: note: Dereference of null pointer ap->host->eh_owner = current; ^ arch/s390/include/asm/current.h:17:45: note: expanded from macro 'current' #define current ((struct task_struct *const)S390_lowcore.current_task) ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/s390/include/asm/lowcore.h:192:22: note: expanded from macro 'S390_lowcore' #define S390_lowcore (*((struct lowcore *) 0)) ^ drivers/ata/libata-eh.c:480:37: warning: Dereference of null pointer [clang-analyzer-core.NullDereference] WARN_ON_ONCE(ap->host->eh_owner != current); ^ arch/s390/include/asm/current.h:17:45: note: expanded from macro 'current' #define current ((struct task_struct *const)S390_lowcore.current_task) ^ arch/s390/include/asm/lowcore.h:192:22: note: expanded from macro 'S390_lowcore' #define S390_lowcore (*((struct lowcore *) 0)) ^ include/asm-generic/bug.h:102:25: note: expanded from macro 'WARN_ON_ONCE' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ drivers/ata/libata-eh.c:480:37: note: Dereference of null pointer WARN_ON_ONCE(ap->host->eh_owner != current); ^ arch/s390/include/asm/current.h:17:45: note: expanded from macro 'current' #define current ((struct task_struct *const)S390_lowcore.current_task) ^ arch/s390/include/asm/lowcore.h:192:22: note: expanded from macro 'S390_lowcore' #define S390_lowcore (*((struct lowcore *) 0)) ^ include/asm-generic/bug.h:102:25: note: expanded from macro 'WARN_ON_ONCE' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ drivers/ata/libata-eh.c:777:2: warning: Dereference of null pointer [clang-analyzer-core.NullDereference] DEFINE_WAIT(wait); ^ include/linux/wait.h:1153:27: note: expanded from macro 'DEFINE_WAIT' #define DEFINE_WAIT(name) DEFINE_WAIT_FUNC(name, autoremove_wake_function) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/wait.h:1148:14: note: expanded from macro 'DEFINE_WAIT_FUNC' .private = current, \ ^~~~~~~ arch/s390/include/asm/current.h:17:45: note: expanded from macro 'current' #define current ((struct task_struct *const)S390_lowcore.current_task) ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/s390/include/asm/lowcore.h:192:22: note: expanded from macro 'S390_lowcore' #define S390_lowcore (*((struct lowcore *) 0)) ^ drivers/ata/libata-eh.c:777:2: note: Dereference of null pointer DEFINE_WAIT(wait); ^ include/linux/wait.h:1153:27: note: expanded from macro 'DEFINE_WAIT' #define DEFINE_WAIT(name) DEFINE_WAIT_FUNC(name, autoremove_wake_function) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/wait.h:1148:14: note: expanded from macro 'DEFINE_WAIT_FUNC' .private = current, \ ^~~~~~~ arch/s390/include/asm/current.h:17:45: note: expanded from macro 'current' #define current ((struct task_struct *const)S390_lowcore.current_task) ^~~~~~~~~~~~~~~~~~~~~~~~~ arch/s390/include/asm/lowcore.h:192:22: note: expanded from macro 'S390_lowcore' #define S390_lowcore (*((struct lowcore *) 0)) ^ Suppressed 21 warnings (9 in non-user code, 12 with check filters). Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. 29 warnings generated. >> drivers/net/ethernet/intel/ice/ice_ptp.c:109:17: warning: Value stored to >> 'dev' during its initialization is never read >> [clang-analyzer-deadcode.DeadStores] struct device *dev = ice_pf_to_dev(pf); ^~~ drivers/net/ethernet/intel/ice/ice_ptp.c:109:17: note: Value stored to 'dev' during its initialization is never read struct device *dev = ice_pf_to_dev(pf); ^~~ include/linux/time64.h:67:50: warning: The left operand of '+' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] set_normalized_timespec64(&ts_delta, lhs.tv_sec + rhs.tv_sec, ^ drivers/net/ethernet/intel/ice/ice_ptp.c:358:22: note: Left side of '&&' is false struct ice_pf *pf = ptp_info_to_pf(info); ^ drivers/net/ethernet/intel/ice/ice_ptp.h:24:15: note: expanded from macro 'ptp_info_to_pf' container_of(__ptp_info_to_ptp((i)), struct ice_pf, ptp) ^ drivers/net/ethernet/intel/ice/ice_ptp.h:22:2: note: expanded from macro '__ptp_info_to_ptp' container_of((i), struct ice_ptp, info) ^ include/linux/kernel.h:716:61: note: expanded from macro 'container_of' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^ drivers/net/ethernet/intel/ice/ice_ptp.c:358:22: note: Taking false branch struct ice_pf *pf = ptp_info_to_pf(info); ^ drivers/net/ethernet/intel/ice/ice_ptp.h:24:15: note: expanded from macro 'ptp_info_to_pf' container_of(__ptp_info_to_ptp((i)), struct ice_pf, ptp) ^ drivers/net/ethernet/intel/ice/ice_ptp.h:22:2: note: expanded from macro '__ptp_info_to_ptp' container_of((i), struct ice_ptp, info) ^ include/linux/kernel.h:716:2: note: expanded from macro 'container_of' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^ note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all) include/linux/compiler_types.h:328:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ include/linux/compiler_types.h:316:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler_types.h:308:3: note: expanded from macro '__compiletime_assert' if (!(condition)) \ ^ drivers/net/ethernet/intel/ice/ice_ptp.c:358:22: note: Loop condition is false. Exiting loop struct ice_pf *pf = ptp_info_to_pf(info); ^ drivers/net/ethernet/intel/ice/ice_ptp.h:24:15: note: expanded from macro 'ptp_info_to_pf' container_of(__ptp_info_to_ptp((i)), struct ice_pf, ptp) ^ drivers/net/ethernet/intel/ice/ice_ptp.h:22:2: note: expanded from macro '__ptp_info_to_ptp' container_of((i), struct ice_ptp, info) ^ include/linux/kernel.h:716:2: note: expanded from macro 'container_of' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^ note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all) include/linux/compiler_types.h:328:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ include/linux/compiler_types.h:316:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler_types.h:306:2: note: expanded from macro '__compiletime_assert' do { \ ^ drivers/net/ethernet/intel/ice/ice_ptp.c:358:22: note: Left side of '&&' is false struct ice_pf *pf = ptp_info_to_pf(info); ^ drivers/net/ethernet/intel/ice/ice_ptp.h:24:2: note: expanded from macro 'ptp_info_to_pf' container_of(__ptp_info_to_ptp((i)), struct ice_pf, ptp) ^ include/linux/kernel.h:716:61: note: expanded from macro 'container_of' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^ drivers/net/ethernet/intel/ice/ice_ptp.c:358:22: note: Taking false branch struct ice_pf *pf = ptp_info_to_pf(info); ^ drivers/net/ethernet/intel/ice/ice_ptp.h:24:2: note: expanded from macro 'ptp_info_to_pf' container_of(__ptp_info_to_ptp((i)), struct ice_pf, ptp) ^ include/linux/kernel.h:716:2: note: expanded from macro 'container_of' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^ include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^ include/linux/compiler_types.h:328:2: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^ include/linux/compiler_types.h:316:2: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ^ include/linux/compiler_types.h:308:3: note: expanded from macro '__compiletime_assert' if (!(condition)) \ ^ drivers/net/ethernet/intel/ice/ice_ptp.c:358:22: note: Loop condition is false. Exiting loop struct ice_pf *pf = ptp_info_to_pf(info); ^ drivers/net/ethernet/intel/ice/ice_ptp.h:24:2: note: expanded from macro 'ptp_info_to_pf' container_of(__ptp_info_to_ptp((i)), struct ice_pf, ptp) ^ vim +/dev +109 drivers/net/ethernet/intel/ice/ice_ptp.c 67569a7f940130 Jacob Keller 2021-06-09 98 67569a7f940130 Jacob Keller 2021-06-09 99 /** 67569a7f940130 Jacob Keller 2021-06-09 100 * ice_clear_ptp_clock_index - Clear the PTP clock index 67569a7f940130 Jacob Keller 2021-06-09 101 * @pf: the PF pointer 67569a7f940130 Jacob Keller 2021-06-09 102 * 67569a7f940130 Jacob Keller 2021-06-09 103 * Clear the PTP clock index for this device. Must be called when 67569a7f940130 Jacob Keller 2021-06-09 104 * unregistering the PTP clock, in order to ensure other PFs stop reporting 67569a7f940130 Jacob Keller 2021-06-09 105 * a clock object that no longer exists. 67569a7f940130 Jacob Keller 2021-06-09 106 */ 67569a7f940130 Jacob Keller 2021-06-09 107 static void ice_clear_ptp_clock_index(struct ice_pf *pf) 67569a7f940130 Jacob Keller 2021-06-09 108 { 67569a7f940130 Jacob Keller 2021-06-09 @109 struct device *dev = ice_pf_to_dev(pf); 67569a7f940130 Jacob Keller 2021-06-09 110 enum ice_aqc_driver_params param_idx; 67569a7f940130 Jacob Keller 2021-06-09 111 struct ice_hw *hw = &pf->hw; 67569a7f940130 Jacob Keller 2021-06-09 112 u8 tmr_idx; 67569a7f940130 Jacob Keller 2021-06-09 113 int err; 67569a7f940130 Jacob Keller 2021-06-09 114 67569a7f940130 Jacob Keller 2021-06-09 115 /* Do not clear the index if we don't own the timer */ 67569a7f940130 Jacob Keller 2021-06-09 116 if (!hw->func_caps.ts_func_info.src_tmr_owned) 67569a7f940130 Jacob Keller 2021-06-09 117 return; 67569a7f940130 Jacob Keller 2021-06-09 118 67569a7f940130 Jacob Keller 2021-06-09 119 tmr_idx = hw->func_caps.ts_func_info.tmr_index_assoc; 67569a7f940130 Jacob Keller 2021-06-09 120 if (!tmr_idx) 67569a7f940130 Jacob Keller 2021-06-09 121 param_idx = ICE_AQC_DRIVER_PARAM_CLK_IDX_TMR0; 67569a7f940130 Jacob Keller 2021-06-09 122 else 67569a7f940130 Jacob Keller 2021-06-09 123 param_idx = ICE_AQC_DRIVER_PARAM_CLK_IDX_TMR1; 67569a7f940130 Jacob Keller 2021-06-09 124 67569a7f940130 Jacob Keller 2021-06-09 125 err = ice_aq_set_driver_param(hw, param_idx, 0, NULL); 67569a7f940130 Jacob Keller 2021-06-09 126 if (err) { 67569a7f940130 Jacob Keller 2021-06-09 127 dev_dbg(dev, "Failed to clear PTP clock index parameter, err %d aq_err %s\n", 67569a7f940130 Jacob Keller 2021-06-09 128 err, ice_aq_str(hw->adminq.sq_last_status)); 67569a7f940130 Jacob Keller 2021-06-09 129 } 67569a7f940130 Jacob Keller 2021-06-09 130 } 67569a7f940130 Jacob Keller 2021-06-09 131 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
