CC: [email protected] BCC: [email protected] CC: [email protected] TO: Seevalamuthu Mariappan <[email protected]> CC: Kalle Valo <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f2906aa863381afb0015a9eb7fefad885d4e5a56 commit: f295ad912910e08d9b887a0c952f82d9612459d4 ath11k: Add debugfs interface to configure firmware debug log level date: 4 months ago :::::: branch date: 3 hours ago :::::: commit date: 4 months ago config: microblaze-randconfig-m031-20220605 (https://download.01.org/0day-ci/archive/20220606/[email protected]/config) compiler: microblaze-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/net/wireless/ath/ath11k/debugfs.c:907 ath11k_write_fw_dbglog() warn: potential spectre issue 'ar->debug.module_id_bitmap' [w] (local cap) vim +907 drivers/net/wireless/ath/ath11k/debugfs.c da3a9d3c15769b Kalle Valo 2020-09-16 878 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 879 static ssize_t ath11k_write_fw_dbglog(struct file *file, f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 880 const char __user *user_buf, f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 881 size_t count, loff_t *ppos) f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 882 { f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 883 struct ath11k *ar = file->private_data; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 884 char buf[128] = {0}; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 885 struct ath11k_fw_dbglog dbglog; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 886 unsigned int param, mod_id_index, is_end; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 887 u64 value; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 888 int ret, num; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 889 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 890 ret = simple_write_to_buffer(buf, sizeof(buf) - 1, ppos, f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 891 user_buf, count); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 892 if (ret <= 0) f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 893 return ret; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 894 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 895 num = sscanf(buf, "%u %llx %u %u", ¶m, &value, &mod_id_index, &is_end); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 896 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 897 if (num < 2) f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 898 return -EINVAL; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 899 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 900 mutex_lock(&ar->conf_mutex); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 901 if (param == WMI_DEBUG_LOG_PARAM_MOD_ENABLE_BITMAP || f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 902 param == WMI_DEBUG_LOG_PARAM_WOW_MOD_ENABLE_BITMAP) { f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 903 if (num != 4 || mod_id_index > (MAX_MODULE_ID_BITMAP_WORDS - 1)) { f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 904 ret = -EINVAL; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 905 goto out; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 906 } f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 @907 ar->debug.module_id_bitmap[mod_id_index] = upper_32_bits(value); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 908 if (!is_end) { f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 909 ret = count; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 910 goto out; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 911 } f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 912 } else { f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 913 if (num != 2) { f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 914 ret = -EINVAL; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 915 goto out; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 916 } f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 917 } f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 918 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 919 dbglog.param = param; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 920 dbglog.value = lower_32_bits(value); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 921 ret = ath11k_wmi_fw_dbglog_cfg(ar, ar->debug.module_id_bitmap, &dbglog); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 922 if (ret) { f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 923 ath11k_warn(ar->ab, "fw dbglog config failed from debugfs: %d\n", f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 924 ret); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 925 goto out; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 926 } f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 927 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 928 ret = count; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 929 f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 930 out: f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 931 mutex_unlock(&ar->conf_mutex); f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 932 return ret; f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 933 } f295ad912910e0 Seevalamuthu Mariappan 2022-01-31 934 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
