:::::: :::::: Manual check reason: "low confidence static check warning: drivers/bus/mhi/ep/main.c:124:24: warning: Uninitialized variable: itr->state [uninitvar]" ::::::
CC: [email protected] BCC: [email protected] CC: [email protected] TO: Manivannan Sadhasivam <[email protected]> CC: Alex Elder <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f2906aa863381afb0015a9eb7fefad885d4e5a56 commit: 484e04faa8a0487843808a08ff8b11e0684972f5 bus: mhi: ep: Add support for managing MHI state machine date: 9 weeks ago :::::: branch date: 8 hours ago :::::: commit date: 9 weeks ago compiler: riscv64-linux-gcc (GCC) 11.3.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout 484e04faa8a0487843808a08ff8b11e0684972f5 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/bus/mhi/ep/main.c:124:24: warning: Uninitialized variable: >> itr->state [uninitvar] mhi_state_str(itr->state)); ^ vim +124 drivers/bus/mhi/ep/main.c 6f7cb6e7883962 Manivannan Sadhasivam 2021-11-29 107 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 108 static void mhi_ep_state_worker(struct work_struct *work) 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 109 { 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 110 struct mhi_ep_cntrl *mhi_cntrl = container_of(work, struct mhi_ep_cntrl, state_work); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 111 struct device *dev = &mhi_cntrl->mhi_dev->dev; 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 112 struct mhi_ep_state_transition *itr, *tmp; 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 113 unsigned long flags; 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 114 LIST_HEAD(head); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 115 int ret; 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 116 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 117 spin_lock_irqsave(&mhi_cntrl->list_lock, flags); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 118 list_splice_tail_init(&mhi_cntrl->st_transition_list, &head); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 119 spin_unlock_irqrestore(&mhi_cntrl->list_lock, flags); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 120 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 121 list_for_each_entry_safe(itr, tmp, &head, node) { 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 122 list_del(&itr->node); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 123 dev_dbg(dev, "Handling MHI state transition to %s\n", 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 @124 mhi_state_str(itr->state)); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 125 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 126 switch (itr->state) { 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 127 case MHI_STATE_M0: 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 128 ret = mhi_ep_set_m0_state(mhi_cntrl); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 129 if (ret) 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 130 dev_err(dev, "Failed to transition to M0 state\n"); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 131 break; 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 132 case MHI_STATE_M3: 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 133 ret = mhi_ep_set_m3_state(mhi_cntrl); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 134 if (ret) 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 135 dev_err(dev, "Failed to transition to M3 state\n"); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 136 break; 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 137 default: 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 138 dev_err(dev, "Invalid MHI state transition: %d\n", itr->state); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 139 break; 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 140 } 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 141 kfree(itr); 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 142 } 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 143 } 484e04faa8a048 Manivannan Sadhasivam 2021-11-29 144 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
