CC: [email protected]
BCC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Casey Schaufler <[email protected]>
TO: [email protected]
TO: [email protected]
TO: [email protected]
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Hi Casey,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pcmoore-audit/next]
[also build test WARNING on pcmoore-selinux/next linus/master v5.19-rc2 
next-20220615]
[cannot apply to jmorris-security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220610-080129
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: x86_64-randconfig-m001-20220613 
(https://download.01.org/0day-ci/archive/20220615/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
include/linux/security.h:218 lsmblob_value() warn: we never enter this loop

Old smatch warnings:
include/linux/security.h:170 lsmblob_init() warn: we never enter this loop

vim +218 include/linux/security.h

767517968014af Casey Schaufler 2022-06-09  203  
86979553fd37a9 Casey Schaufler 2022-06-09  204  /**
86979553fd37a9 Casey Schaufler 2022-06-09  205   * lsmblob_value - find the 
first non-zero value in an lsmblob structure.
86979553fd37a9 Casey Schaufler 2022-06-09  206   * @blob: Pointer to the data
86979553fd37a9 Casey Schaufler 2022-06-09  207   *
86979553fd37a9 Casey Schaufler 2022-06-09  208   * This needs to be used with 
extreme caution, as the cases where
86979553fd37a9 Casey Schaufler 2022-06-09  209   * it is appropriate are rare.
86979553fd37a9 Casey Schaufler 2022-06-09  210   *
86979553fd37a9 Casey Schaufler 2022-06-09  211   * Return the first secid value 
set in the lsmblob.
86979553fd37a9 Casey Schaufler 2022-06-09  212   * There should only be one.
86979553fd37a9 Casey Schaufler 2022-06-09  213   */
86979553fd37a9 Casey Schaufler 2022-06-09  214  static inline u32 
lsmblob_value(const struct lsmblob *blob)
86979553fd37a9 Casey Schaufler 2022-06-09  215  {
86979553fd37a9 Casey Schaufler 2022-06-09  216          int i;
86979553fd37a9 Casey Schaufler 2022-06-09  217  
86979553fd37a9 Casey Schaufler 2022-06-09 @218          for (i = 0; i < 
LSMBLOB_ENTRIES; i++)
86979553fd37a9 Casey Schaufler 2022-06-09  219                  if 
(blob->secid[i])
86979553fd37a9 Casey Schaufler 2022-06-09  220                          return 
blob->secid[i];
86979553fd37a9 Casey Schaufler 2022-06-09  221  
86979553fd37a9 Casey Schaufler 2022-06-09  222          return 0;
86979553fd37a9 Casey Schaufler 2022-06-09  223  }
86979553fd37a9 Casey Schaufler 2022-06-09  224  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to