CC: kbuild-...@lists.01.org BCC: l...@intel.com CC: linux-arm-ker...@lists.infradead.org TO: Saurabh Sengar <saurabh.si...@xilinx.com> CC: Michal Simek <mon...@monstr.eu> CC: Hyun Kwon <hyun.k...@xilinx.com> CC: Laurent Pinchart <laurent.pinch...@ideasonboard.com> CC: David Airlie <airl...@linux.ie> CC: Daniel Vetter <dan...@ffwll.ch> CC: dri-de...@lists.freedesktop.org CC: linux-ker...@vger.kernel.org
From: kernel test robot <l...@intel.com> drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325. drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1333. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Saurabh Sengar <saurabh.si...@xilinx.com> Reported-by: kernel test robot <l...@intel.com> Signed-off-by: kernel test robot <l...@intel.com> --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS head: 1e67f149fb5eb4f5eb4e0d4f69194eac6d2497d7 commit: eedc9b61ce549e6a1af512cc21dfd7fa487d0823 [635/1197] drm: xlnx: sdi: Adding sdi-tx driver :::::: branch date: 8 days ago :::::: commit date: 5 months ago Please take the patch only if it's a positive warning. Thanks! drivers/gpu/drm/xlnx/xlnx_sdi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/gpu/drm/xlnx/xlnx_sdi.c +++ b/drivers/gpu/drm/xlnx/xlnx_sdi.c @@ -1322,6 +1322,7 @@ static int xlnx_sdi_probe(struct platfor dev_err(dev, "No remote port at %s\n", port->name); of_node_put(endpoint); ret = -EINVAL; + of_node_put(port); goto err_disable_vidin_clk; } @@ -1330,6 +1331,7 @@ static int xlnx_sdi_probe(struct platfor ret = of_property_read_u32(port, "reg", &index); if (ret) { dev_err(dev, "reg property not present - %d\n", ret); + of_node_put(port); goto err_disable_vidin_clk; } _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org
