CC: kbuild-...@lists.01.org BCC: l...@intel.com In-Reply-To: <20220701142310.2188015-15-gli...@google.com> References: <20220701142310.2188015-15-gli...@google.com> TO: Alexander Potapenko <gli...@google.com> TO: gli...@google.com CC: Alexander Viro <v...@zeniv.linux.org.uk> CC: Alexei Starovoitov <a...@kernel.org> CC: Andrew Morton <a...@linux-foundation.org> CC: Linux Memory Management List <linux...@kvack.org> CC: Andrey Konovalov <andreyk...@google.com> CC: Andy Lutomirski <l...@kernel.org> CC: Arnd Bergmann <a...@arndb.de> CC: Borislav Petkov <b...@alien8.de> CC: Christoph Hellwig <h...@lst.de> CC: Christoph Lameter <c...@linux-foundation.org> CC: David Rientjes <rient...@google.com> CC: Dmitry Vyukov <dvyu...@google.com> CC: Eric Dumazet <eduma...@google.com> CC: "Greg Kroah-Hartman" <gre...@linuxfoundation.org> CC: Herbert Xu <herb...@gondor.apana.org.au> CC: Ilya Leoshkevich <i...@linux.ibm.com> CC: Ingo Molnar <mi...@redhat.com> CC: Jens Axboe <ax...@kernel.dk> CC: Joonsoo Kim <iamjoonsoo....@lge.com> CC: Kees Cook <keesc...@chromium.org> CC: Marco Elver <el...@google.com> CC: Mark Rutland <mark.rutl...@arm.com> CC: Matthew Wilcox <wi...@infradead.org> CC: "Michael S. Tsirkin" <m...@redhat.com> CC: Pekka Enberg <penb...@kernel.org> CC: Peter Zijlstra <pet...@infradead.org> CC: Petr Mladek <pmla...@suse.com> CC: Steven Rostedt <rost...@goodmis.org> CC: Thomas Gleixner <t...@linutronix.de>
Hi Alexander, I love your patch! Perhaps something to improve: [auto build test WARNING on masahiroy-kbuild/for-next] [also build test WARNING on linus/master v5.19-rc4 next-20220701] [cannot apply to tip/x86/core tip/x86/mm] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Potapenko/Add-KernelMemorySanitizer-infrastructure/20220701-222712 base: https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git for-next :::::: branch date: 18 hours ago :::::: commit date: 18 hours ago config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220702/202207021659.oyrs3dio-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> smatch warnings: mm/vmalloc.c:440 __vunmap_range_noflush() warn: bitwise AND condition is false here vim +440 mm/vmalloc.c c2febafc67734a Kirill A. Shutemov 2017-03-09 409 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 410 /* 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 411 * vunmap_range_noflush is similar to vunmap_range, but does not 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 412 * flush caches or TLBs. b521c43f58e523 Christoph Hellwig 2020-06-01 413 * 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 414 * The caller is responsible for calling flush_cache_vmap() before calling 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 415 * this function, and flush_tlb_kernel_range after it has returned 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 416 * successfully (and before the addresses are expected to cause a page fault 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 417 * or be re-mapped for something else, if TLB flushes are being delayed or 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 418 * coalesced). b521c43f58e523 Christoph Hellwig 2020-06-01 419 * 4ad0ae8c64ac8f Nicholas Piggin 2021-04-29 420 * This is an internal function only. Do not use outside mm/. b521c43f58e523 Christoph Hellwig 2020-06-01 421 */ 015e76716e50b4 Alexander Potapenko 2022-07-01 422 void __vunmap_range_noflush(unsigned long start, unsigned long end) ^1da177e4c3f41 Linus Torvalds 2005-04-16 423 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 424 unsigned long next; b521c43f58e523 Christoph Hellwig 2020-06-01 425 pgd_t *pgd; 2ba3e6947aed9b Joerg Roedel 2020-06-01 426 unsigned long addr = start; 2ba3e6947aed9b Joerg Roedel 2020-06-01 427 pgtbl_mod_mask mask = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 428 ^1da177e4c3f41 Linus Torvalds 2005-04-16 429 BUG_ON(addr >= end); ^1da177e4c3f41 Linus Torvalds 2005-04-16 430 pgd = pgd_offset_k(addr); ^1da177e4c3f41 Linus Torvalds 2005-04-16 431 do { ^1da177e4c3f41 Linus Torvalds 2005-04-16 432 next = pgd_addr_end(addr, end); 2ba3e6947aed9b Joerg Roedel 2020-06-01 433 if (pgd_bad(*pgd)) 2ba3e6947aed9b Joerg Roedel 2020-06-01 434 mask |= PGTBL_PGD_MODIFIED; ^1da177e4c3f41 Linus Torvalds 2005-04-16 435 if (pgd_none_or_clear_bad(pgd)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 436 continue; 2ba3e6947aed9b Joerg Roedel 2020-06-01 437 vunmap_p4d_range(pgd, addr, next, &mask); ^1da177e4c3f41 Linus Torvalds 2005-04-16 438 } while (pgd++, addr = next, addr != end); 2ba3e6947aed9b Joerg Roedel 2020-06-01 439 2ba3e6947aed9b Joerg Roedel 2020-06-01 @440 if (mask & ARCH_PAGE_TABLE_SYNC_MASK) 2ba3e6947aed9b Joerg Roedel 2020-06-01 441 arch_sync_kernel_mappings(start, end); ^1da177e4c3f41 Linus Torvalds 2005-04-16 442 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 443 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- kbuild@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org