CC: [email protected]
BCC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Alexander Potapenko <[email protected]>
TO: [email protected]
CC: Alexander Viro <[email protected]>
CC: Alexei Starovoitov <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>
CC: Andrey Konovalov <[email protected]>
CC: Andy Lutomirski <[email protected]>
CC: Arnd Bergmann <[email protected]>
CC: Borislav Petkov <[email protected]>
CC: Christoph Hellwig <[email protected]>
CC: Christoph Lameter <[email protected]>
CC: David Rientjes <[email protected]>
CC: Dmitry Vyukov <[email protected]>
CC: Eric Dumazet <[email protected]>
CC: "Greg Kroah-Hartman" <[email protected]>
CC: Herbert Xu <[email protected]>
CC: Ilya Leoshkevich <[email protected]>
CC: Ingo Molnar <[email protected]>
CC: Jens Axboe <[email protected]>
CC: Joonsoo Kim <[email protected]>
CC: Kees Cook <[email protected]>
CC: Marco Elver <[email protected]>
CC: Mark Rutland <[email protected]>
CC: Matthew Wilcox <[email protected]>
CC: "Michael S. Tsirkin" <[email protected]>
CC: Pekka Enberg <[email protected]>
CC: Peter Zijlstra <[email protected]>
CC: Petr Mladek <[email protected]>
CC: Steven Rostedt <[email protected]>
CC: Thomas Gleixner <[email protected]>

Hi Alexander,

I love your patch! Perhaps something to improve:

[auto build test WARNING on masahiroy-kbuild/for-next]
[also build test WARNING on linus/master v5.19-rc4 next-20220701]
[cannot apply to tip/x86/core tip/x86/mm]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/intel-lab-lkp/linux/commits/Alexander-Potapenko/Add-KernelMemorySanitizer-infrastructure/20220701-222712
base:   
https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git 
for-next
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago
config: x86_64-randconfig-m001 
(https://download.01.org/0day-ci/archive/20220702/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
mm/vmalloc.c:440 __vunmap_range_noflush() warn: bitwise AND condition is false 
here

vim +440 mm/vmalloc.c

c2febafc67734a Kirill A. Shutemov  2017-03-09  409  
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  410  /*
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  411   * vunmap_range_noflush is 
similar to vunmap_range, but does not
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  412   * flush caches or TLBs.
b521c43f58e523 Christoph Hellwig   2020-06-01  413   *
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  414   * The caller is 
responsible for calling flush_cache_vmap() before calling
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  415   * this function, and 
flush_tlb_kernel_range after it has returned
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  416   * successfully (and before 
the addresses are expected to cause a page fault
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  417   * or be re-mapped for 
something else, if TLB flushes are being delayed or
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  418   * coalesced).
b521c43f58e523 Christoph Hellwig   2020-06-01  419   *
4ad0ae8c64ac8f Nicholas Piggin     2021-04-29  420   * This is an internal 
function only. Do not use outside mm/.
b521c43f58e523 Christoph Hellwig   2020-06-01  421   */
015e76716e50b4 Alexander Potapenko 2022-07-01  422  void 
__vunmap_range_noflush(unsigned long start, unsigned long end)
^1da177e4c3f41 Linus Torvalds      2005-04-16  423  {
^1da177e4c3f41 Linus Torvalds      2005-04-16  424      unsigned long next;
b521c43f58e523 Christoph Hellwig   2020-06-01  425      pgd_t *pgd;
2ba3e6947aed9b Joerg Roedel        2020-06-01  426      unsigned long addr = 
start;
2ba3e6947aed9b Joerg Roedel        2020-06-01  427      pgtbl_mod_mask mask = 0;
^1da177e4c3f41 Linus Torvalds      2005-04-16  428  
^1da177e4c3f41 Linus Torvalds      2005-04-16  429      BUG_ON(addr >= end);
^1da177e4c3f41 Linus Torvalds      2005-04-16  430      pgd = 
pgd_offset_k(addr);
^1da177e4c3f41 Linus Torvalds      2005-04-16  431      do {
^1da177e4c3f41 Linus Torvalds      2005-04-16  432              next = 
pgd_addr_end(addr, end);
2ba3e6947aed9b Joerg Roedel        2020-06-01  433              if 
(pgd_bad(*pgd))
2ba3e6947aed9b Joerg Roedel        2020-06-01  434                      mask |= 
PGTBL_PGD_MODIFIED;
^1da177e4c3f41 Linus Torvalds      2005-04-16  435              if 
(pgd_none_or_clear_bad(pgd))
^1da177e4c3f41 Linus Torvalds      2005-04-16  436                      
continue;
2ba3e6947aed9b Joerg Roedel        2020-06-01  437              
vunmap_p4d_range(pgd, addr, next, &mask);
^1da177e4c3f41 Linus Torvalds      2005-04-16  438      } while (pgd++, addr = 
next, addr != end);
2ba3e6947aed9b Joerg Roedel        2020-06-01  439  
2ba3e6947aed9b Joerg Roedel        2020-06-01 @440      if (mask & 
ARCH_PAGE_TABLE_SYNC_MASK)
2ba3e6947aed9b Joerg Roedel        2020-06-01  441              
arch_sync_kernel_mappings(start, end);
^1da177e4c3f41 Linus Torvalds      2005-04-16  442  }
^1da177e4c3f41 Linus Torvalds      2005-04-16  443  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to