BCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Irui Wang <[email protected]> TO: Hans Verkuil <[email protected]> TO: [email protected] TO: Rob Herring <[email protected]> TO: Mauro Carvalho Chehab <[email protected]> CC: [email protected] TO: Matthias Brugger <[email protected]> TO: Alexandre Courbot <[email protected]> TO: Tiffany Lin <[email protected]> TO: "Andrew-CT Chen" <[email protected]> TO: "Tzung-Bi Shih" <[email protected]> TO: Tomasz Figa <[email protected]> TO: [email protected] CC: Maoguang Meng <[email protected]> CC: Longfei Wang <[email protected]> CC: Yunfei Dong <[email protected]> CC: Irui Wang <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi Irui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on linus/master next-20220812] [cannot apply to v5.19] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Irui-Wang/Support-H264-multi-core-encoder-on-MT8195/20220729-115415 base: git://linuxtv.org/media_tree.git master :::::: branch date: 2 weeks ago :::::: commit date: 2 weeks ago config: arm-randconfig-m041-20220812 (https://download.01.org/0day-ci/archive/20220814/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c:77 mtk_enc_core_power_on() error: uninitialized symbol 'ret'. vim +/ret +77 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c 4e855a6efa5470d8 drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c Tiffany Lin 2016-05-03 59 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 60 static int mtk_enc_core_power_on(struct mtk_vcodec_ctx *ctx) 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 61 { 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 62 struct mtk_venc_hw_dev *sub_core; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 63 int ret, i; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 64 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 65 /* multi-core encoding need power on all available cores */ 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 66 for (i = 0; i < MTK_VENC_HW_MAX; i++) { 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 67 sub_core = (struct mtk_venc_hw_dev *)ctx->dev->enc_hw_dev[i]; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 68 if (!sub_core) 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 69 continue; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 70 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 71 ret = pm_runtime_resume_and_get(&sub_core->plat_dev->dev); 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 72 if (ret) { 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 73 mtk_v4l2_err("power on sub_core[%d] fail %d", i, ret); 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 74 goto pm_on_fail; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 75 } 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 76 } 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 @77 return ret; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 78 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 79 pm_on_fail: 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 80 for (i -= 1; i >= 0; i--) { 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 81 sub_core = (struct mtk_venc_hw_dev *)ctx->dev->enc_hw_dev[i]; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 82 pm_runtime_put_sync(&sub_core->plat_dev->dev); 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 83 } 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 84 return ret; 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 85 } 1fd72375b4f44395 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c Irui Wang 2022-07-29 86 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
