BCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Szuying Chen <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi Szuying, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v6.0-rc1 next-20220819] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Szuying-Chen/thunderbolt-thunderbolt-add-vendor-s-NVM-formats/20220816-193757 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 :::::: branch date: 4 days ago :::::: commit date: 4 days ago config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220821/[email protected]/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/thunderbolt/nvm.c:107 asmedia_nvm_validate() warn: statement has no effect 3 Old smatch warnings: drivers/thunderbolt/nvm.c:160 tb_nvm_validate() warn: inconsistent indenting vim +107 drivers/thunderbolt/nvm.c 16b15f1135451c Szuying Chen 2022-08-16 61 16b15f1135451c Szuying Chen 2022-08-16 62 static int asmedia_nvm_validate(struct tb_switch *sw, unsigned int mode) 16b15f1135451c Szuying Chen 2022-08-16 63 { 16b15f1135451c Szuying Chen 2022-08-16 64 struct tb_nvm *nvm; 16b15f1135451c Szuying Chen 2022-08-16 65 u32 val; 16b15f1135451c Szuying Chen 2022-08-16 66 u32 nvm_size; 16b15f1135451c Szuying Chen 2022-08-16 67 int ret = 0; 16b15f1135451c Szuying Chen 2022-08-16 68 unsigned int image_size; 16b15f1135451c Szuying Chen 2022-08-16 69 16b15f1135451c Szuying Chen 2022-08-16 70 switch (mode) { 16b15f1135451c Szuying Chen 2022-08-16 71 case NVM_UPGRADE: 16b15f1135451c Szuying Chen 2022-08-16 72 if (sw->no_nvm_upgrade) 16b15f1135451c Szuying Chen 2022-08-16 73 sw->no_nvm_upgrade = false; 16b15f1135451c Szuying Chen 2022-08-16 74 16b15f1135451c Szuying Chen 2022-08-16 75 break; 16b15f1135451c Szuying Chen 2022-08-16 76 16b15f1135451c Szuying Chen 2022-08-16 77 case NVM_ADD: 16b15f1135451c Szuying Chen 2022-08-16 78 nvm = tb_nvm_alloc(&sw->dev); 16b15f1135451c Szuying Chen 2022-08-16 79 if (IS_ERR(nvm)) { 16b15f1135451c Szuying Chen 2022-08-16 80 ret = PTR_ERR(nvm); 16b15f1135451c Szuying Chen 2022-08-16 81 break; 16b15f1135451c Szuying Chen 2022-08-16 82 } 16b15f1135451c Szuying Chen 2022-08-16 83 16b15f1135451c Szuying Chen 2022-08-16 84 ret = usb4_switch_nvm_read(sw, ASMEDIA_NVM_VERSION, &val, sizeof(val)); 16b15f1135451c Szuying Chen 2022-08-16 85 if (ret) 16b15f1135451c Szuying Chen 2022-08-16 86 break; 16b15f1135451c Szuying Chen 2022-08-16 87 16b15f1135451c Szuying Chen 2022-08-16 88 nvm->nvm_asm.major = (((u8)val) << 0x10 | ((u8)(val >> 0x8)) << 0x8 | (u8)(val >> 0x10)); 16b15f1135451c Szuying Chen 2022-08-16 89 ret = usb4_switch_nvm_read(sw, ASMEDIA_NVM_DATE, &val, sizeof(val)); 16b15f1135451c Szuying Chen 2022-08-16 90 if (ret) 16b15f1135451c Szuying Chen 2022-08-16 91 break; 16b15f1135451c Szuying Chen 2022-08-16 92 16b15f1135451c Szuying Chen 2022-08-16 93 nvm->nvm_asm.minor = (((u8)val) << 0x10 | ((u8)(val >> 0x8)) << 0x8 | (u8)(val >> 0x10)); 16b15f1135451c Szuying Chen 2022-08-16 94 nvm_size = SZ_512K; 16b15f1135451c Szuying Chen 2022-08-16 95 ret = tb_nvm_add_active(nvm, nvm_size, tb_switch_nvm_read); 16b15f1135451c Szuying Chen 2022-08-16 96 if (ret) 16b15f1135451c Szuying Chen 2022-08-16 97 break; 16b15f1135451c Szuying Chen 2022-08-16 98 16b15f1135451c Szuying Chen 2022-08-16 99 ret = tb_nvm_add_non_active(nvm, NVM_MAX_SIZE, tb_switch_nvm_write); 16b15f1135451c Szuying Chen 2022-08-16 100 if (ret) 16b15f1135451c Szuying Chen 2022-08-16 101 break; 16b15f1135451c Szuying Chen 2022-08-16 102 16b15f1135451c Szuying Chen 2022-08-16 103 sw->nvm = nvm; 16b15f1135451c Szuying Chen 2022-08-16 104 break; 16b15f1135451c Szuying Chen 2022-08-16 105 16b15f1135451c Szuying Chen 2022-08-16 106 case NVM_WRITE: 16b15f1135451c Szuying Chen 2022-08-16 @107 const u8 *buf = sw->nvm->buf; 16b15f1135451c Szuying Chen 2022-08-16 108 16b15f1135451c Szuying Chen 2022-08-16 109 if (!buf) { 16b15f1135451c Szuying Chen 2022-08-16 110 ret = -EINVAL; 16b15f1135451c Szuying Chen 2022-08-16 111 break; 16b15f1135451c Szuying Chen 2022-08-16 112 } 16b15f1135451c Szuying Chen 2022-08-16 113 image_size = sw->nvm->buf_data_size; 16b15f1135451c Szuying Chen 2022-08-16 114 if (image_size < NVM_MIN_SIZE || image_size > NVM_MAX_SIZE) { 16b15f1135451c Szuying Chen 2022-08-16 115 ret = -EINVAL; 16b15f1135451c Szuying Chen 2022-08-16 116 break; 16b15f1135451c Szuying Chen 2022-08-16 117 } 16b15f1135451c Szuying Chen 2022-08-16 118 ret = usb4_switch_nvm_write(sw, 0, buf, image_size); 16b15f1135451c Szuying Chen 2022-08-16 119 if (!ret) 16b15f1135451c Szuying Chen 2022-08-16 120 sw->nvm->flushed = true; 16b15f1135451c Szuying Chen 2022-08-16 121 16b15f1135451c Szuying Chen 2022-08-16 122 break; 16b15f1135451c Szuying Chen 2022-08-16 123 16b15f1135451c Szuying Chen 2022-08-16 124 default: 16b15f1135451c Szuying Chen 2022-08-16 125 break; 16b15f1135451c Szuying Chen 2022-08-16 126 } 16b15f1135451c Szuying Chen 2022-08-16 127 16b15f1135451c Szuying Chen 2022-08-16 128 if ((mode == NVM_ADD) && (ret != 0)) 16b15f1135451c Szuying Chen 2022-08-16 129 tb_nvm_free(sw->nvm); 16b15f1135451c Szuying Chen 2022-08-16 130 16b15f1135451c Szuying Chen 2022-08-16 131 return ret; 16b15f1135451c Szuying Chen 2022-08-16 132 } 16b15f1135451c Szuying Chen 2022-08-16 133 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
