:::::: :::::: Manual check reason: "low confidence static check warning: drivers/clk/clk-sp7021.c:417:25: warning: Parameter 'prate' can be declared with const [constParameter]" ::::::
BCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Qin Jian <[email protected]> TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: Qin Jian <[email protected]> Hi Qin, I love your patch! Perhaps something to improve: [auto build test WARNING on 568035b01cfb107af8d2e4bd2fb9aea22cf5b868] url: https://github.com/intel-lab-lkp/linux/commits/Qin-Jian/clk-Add-Sunplus-SP7021-clock-driver/20220817-151010 base: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 :::::: branch date: 8 days ago :::::: commit date: 8 days ago compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout 5673230d6a56d6c37b8db18d202c0ef526f52b2e cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/clk/clk-sp7021.c:417:25: warning: Parameter 'prate' can be declared >> with const [constParameter] unsigned long *prate) ^ vim +/prate +417 drivers/clk/clk-sp7021.c 5673230d6a56d6 Qin Jian 2022-08-17 415 5673230d6a56d6 Qin Jian 2022-08-17 416 static long sp_pll_round_rate(struct clk_hw *hw, unsigned long rate, 5673230d6a56d6 Qin Jian 2022-08-17 @417 unsigned long *prate) 5673230d6a56d6 Qin Jian 2022-08-17 418 { 5673230d6a56d6 Qin Jian 2022-08-17 419 struct sp_pll *clk = to_sp_pll(hw); 5673230d6a56d6 Qin Jian 2022-08-17 420 long ret; 5673230d6a56d6 Qin Jian 2022-08-17 421 5673230d6a56d6 Qin Jian 2022-08-17 422 if (rate == *prate) { 5673230d6a56d6 Qin Jian 2022-08-17 423 ret = *prate; /* bypass */ 5673230d6a56d6 Qin Jian 2022-08-17 424 } else if (clk->div_width == DIV_A) { 5673230d6a56d6 Qin Jian 2022-08-17 425 ret = plla_round_rate(clk, rate); 5673230d6a56d6 Qin Jian 2022-08-17 426 } else if (clk->div_width == DIV_TV) { 5673230d6a56d6 Qin Jian 2022-08-17 427 ret = plltv_div(clk, rate); 5673230d6a56d6 Qin Jian 2022-08-17 428 if (ret < 0) 5673230d6a56d6 Qin Jian 2022-08-17 429 ret = *prate; 5673230d6a56d6 Qin Jian 2022-08-17 430 } else { 5673230d6a56d6 Qin Jian 2022-08-17 431 ret = sp_pll_calc_div(clk, rate) * clk->brate; 5673230d6a56d6 Qin Jian 2022-08-17 432 } 5673230d6a56d6 Qin Jian 2022-08-17 433 5673230d6a56d6 Qin Jian 2022-08-17 434 return ret; 5673230d6a56d6 Qin Jian 2022-08-17 435 } 5673230d6a56d6 Qin Jian 2022-08-17 436 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
