BCC: [email protected] CC: [email protected] CC: [email protected] TO: Lucas Tanure <[email protected]> CC: Mark Brown <[email protected]> CC: Shreeya Patel <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-6.1 head: 3fe26121dc3a9bf64e18fe0075cd9a92c9cd1b1a commit: 3fe26121dc3a9bf64e18fe0075cd9a92c9cd1b1a [19/19] spi: amd: Configure device speed :::::: branch date: 13 hours ago :::::: commit date: 13 hours ago config: arm64-randconfig-m041-20220824 (https://download.01.org/0day-ci/archive/20220826/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/spi/spi-amd.c:253 amd_set_spi_freq() error: buffer overflow 'amd_spi_freq' 9 <= 9 (assuming for loop doesn't break) Old smatch warnings: drivers/spi/spi-amd.c:256 amd_set_spi_freq() error: buffer overflow 'amd_spi_freq' 9 <= 9 (assuming for loop doesn't break) drivers/spi/spi-amd.c:258 amd_set_spi_freq() error: buffer overflow 'amd_spi_freq' 9 <= 9 (assuming for loop doesn't break) drivers/spi/spi-amd.c:267 amd_set_spi_freq() error: buffer overflow 'amd_spi_freq' 9 <= 9 (assuming for loop doesn't break) drivers/spi/spi-amd.c:268 amd_set_spi_freq() error: buffer overflow 'amd_spi_freq' 9 <= 9 (assuming for loop doesn't break) vim +253 drivers/spi/spi-amd.c 3fe26121dc3a9b Lucas Tanure 2022-08-25 238 3fe26121dc3a9b Lucas Tanure 2022-08-25 239 static int amd_set_spi_freq(struct amd_spi *amd_spi, u32 speed_hz) 3fe26121dc3a9b Lucas Tanure 2022-08-25 240 { 3fe26121dc3a9b Lucas Tanure 2022-08-25 241 unsigned int i, spd7_val, alt_spd; 3fe26121dc3a9b Lucas Tanure 2022-08-25 242 3fe26121dc3a9b Lucas Tanure 2022-08-25 243 if (speed_hz == amd_spi->speed_hz) 3fe26121dc3a9b Lucas Tanure 2022-08-25 244 return 0; 3fe26121dc3a9b Lucas Tanure 2022-08-25 245 3fe26121dc3a9b Lucas Tanure 2022-08-25 246 if (speed_hz < AMD_SPI_MIN_HZ) 3fe26121dc3a9b Lucas Tanure 2022-08-25 247 return -EINVAL; 3fe26121dc3a9b Lucas Tanure 2022-08-25 248 3fe26121dc3a9b Lucas Tanure 2022-08-25 249 for (i = 0; i < ARRAY_SIZE(amd_spi_freq); i++) 3fe26121dc3a9b Lucas Tanure 2022-08-25 250 if (speed_hz >= amd_spi_freq[i].speed_hz) 3fe26121dc3a9b Lucas Tanure 2022-08-25 251 break; 3fe26121dc3a9b Lucas Tanure 2022-08-25 252 3fe26121dc3a9b Lucas Tanure 2022-08-25 @253 if (speed_hz == amd_spi_freq[i].speed_hz) 3fe26121dc3a9b Lucas Tanure 2022-08-25 254 return 0; 3fe26121dc3a9b Lucas Tanure 2022-08-25 255 3fe26121dc3a9b Lucas Tanure 2022-08-25 256 amd_spi->speed_hz = amd_spi_freq[i].speed_hz; 3fe26121dc3a9b Lucas Tanure 2022-08-25 257 3fe26121dc3a9b Lucas Tanure 2022-08-25 258 alt_spd = (amd_spi_freq[i].enable_val << AMD_SPI_ALT_SPD_SHIFT) 3fe26121dc3a9b Lucas Tanure 2022-08-25 259 & AMD_SPI_ALT_SPD_MASK; 3fe26121dc3a9b Lucas Tanure 2022-08-25 260 amd_spi_setclear_reg32(amd_spi, AMD_SPI_ENA_REG, alt_spd, 3fe26121dc3a9b Lucas Tanure 2022-08-25 261 AMD_SPI_ALT_SPD_MASK); 3fe26121dc3a9b Lucas Tanure 2022-08-25 262 3fe26121dc3a9b Lucas Tanure 2022-08-25 263 if (amd_spi->speed_hz == AMD_SPI_MAX_HZ) 3fe26121dc3a9b Lucas Tanure 2022-08-25 264 amd_spi_setclear_reg32(amd_spi, AMD_SPI_ENA_REG, 1, 3fe26121dc3a9b Lucas Tanure 2022-08-25 265 AMD_SPI_SPI100_MASK); 3fe26121dc3a9b Lucas Tanure 2022-08-25 266 3fe26121dc3a9b Lucas Tanure 2022-08-25 267 if (amd_spi_freq[i].spd7_val) { 3fe26121dc3a9b Lucas Tanure 2022-08-25 268 spd7_val = (amd_spi_freq[i].spd7_val << AMD_SPI_SPD7_SHIFT) 3fe26121dc3a9b Lucas Tanure 2022-08-25 269 & AMD_SPI_SPD7_MASK; 3fe26121dc3a9b Lucas Tanure 2022-08-25 270 amd_spi_setclear_reg32(amd_spi, AMD_SPI_SPEED_REG, spd7_val, 3fe26121dc3a9b Lucas Tanure 2022-08-25 271 AMD_SPI_SPD7_MASK); 3fe26121dc3a9b Lucas Tanure 2022-08-25 272 } 3fe26121dc3a9b Lucas Tanure 2022-08-25 273 3fe26121dc3a9b Lucas Tanure 2022-08-25 274 return 0; 3fe26121dc3a9b Lucas Tanure 2022-08-25 275 } 3fe26121dc3a9b Lucas Tanure 2022-08-25 276 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
