:::::: :::::: Manual check reason: "low confidence static check warning: drivers/gpu/drm/via/via_dri1.c:353:50: warning: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned]" ::::::
BCC: [email protected] CC: [email protected] CC: Linux Memory Management List <[email protected]> TO: Sam Ravnborg <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 8d0c42c9e80791e8baba2932d2cbd2dcead50d47 commit: b0b3a879258ef43cf15b0bac30b92e7c1c4ebbae [363/3682] drm/via: Embed via_irq in via_dri1 :::::: branch date: 13 hours ago :::::: commit date: 6 weeks ago compiler: mipsel-linux-gcc (GCC) 12.1.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout b0b3a879258ef43cf15b0bac30b92e7c1c4ebbae cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/gpu/drm/via/via_dri1.c:353:50: warning: Shifting signed 32-bit value >> by 31 bits is implementation-defined behaviour [shiftTooManyBitsSigned] via_write(dev_priv, VIA_REG_INTERRUPT, status | VIA_IRQ_GLOBAL ^ >> drivers/gpu/drm/via/via_dri1.c:353:50: warning: Signed integer overflow for >> expression '1<<31'. [integerOverflow] via_write(dev_priv, VIA_REG_INTERRUPT, status | VIA_IRQ_GLOBAL ^ >> drivers/hwmon/hwmon.c:1065:66: warning: Parameter 'data' can be declared >> with const [constParameter] static int devm_hwmon_match(struct device *dev, void *res, void *data) ^ >> drivers/hwmon/hwmon.c:288:15: warning: Uninitialized variable: tzdata->index >> [uninitvar] if (tzdata->index == index) { ^ -- >> drivers/hwmon/pmbus/pmbus_core.c:165:24: warning: Either the condition >> 'page<0' is redundant or the array 'data->info->func[32]' is accessed at >> index 32, which is out of bounds. [arrayIndexOutOfBoundsCond] if (!(data->info->func[page] & PMBUS_PAGE_VIRTUAL) && ^ drivers/hwmon/pmbus/pmbus_core.c:162:11: note: Assuming that condition 'page<0' is not redundant if (page < 0) ^ drivers/hwmon/pmbus/pmbus_core.c:165:24: note: Array index out of bounds if (!(data->info->func[page] & PMBUS_PAGE_VIRTUAL) && ^ vim +353 drivers/gpu/drm/via/via_dri1.c b0b3a879258ef4 Sam Ravnborg 2022-07-13 342 b0b3a879258ef4 Sam Ravnborg 2022-07-13 343 static int via_driver_irq_postinstall(struct drm_device *dev) b0b3a879258ef4 Sam Ravnborg 2022-07-13 344 { b0b3a879258ef4 Sam Ravnborg 2022-07-13 345 drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private; b0b3a879258ef4 Sam Ravnborg 2022-07-13 346 u32 status; b0b3a879258ef4 Sam Ravnborg 2022-07-13 347 b0b3a879258ef4 Sam Ravnborg 2022-07-13 348 DRM_DEBUG("fun: %s\n", __func__); b0b3a879258ef4 Sam Ravnborg 2022-07-13 349 if (!dev_priv) b0b3a879258ef4 Sam Ravnborg 2022-07-13 350 return -EINVAL; b0b3a879258ef4 Sam Ravnborg 2022-07-13 351 b0b3a879258ef4 Sam Ravnborg 2022-07-13 352 status = via_read(dev_priv, VIA_REG_INTERRUPT); b0b3a879258ef4 Sam Ravnborg 2022-07-13 @353 via_write(dev_priv, VIA_REG_INTERRUPT, status | VIA_IRQ_GLOBAL b0b3a879258ef4 Sam Ravnborg 2022-07-13 354 | dev_priv->irq_enable_mask); b0b3a879258ef4 Sam Ravnborg 2022-07-13 355 b0b3a879258ef4 Sam Ravnborg 2022-07-13 356 /* Some magic, oh for some data sheets ! */ b0b3a879258ef4 Sam Ravnborg 2022-07-13 357 via_write8(dev_priv, 0x83d4, 0x11); b0b3a879258ef4 Sam Ravnborg 2022-07-13 358 via_write8_mask(dev_priv, 0x83d5, 0x30, 0x30); b0b3a879258ef4 Sam Ravnborg 2022-07-13 359 b0b3a879258ef4 Sam Ravnborg 2022-07-13 360 return 0; b0b3a879258ef4 Sam Ravnborg 2022-07-13 361 } b0b3a879258ef4 Sam Ravnborg 2022-07-13 362 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
