BCC: [email protected] CC: [email protected] CC: [email protected] TO: Oleksandr Mazur <[email protected]> CC: Yevhen Orlov <[email protected]> CC: Taras Chornyi <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dcf8e5633e2e69ad60b730ab5905608b756a032f commit: 52323ef75414d60b17f683076833eb55a6bffa2b net: marvell: prestera: add phylink support date: 6 weeks ago :::::: branch date: 15 hours ago :::::: commit date: 6 weeks ago config: x86_64-randconfig-m041-20220829 (https://download.01.org/0day-ci/archive/20220830/[email protected]/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/net/ethernet/marvell/prestera/prestera_main.c:421 prestera_port_sfp_bind() error: uninitialized symbol 'err'. Old smatch warnings: drivers/net/ethernet/marvell/prestera/prestera_main.c:860 prestera_switch_set_base_mac_addr() error: uninitialized symbol 'ret'. vim +/err +421 drivers/net/ethernet/marvell/prestera/prestera_main.c 52323ef75414d6 Oleksandr Mazur 2022-07-19 359 52323ef75414d6 Oleksandr Mazur 2022-07-19 360 static int prestera_port_sfp_bind(struct prestera_port *port) 52323ef75414d6 Oleksandr Mazur 2022-07-19 361 { 52323ef75414d6 Oleksandr Mazur 2022-07-19 362 struct prestera_switch *sw = port->sw; 52323ef75414d6 Oleksandr Mazur 2022-07-19 363 struct device_node *ports, *node; 52323ef75414d6 Oleksandr Mazur 2022-07-19 364 struct fwnode_handle *fwnode; 52323ef75414d6 Oleksandr Mazur 2022-07-19 365 struct phylink *phy_link; 52323ef75414d6 Oleksandr Mazur 2022-07-19 366 int err; 52323ef75414d6 Oleksandr Mazur 2022-07-19 367 52323ef75414d6 Oleksandr Mazur 2022-07-19 368 if (!sw->np) 52323ef75414d6 Oleksandr Mazur 2022-07-19 369 return 0; 52323ef75414d6 Oleksandr Mazur 2022-07-19 370 52323ef75414d6 Oleksandr Mazur 2022-07-19 371 ports = of_find_node_by_name(sw->np, "ports"); 52323ef75414d6 Oleksandr Mazur 2022-07-19 372 52323ef75414d6 Oleksandr Mazur 2022-07-19 373 for_each_child_of_node(ports, node) { 52323ef75414d6 Oleksandr Mazur 2022-07-19 374 int num; 52323ef75414d6 Oleksandr Mazur 2022-07-19 375 52323ef75414d6 Oleksandr Mazur 2022-07-19 376 err = of_property_read_u32(node, "prestera,port-num", &num); 52323ef75414d6 Oleksandr Mazur 2022-07-19 377 if (err) { 52323ef75414d6 Oleksandr Mazur 2022-07-19 378 dev_err(sw->dev->dev, 52323ef75414d6 Oleksandr Mazur 2022-07-19 379 "device node %pOF has no valid reg property: %d\n", 52323ef75414d6 Oleksandr Mazur 2022-07-19 380 node, err); 52323ef75414d6 Oleksandr Mazur 2022-07-19 381 goto out; 52323ef75414d6 Oleksandr Mazur 2022-07-19 382 } 52323ef75414d6 Oleksandr Mazur 2022-07-19 383 52323ef75414d6 Oleksandr Mazur 2022-07-19 384 if (port->fp_id != num) 52323ef75414d6 Oleksandr Mazur 2022-07-19 385 continue; 52323ef75414d6 Oleksandr Mazur 2022-07-19 386 52323ef75414d6 Oleksandr Mazur 2022-07-19 387 port->phylink_pcs.ops = &prestera_pcs_ops; 52323ef75414d6 Oleksandr Mazur 2022-07-19 388 52323ef75414d6 Oleksandr Mazur 2022-07-19 389 port->phy_config.dev = &port->dev->dev; 52323ef75414d6 Oleksandr Mazur 2022-07-19 390 port->phy_config.type = PHYLINK_NETDEV; 52323ef75414d6 Oleksandr Mazur 2022-07-19 391 52323ef75414d6 Oleksandr Mazur 2022-07-19 392 fwnode = of_fwnode_handle(node); 52323ef75414d6 Oleksandr Mazur 2022-07-19 393 52323ef75414d6 Oleksandr Mazur 2022-07-19 394 __set_bit(PHY_INTERFACE_MODE_10GBASER, 52323ef75414d6 Oleksandr Mazur 2022-07-19 395 port->phy_config.supported_interfaces); 52323ef75414d6 Oleksandr Mazur 2022-07-19 396 __set_bit(PHY_INTERFACE_MODE_2500BASEX, 52323ef75414d6 Oleksandr Mazur 2022-07-19 397 port->phy_config.supported_interfaces); 52323ef75414d6 Oleksandr Mazur 2022-07-19 398 __set_bit(PHY_INTERFACE_MODE_SGMII, 52323ef75414d6 Oleksandr Mazur 2022-07-19 399 port->phy_config.supported_interfaces); 52323ef75414d6 Oleksandr Mazur 2022-07-19 400 __set_bit(PHY_INTERFACE_MODE_1000BASEX, 52323ef75414d6 Oleksandr Mazur 2022-07-19 401 port->phy_config.supported_interfaces); 52323ef75414d6 Oleksandr Mazur 2022-07-19 402 52323ef75414d6 Oleksandr Mazur 2022-07-19 403 port->phy_config.mac_capabilities = 52323ef75414d6 Oleksandr Mazur 2022-07-19 404 MAC_1000 | MAC_2500FD | MAC_10000FD; 52323ef75414d6 Oleksandr Mazur 2022-07-19 405 52323ef75414d6 Oleksandr Mazur 2022-07-19 406 phy_link = phylink_create(&port->phy_config, fwnode, 52323ef75414d6 Oleksandr Mazur 2022-07-19 407 PHY_INTERFACE_MODE_INTERNAL, 52323ef75414d6 Oleksandr Mazur 2022-07-19 408 &prestera_mac_ops); 52323ef75414d6 Oleksandr Mazur 2022-07-19 409 if (IS_ERR(phy_link)) { 52323ef75414d6 Oleksandr Mazur 2022-07-19 410 netdev_err(port->dev, "failed to create phylink\n"); 52323ef75414d6 Oleksandr Mazur 2022-07-19 411 err = PTR_ERR(phy_link); 52323ef75414d6 Oleksandr Mazur 2022-07-19 412 goto out; 52323ef75414d6 Oleksandr Mazur 2022-07-19 413 } 52323ef75414d6 Oleksandr Mazur 2022-07-19 414 52323ef75414d6 Oleksandr Mazur 2022-07-19 415 port->phy_link = phy_link; 52323ef75414d6 Oleksandr Mazur 2022-07-19 416 break; 52323ef75414d6 Oleksandr Mazur 2022-07-19 417 } 52323ef75414d6 Oleksandr Mazur 2022-07-19 418 52323ef75414d6 Oleksandr Mazur 2022-07-19 419 out: 52323ef75414d6 Oleksandr Mazur 2022-07-19 420 of_node_put(ports); 52323ef75414d6 Oleksandr Mazur 2022-07-19 @421 return err; 52323ef75414d6 Oleksandr Mazur 2022-07-19 422 } 52323ef75414d6 Oleksandr Mazur 2022-07-19 423 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
