BCC: [email protected]
CC: [email protected]
CC: [email protected]
TO: Mark Pearson <[email protected]>
CC: Hans de Goede <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
master
head:   c5e4d5e99162ba8025d58a3af7ad103f155d2df7
commit: e1c21608e3cfc4b44ecdf04e12986b6564667095 platform/x86: thinkpad_acpi: 
Add PSC mode support
date:   6 months ago
:::::: branch date: 21 hours ago
:::::: commit date: 6 months ago
config: x86_64-randconfig-m031-20220829 
(https://download.01.org/0day-ci/archive/20220901/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
drivers/platform/x86/thinkpad_acpi.c:10370 dytc_profile_refresh() error: 
uninitialized symbol 'output'.

Old smatch warnings:
drivers/platform/x86/thinkpad_acpi.c:2591 hotkey_inputdev_close() warn: bitwise 
AND condition is false here
drivers/platform/x86/thinkpad_acpi.c:3761 hotkey_notify_hotkey() warn: bitwise 
AND condition is false here
drivers/platform/x86/thinkpad_acpi.c:10367 dytc_profile_refresh() error: 
uninitialized symbol 'err'.

vim +/output +10370 drivers/platform/x86/thinkpad_acpi.c

c3bfcd4c676238 Mark Pearson 2021-01-11  10350  
c3bfcd4c676238 Mark Pearson 2021-01-11  10351  static void 
dytc_profile_refresh(void)
c3bfcd4c676238 Mark Pearson 2021-01-11  10352  {
c3bfcd4c676238 Mark Pearson 2021-01-11  10353   enum platform_profile_option 
profile;
c3bfcd4c676238 Mark Pearson 2021-01-11  10354   int output, err;
c3bfcd4c676238 Mark Pearson 2021-01-11  10355   int perfmode;
c3bfcd4c676238 Mark Pearson 2021-01-11  10356  
c3bfcd4c676238 Mark Pearson 2021-01-11  10357   mutex_lock(&dytc_mutex);
e1c21608e3cfc4 Mark Pearson 2022-02-25  10358   if (dytc_profile_available == 
DYTC_FUNCMODE_MMC) {
7a47f86bba748b Mark Pearson 2021-04-06  10359           if 
(dytc_mmc_get_available)
7a47f86bba748b Mark Pearson 2021-04-06  10360                   err = 
dytc_command(DYTC_CMD_MMC_GET, &output);
7a47f86bba748b Mark Pearson 2021-04-06  10361           else
c3bfcd4c676238 Mark Pearson 2021-01-11  10362                   err = 
dytc_cql_command(DYTC_CMD_GET, &output);
e1c21608e3cfc4 Mark Pearson 2022-02-25  10363   } else if 
(dytc_profile_available == DYTC_FUNCMODE_PSC)
e1c21608e3cfc4 Mark Pearson 2022-02-25  10364           err = 
dytc_command(DYTC_CMD_GET, &output);
e1c21608e3cfc4 Mark Pearson 2022-02-25  10365  
c3bfcd4c676238 Mark Pearson 2021-01-11  10366   mutex_unlock(&dytc_mutex);
c3bfcd4c676238 Mark Pearson 2021-01-11  10367   if (err)
c3bfcd4c676238 Mark Pearson 2021-01-11  10368           return;
c3bfcd4c676238 Mark Pearson 2021-01-11  10369  
c3bfcd4c676238 Mark Pearson 2021-01-11 @10370   perfmode = (output >> 
DYTC_GET_MODE_BIT) & 0xF;
c3bfcd4c676238 Mark Pearson 2021-01-11  10371   
convert_dytc_to_profile(perfmode, &profile);
c3bfcd4c676238 Mark Pearson 2021-01-11  10372   if (profile != 
dytc_current_profile) {
c3bfcd4c676238 Mark Pearson 2021-01-11  10373           dytc_current_profile = 
profile;
c3bfcd4c676238 Mark Pearson 2021-01-11  10374           
platform_profile_notify();
c3bfcd4c676238 Mark Pearson 2021-01-11  10375   }
c3bfcd4c676238 Mark Pearson 2021-01-11  10376  }
c3bfcd4c676238 Mark Pearson 2021-01-11  10377  

:::::: The code at line 10370 was first introduced by commit
:::::: c3bfcd4c676238e198d5a798b50e5d424bf05497 platform/x86: thinkpad_acpi: 
Add platform profile support

:::::: TO: Mark Pearson <[email protected]>
:::::: CC: Hans de Goede <[email protected]>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to