:::::: 
:::::: Manual check reason: "low confidence static check warning: 
drivers/tty/serial/amba-pl010.c:165:8: sparse:    int static [signed] 
[toplevel] writel( ... )"
:::::: 

BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Jiri Slaby <[email protected]>

Hi Jiri,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on usb/usb-testing linus/master v6.0-rc3 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Jiri-Slaby/tty-TX-helpers/20220901-190806
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git 
tty-testing
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: arm64-randconfig-s031-20220901 
(https://download.01.org/0day-ci/archive/20220902/[email protected]/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # 
https://github.com/intel-lab-lkp/linux/commit/f6f99189d77ea45bc72efe7393bb91f4eb46a2fb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review 
Jiri-Slaby/tty-TX-helpers/20220901-190806
        git checkout f6f99189d77ea45bc72efe7393bb91f4eb46a2fb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 
CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 
SHELL=/bin/bash drivers/tty/serial/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>

sparse warnings: (new ones prefixed by >>)
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got __VA_OPT__
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got ;
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Trying to use 
reserved word 'for' as identifier
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got &&
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ) in nested 
declarator
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got --
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got ->
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got ->
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Trying to use 
reserved word 'continue' as identifier
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got }
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got ->
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got ->
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got }
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got <
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Trying to use 
reserved word 'if' as identifier
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got ==
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Trying to use 
reserved word 'if' as identifier
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got }
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: got }
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: symbol 'writel' 
redeclared with different type (incompatible argument 1 (different base types)):
>> drivers/tty/serial/amba-pl010.c:165:8: sparse:    int static [signed] 
>> [toplevel] writel( ... )
   drivers/tty/serial/amba-pl010.c: note: in included file (through 
arch/arm64/include/asm/io.h, include/linux/scatterlist.h, 
include/linux/kfifo.h, ...):
   include/asm-generic/io.h:273:20: sparse: note: previously declared as:
   include/asm-generic/io.h:273:20: sparse:    void static inline [gnu_inline] 
[toplevel] writel( ... )
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: undefined identifier 
'xmit'
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: undefined identifier 
'xmit'
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: symbol 'ch' 
redeclared with different type (different type sizes):
   drivers/tty/serial/amba-pl010.c:165:8: sparse:    int [addressable] 
[toplevel] ch
   drivers/tty/serial/amba-pl010.c:165:8: sparse: note: previously declared as:
   drivers/tty/serial/amba-pl010.c:165:8: sparse:    unsigned char 
[addressable] [toplevel] [usertype] ch
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: symbol 'writel' 
redeclared with different type (incompatible argument 1 (different base types)):
>> drivers/tty/serial/amba-pl010.c:165:8: sparse:    int static [signed] 
>> [toplevel] writel( ... )
   include/asm-generic/io.h:273:20: sparse: note: previously declared as:
   include/asm-generic/io.h:273:20: sparse:    void static inline [gnu_inline] 
[toplevel] writel( ... )
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: cannot dereference 
this type
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: cannot dereference 
this type
   drivers/tty/serial/amba-pl010.c:165:8: sparse: sparse: symbol 'pending' 
redeclared with different type (different signedness):
   drivers/tty/serial/amba-pl010.c:165:8: sparse:    int [addressable] 
[toplevel] pending
   drivers/tty/serial/amba-pl010.c:165:8: sparse: note: previously declared as:
   drivers/tty/serial/amba-pl010.c:165:8: sparse:    unsigned int [addressable] 
[toplevel] pending
   drivers/tty/serial/amba-pl010.c:214:47: sparse: sparse: too many arguments 
for function pl010_tx_chars

vim +165 drivers/tty/serial/amba-pl010.c

^1da177e4c3f41 drivers/serial/amba-pl010.c     Linus Torvalds 2005-04-16  164  
f6f99189d77ea4 drivers/tty/serial/amba-pl010.c Jiri Slaby     2022-09-01 @165  
static DEFINE_UART_PORT_TX_HELPER_LIMITED(pl010_tx_chars, port, ch,
f6f99189d77ea4 drivers/tty/serial/amba-pl010.c Jiri Slaby     2022-09-01  166   
        true,
f6f99189d77ea4 drivers/tty/serial/amba-pl010.c Jiri Slaby     2022-09-01  167   
        writel(ch, port->membase + UART01x_DR),
f6f99189d77ea4 drivers/tty/serial/amba-pl010.c Jiri Slaby     2022-09-01  168   
        ({}));
^1da177e4c3f41 drivers/serial/amba-pl010.c     Linus Torvalds 2005-04-16  169  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to