:::::: 
:::::: Manual check reason: "low confidence static check warning: 
drivers/tty/serial/lantiq.c:149:8: sparse:    int static [signed] [toplevel] 
writeb( ... )"
:::::: 

BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Jiri Slaby <[email protected]>

Hi Jiri,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on usb/usb-testing shawnguo/for-next linus/master 
v6.0-rc3 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Jiri-Slaby/tty-TX-helpers/20220901-190806
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git 
tty-testing
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago
config: i386-randconfig-s001 
(https://download.01.org/0day-ci/archive/20220902/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # 
https://github.com/intel-lab-lkp/linux/commit/393b592949b2c633992ae9bdf00d3cffdd9a85d7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review 
Jiri-Slaby/tty-TX-helpers/20220901-190806
        git checkout 393b592949b2c633992ae9bdf00d3cffdd9a85d7
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir 
ARCH=i386 SHELL=/bin/bash drivers/tty/serial/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>

sparse warnings: (new ones prefixed by >>)
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ) in function 
declarator
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got __VA_OPT__
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ) in function 
declarator
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got ;
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Trying to use reserved 
word 'for' as identifier
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got &&
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ) in nested 
declarator
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got {
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ) in function 
declarator
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got ->
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got ->
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Trying to use reserved 
word 'continue' as identifier
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ; at the end of 
type declaration
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got }
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ) in function 
declarator
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got ->
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got ->
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ; at the end of 
type declaration
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got }
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ) in function 
declarator
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got <
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Trying to use reserved 
word 'if' as identifier
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ) in function 
declarator
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got ==
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Trying to use reserved 
word 'if' as identifier
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ; at the end of 
type declaration
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got }
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: Expected ; at the end of 
type declaration
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: got }
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: symbol 'true' redeclared 
with different type (different signedness):
   drivers/tty/serial/lantiq.c:149:8: sparse:    int [addressable] [toplevel] 
true
   drivers/tty/serial/lantiq.c: note: in included file (through 
include/uapi/linux/posix_types.h, include/uapi/linux/types.h, 
include/linux/types.h, ...):
   include/linux/stddef.h:12:9: sparse: note: previously declared as:
   include/linux/stddef.h:12:9: sparse:    unsigned int enum <noident> 
[toplevel] true
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: symbol 'writeb' 
redeclared with different type (incompatible argument 1 (different base types)):
>> drivers/tty/serial/lantiq.c:149:8: sparse:    int static [signed] [toplevel] 
>> writeb( ... )
   drivers/tty/serial/lantiq.c: note: in included file (through 
include/linux/io.h):
   arch/x86/include/asm/io.h:67:1: sparse: note: previously declared as:
>> arch/x86/include/asm/io.h:67:1: sparse:    void static inline [gnu_inline] 
>> [toplevel] writeb( ... )
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: undefined identifier 
'xmit'
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: undefined identifier 
'xmit'
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: symbol 'ch' redeclared 
with different type (different type sizes):
   drivers/tty/serial/lantiq.c:149:8: sparse:    int [addressable] [toplevel] ch
   drivers/tty/serial/lantiq.c:149:8: sparse: note: previously declared as:
   drivers/tty/serial/lantiq.c:149:8: sparse:    unsigned char [addressable] 
[toplevel] [usertype] ch
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: symbol 'writeb' 
redeclared with different type (incompatible argument 1 (different base types)):
>> drivers/tty/serial/lantiq.c:149:8: sparse:    int static [signed] [toplevel] 
>> writeb( ... )
   arch/x86/include/asm/io.h:67:1: sparse: note: previously declared as:
>> arch/x86/include/asm/io.h:67:1: sparse:    void static inline [gnu_inline] 
>> [toplevel] writeb( ... )
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: cannot dereference this 
type
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: cannot dereference this 
type
   drivers/tty/serial/lantiq.c:149:8: sparse: sparse: symbol 'pending' 
redeclared with different type (different signedness):
   drivers/tty/serial/lantiq.c:149:8: sparse:    int [addressable] [toplevel] 
pending
   drivers/tty/serial/lantiq.c:149:8: sparse: note: previously declared as:
   drivers/tty/serial/lantiq.c:149:8: sparse:    unsigned int [addressable] 
[toplevel] pending
--
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got __VA_OPT__
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got ;
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Trying to use 
reserved word 'for' as identifier
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got &&
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ) in nested 
declarator
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got {
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got ->
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got ->
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Trying to use 
reserved word 'continue' as identifier
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got }
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got ->
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ; at end of 
declaration
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got ->
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got }
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got <
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Trying to use 
reserved word 'if' as identifier
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ) in 
function declarator
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got ==
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Trying to use 
reserved word 'if' as identifier
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got }
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: Expected ; at the end 
of type declaration
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: got }
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: symbol 'true' 
redeclared with different type (different signedness):
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse:    int [addressable] 
[toplevel] true
   drivers/tty/serial/fsl_lpuart.c: note: in included file (through 
include/uapi/linux/posix_types.h, include/uapi/linux/types.h, 
include/linux/types.h, ...):
   include/linux/stddef.h:12:9: sparse: note: previously declared as:
   include/linux/stddef.h:12:9: sparse:    unsigned int enum <noident> 
[toplevel] true
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: symbol 'writeb' 
redeclared with different type (incompatible argument 1 (different base types)):
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse:    int static [signed] 
[toplevel] writeb( ... )
   drivers/tty/serial/fsl_lpuart.c: note: in included file (through 
include/linux/scatterlist.h, include/linux/dma-mapping.h):
   arch/x86/include/asm/io.h:67:1: sparse: note: previously declared as:
>> arch/x86/include/asm/io.h:67:1: sparse:    void static inline [gnu_inline] 
>> [toplevel] writeb( ... )
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: undefined identifier 
'xmit'
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: undefined identifier 
'xmit'
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: symbol 'ch' 
redeclared with different type (different type sizes):
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse:    int [addressable] 
[toplevel] ch
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: note: previously declared as:
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse:    unsigned char 
[addressable] [toplevel] [usertype] ch
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: symbol 'writeb' 
redeclared with different type (incompatible argument 1 (different base types)):
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse:    int static [signed] 
[toplevel] writeb( ... )
   arch/x86/include/asm/io.h:67:1: sparse: note: previously declared as:
>> arch/x86/include/asm/io.h:67:1: sparse:    void static inline [gnu_inline] 
>> [toplevel] writeb( ... )
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: cannot dereference 
this type
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: cannot dereference 
this type
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: sparse: symbol 'pending' 
redeclared with different type (different signedness):
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse:    int [addressable] 
[toplevel] pending
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse: note: previously declared as:
   drivers/tty/serial/fsl_lpuart.c:751:8: sparse:    unsigned int [addressable] 
[toplevel] pending

vim +149 drivers/tty/serial/lantiq.c

393b592949b2c6 Jiri Slaby 2022-09-01  148  
393b592949b2c6 Jiri Slaby 2022-09-01 @149  static 
DEFINE_UART_PORT_TX_HELPER(lqasc_tx_chars, port, ch,
393b592949b2c6 Jiri Slaby 2022-09-01  150               lqasc_tx_ready(port),
393b592949b2c6 Jiri Slaby 2022-09-01  151               writeb(ch, 
port->membase + LTQ_ASC_TBUF));
393b592949b2c6 Jiri Slaby 2022-09-01  152  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to