BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Ivan Bornyakov <[email protected]>
TO: [email protected]
TO: [email protected]
TO: [email protected]
TO: [email protected]
TO: [email protected]
TO: [email protected]
TO: [email protected]
TO: [email protected]
CC: Ivan Bornyakov <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Hi Ivan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.0-rc4 next-20220906]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Ivan-Bornyakov/Lattice-sysCONFIG-SPI-FPGA-manager/20220905-213520
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: parisc-randconfig-m041-20220906 
(https://download.01.org/0day-ci/archive/20220907/[email protected]/config)
compiler: hppa-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/fpga/sysconfig.c:265 sysconfig_bitstream_paged_write() error: 
uninitialized symbol 'ret'.

vim +/ret +265 drivers/fpga/sysconfig.c

d464d896568c54 Ivan Bornyakov 2022-09-05  243  
d464d896568c54 Ivan Bornyakov 2022-09-05  244  static int 
sysconfig_bitstream_paged_write(struct sysconfig_priv *priv,
d464d896568c54 Ivan Bornyakov 2022-09-05  245                                   
   const char *buf, size_t count)
d464d896568c54 Ivan Bornyakov 2022-09-05  246  {
d464d896568c54 Ivan Bornyakov 2022-09-05  247   const u8 lsc_progincr[] = 
SYSCONFIG_LSC_PROG_INCR_NV;
d464d896568c54 Ivan Bornyakov 2022-09-05  248   size_t i;
d464d896568c54 Ivan Bornyakov 2022-09-05  249   int ret;
d464d896568c54 Ivan Bornyakov 2022-09-05  250  
d464d896568c54 Ivan Bornyakov 2022-09-05  251   if (count % SYSCONFIG_PAGE_SIZE)
d464d896568c54 Ivan Bornyakov 2022-09-05  252           return -EINVAL;
d464d896568c54 Ivan Bornyakov 2022-09-05  253  
d464d896568c54 Ivan Bornyakov 2022-09-05  254   for (i = 0; i < count; i += 
SYSCONFIG_PAGE_SIZE) {
d464d896568c54 Ivan Bornyakov 2022-09-05  255           ret = 
sysconfig_cmd_write_with_data(priv, lsc_progincr,
d464d896568c54 Ivan Bornyakov 2022-09-05  256                                   
            sizeof(lsc_progincr),
d464d896568c54 Ivan Bornyakov 2022-09-05  257                                   
            buf + i, SYSCONFIG_PAGE_SIZE);
d464d896568c54 Ivan Bornyakov 2022-09-05  258           if (!ret)
d464d896568c54 Ivan Bornyakov 2022-09-05  259                   ret = 
sysconfig_poll_busy(priv);
d464d896568c54 Ivan Bornyakov 2022-09-05  260  
d464d896568c54 Ivan Bornyakov 2022-09-05  261           if (ret)
d464d896568c54 Ivan Bornyakov 2022-09-05  262                   break;
d464d896568c54 Ivan Bornyakov 2022-09-05  263   }
d464d896568c54 Ivan Bornyakov 2022-09-05  264  
d464d896568c54 Ivan Bornyakov 2022-09-05 @265   return ret;
d464d896568c54 Ivan Bornyakov 2022-09-05  266  }
d464d896568c54 Ivan Bornyakov 2022-09-05  267  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to