BCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: [email protected] TO: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected] CC: [email protected]
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/andrei-tachici-stud-acs-upb-ro/net-ethernet-adi-Add-ADIN1110-support/20220906-162644 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d5edc797ef0341ae2c8d4afaad9363edbf487a3a :::::: branch date: 2 days ago :::::: commit date: 2 days ago config: openrisc-randconfig-m041-20220907 (https://download.01.org/0day-ci/archive/20220908/[email protected]/config) compiler: or1k-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> smatch warnings: drivers/net/ethernet/adi/adin1110.c:1214 adin1110_port_set_blocking_state() warn: inconsistent returns '&priv->lock'. vim +1214 drivers/net/ethernet/adi/adin1110.c 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1184 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1185 static int adin1110_port_set_blocking_state(struct adin1110_port_priv *port_priv) 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1186 { 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1187 u8 mac[ETH_ALEN] = {0x01, 0x80, 0xC2, 0x00, 0x00, 0x00}; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1188 struct adin1110_priv *priv = port_priv->priv; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1189 u8 mask[ETH_ALEN]; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1190 u32 port_rules; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1191 int mac_slot; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1192 int ret; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1193 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1194 port_priv->state = BR_STATE_BLOCKING; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1195 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1196 mutex_lock(&priv->lock); 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1197 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1198 mac_slot = (!port_priv->nr) ? ADIN_MAC_P1_ADDR_SLOT : ADIN_MAC_P2_ADDR_SLOT; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1199 ret = adin1110_clear_mac_address(priv, mac_slot); 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1200 if (ret < 0) 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1201 goto out; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1202 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1203 ret = adin1110_hw_forwarding(priv, false); 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1204 if (ret < 0) 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1205 return ret; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1206 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1207 /* Allow only BPDUs to be passed to the CPU */ 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1208 memset(mask, 0xFF, ETH_ALEN); 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1209 port_rules = adin1110_port_rules(port_priv, true, false); 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1210 ret = adin1110_write_mac_address(port_priv, mac_slot, mac, mask, port_rules); 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1211 out: 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1212 mutex_unlock(&priv->lock); 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1213 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 @1214 return ret; 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1215 } 5c0e7bfee3f1b2f Alexandru Tachici 2022-09-06 1216 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
