BCC: [email protected] CC: [email protected] CC: [email protected] TO: Mauro Carvalho Chehab <[email protected]> CC: [email protected]
Hi Mauro, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3245cb65fd91cd514801bf91f5a3066d562f0ac4 commit: e7b8153e2a4f0c9c8d1450aa7328d54ea64fe8b2 media: platform: place stm32/ and sti/ under st/ dir date: 6 months ago :::::: branch date: 9 hours ago :::::: commit date: 6 months ago config: m68k-randconfig-m031-20220914 (https://download.01.org/0day-ci/archive/20220915/[email protected]/config) compiler: m68k-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/media/platform/st/sti/bdisp/bdisp-v4l2.c:1305 bdisp_probe() warn: assigning (-38) to unsigned variable 'bdisp->id' Old smatch warnings: drivers/media/platform/st/sti/bdisp/bdisp-v4l2.c:725 bdisp_g_fmt() warn: passing a valid pointer to 'PTR_ERR' drivers/media/platform/st/sti/bdisp/bdisp-v4l2.c:852 bdisp_g_selection() warn: passing a valid pointer to 'PTR_ERR' vim +1305 drivers/media/platform/st/sti/bdisp/bdisp-v4l2.c 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1283 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1284 static int bdisp_probe(struct platform_device *pdev) 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1285 { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1286 struct bdisp_dev *bdisp; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1287 struct device *dev = &pdev->dev; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1288 int ret; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1289 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1290 dev_dbg(dev, "%s\n", __func__); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1291 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1292 bdisp = devm_kzalloc(dev, sizeof(struct bdisp_dev), GFP_KERNEL); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1293 if (!bdisp) 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1294 return -ENOMEM; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1295 2732bb765f14eb drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2018-05-15 1296 ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32)); 2732bb765f14eb drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2018-05-15 1297 if (ret) 2732bb765f14eb drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2018-05-15 1298 return ret; 2732bb765f14eb drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2018-05-15 1299 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1300 bdisp->pdev = pdev; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1301 bdisp->dev = dev; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1302 platform_set_drvdata(pdev, bdisp); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1303 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1304 if (dev->of_node) 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 @1305 bdisp->id = of_alias_get_id(pdev->dev.of_node, BDISP_NAME); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1306 else 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1307 bdisp->id = pdev->id; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1308 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1309 init_waitqueue_head(&bdisp->irq_queue); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1310 INIT_DELAYED_WORK(&bdisp->timeout_work, bdisp_irq_timeout); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1311 bdisp->work_queue = create_workqueue(BDISP_NAME); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1312 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1313 spin_lock_init(&bdisp->slock); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1314 mutex_init(&bdisp->lock); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1315 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1316 /* get resources */ 6394c2d95399e5 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Cai Huoqing 2021-09-01 1317 bdisp->regs = devm_platform_ioremap_resource(pdev, 0); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1318 if (IS_ERR(bdisp->regs)) { 8ea1c5af489a76 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Chuhong Yuan 2019-11-13 1319 ret = PTR_ERR(bdisp->regs); 8ea1c5af489a76 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Chuhong Yuan 2019-11-13 1320 goto err_wq; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1321 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1322 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1323 bdisp->clock = devm_clk_get(dev, BDISP_NAME); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1324 if (IS_ERR(bdisp->clock)) { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1325 dev_err(dev, "failed to get clock\n"); 8ea1c5af489a76 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Chuhong Yuan 2019-11-13 1326 ret = PTR_ERR(bdisp->clock); 8ea1c5af489a76 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Chuhong Yuan 2019-11-13 1327 goto err_wq; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1328 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1329 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1330 ret = clk_prepare(bdisp->clock); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1331 if (ret < 0) { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1332 dev_err(dev, "clock prepare failed\n"); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1333 bdisp->clock = ERR_PTR(-EINVAL); 8ea1c5af489a76 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Chuhong Yuan 2019-11-13 1334 goto err_wq; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1335 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1336 9fcb700420c90c drivers/media/platform/sti/bdisp/bdisp-v4l2.c Lad Prabhakar 2022-01-11 1337 ret = platform_get_irq(pdev, 0); 9fcb700420c90c drivers/media/platform/sti/bdisp/bdisp-v4l2.c Lad Prabhakar 2022-01-11 1338 if (ret < 0) 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1339 goto err_clk; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1340 9fcb700420c90c drivers/media/platform/sti/bdisp/bdisp-v4l2.c Lad Prabhakar 2022-01-11 1341 ret = devm_request_threaded_irq(dev, ret, bdisp_irq_handler, 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1342 bdisp_irq_thread, IRQF_ONESHOT, 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1343 pdev->name, bdisp); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1344 if (ret) { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1345 dev_err(dev, "failed to install irq\n"); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1346 goto err_clk; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1347 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1348 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1349 /* v4l2 register */ 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1350 ret = v4l2_device_register(dev, &bdisp->v4l2_dev); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1351 if (ret) { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1352 dev_err(dev, "failed to register\n"); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1353 goto err_clk; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1354 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1355 34b6beb65beb7f drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1356 /* Debug */ 8c23f411296e54 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Greg Kroah-Hartman 2020-08-18 1357 bdisp_debugfs_create(bdisp); 34b6beb65beb7f drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1358 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1359 /* Power management */ 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1360 pm_runtime_enable(dev); c44eac5b72e23c drivers/media/platform/sti/bdisp/bdisp-v4l2.c Mauro Carvalho Chehab 2021-04-23 1361 ret = pm_runtime_resume_and_get(dev); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1362 if (ret < 0) { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1363 dev_err(dev, "failed to set PM\n"); c44eac5b72e23c drivers/media/platform/sti/bdisp/bdisp-v4l2.c Mauro Carvalho Chehab 2021-04-23 1364 goto err_remove; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1365 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1366 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1367 /* Filters */ 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1368 if (bdisp_hw_alloc_filters(bdisp->dev)) { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1369 dev_err(bdisp->dev, "no memory for filters\n"); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1370 ret = -ENOMEM; dce57314b53760 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Hans Verkuil 2016-02-15 1371 goto err_pm; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1372 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1373 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1374 /* Register */ 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1375 ret = bdisp_register_device(bdisp); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1376 if (ret) { 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1377 dev_err(dev, "failed to register\n"); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1378 goto err_filter; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1379 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1380 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1381 dev_info(dev, "%s%d registered as /dev/video%d\n", BDISP_NAME, 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1382 bdisp->id, bdisp->vdev.num); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1383 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1384 pm_runtime_put(dev); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1385 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1386 return 0; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1387 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1388 err_filter: 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1389 bdisp_hw_free_filters(bdisp->dev); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1390 err_pm: 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1391 pm_runtime_put(dev); c44eac5b72e23c drivers/media/platform/sti/bdisp/bdisp-v4l2.c Mauro Carvalho Chehab 2021-04-23 1392 err_remove: 0529c0f55da87a drivers/media/platform/sti/bdisp/bdisp-v4l2.c Dongliang Mu 2021-10-19 1393 pm_runtime_disable(dev); 34b6beb65beb7f drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1394 bdisp_debugfs_remove(bdisp); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1395 v4l2_device_unregister(&bdisp->v4l2_dev); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1396 err_clk: 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1397 if (!IS_ERR(bdisp->clock)) 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1398 clk_unprepare(bdisp->clock); 8ea1c5af489a76 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Chuhong Yuan 2019-11-13 1399 err_wq: 8ea1c5af489a76 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Chuhong Yuan 2019-11-13 1400 destroy_workqueue(bdisp->work_queue); 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1401 return ret; 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1402 } 28ffeebbb7bdc0 drivers/media/platform/sti/bdisp/bdisp-v4l2.c Fabien Dessenne 2015-05-12 1403 :::::: The code at line 1305 was first introduced by commit :::::: 28ffeebbb7bdc0dd7899286b63f3c359d43d0a1a [media] bdisp: 2D blitter driver using v4l2 mem2mem framework :::::: TO: Fabien Dessenne <[email protected]> :::::: CC: Mauro Carvalho Chehab <[email protected]> -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
