:::::: :::::: Manual check reason: "low confidence static check warning: drivers/thermal/thermal_helpers.c:79:6: warning: Redundant initialization for 'ret'. The initialized value is overwritten before it is read. [redundantInitialization]" ::::::
BCC: [email protected] CC: [email protected] CC: Linux Memory Management List <[email protected]> TO: Daniel Lezcano <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: d5538ab91d3a9a237805be6f8c6c272af2987995 commit: a930da9bf583b2add01fb0e086913664dadaffd0 [1111/7639] thermal/core: Move the mutex inside the thermal_zone_device_update() function :::::: branch date: 4 hours ago :::::: commit date: 4 weeks ago compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (cppcheck warning): # apt-get install cppcheck git checkout a930da9bf583b2add01fb0e086913664dadaffd0 cppcheck --quiet --enable=style,performance,portability --template=gcc FILE If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <[email protected]> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> drivers/thermal/thermal_helpers.c:79:6: warning: Redundant initialization >> for 'ret'. The initialized value is overwritten before it is read. >> [redundantInitialization] ret = tz->ops->get_temp(tz, temp); ^ drivers/thermal/thermal_helpers.c:69:10: note: ret is initialized int ret = -EINVAL; ^ drivers/thermal/thermal_helpers.c:79:6: note: ret is overwritten ret = tz->ops->get_temp(tz, temp); ^ vim +/ret +79 drivers/thermal/thermal_helpers.c cd221c7b638f83 Eduardo Valentin 2016-11-07 66 a930da9bf583b2 Daniel Lezcano 2022-08-05 67 int __thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp) cd221c7b638f83 Eduardo Valentin 2016-11-07 68 { cd221c7b638f83 Eduardo Valentin 2016-11-07 69 int ret = -EINVAL; cd221c7b638f83 Eduardo Valentin 2016-11-07 70 int count; cd221c7b638f83 Eduardo Valentin 2016-11-07 71 int crit_temp = INT_MAX; cd221c7b638f83 Eduardo Valentin 2016-11-07 72 enum thermal_trip_type type; cd221c7b638f83 Eduardo Valentin 2016-11-07 73 a930da9bf583b2 Daniel Lezcano 2022-08-05 74 lockdep_assert_held(&tz->lock); cd221c7b638f83 Eduardo Valentin 2016-11-07 75 a930da9bf583b2 Daniel Lezcano 2022-08-05 76 if (!tz || IS_ERR(tz) || !tz->ops->get_temp) a930da9bf583b2 Daniel Lezcano 2022-08-05 77 return -EINVAL; cd221c7b638f83 Eduardo Valentin 2016-11-07 78 cd221c7b638f83 Eduardo Valentin 2016-11-07 @79 ret = tz->ops->get_temp(tz, temp); cd221c7b638f83 Eduardo Valentin 2016-11-07 80 cd221c7b638f83 Eduardo Valentin 2016-11-07 81 if (IS_ENABLED(CONFIG_THERMAL_EMULATION) && tz->emul_temperature) { e5bfcd30f88fdb Daniel Lezcano 2022-07-22 82 for (count = 0; count < tz->num_trips; count++) { cd221c7b638f83 Eduardo Valentin 2016-11-07 83 ret = tz->ops->get_trip_type(tz, count, &type); cd221c7b638f83 Eduardo Valentin 2016-11-07 84 if (!ret && type == THERMAL_TRIP_CRITICAL) { cd221c7b638f83 Eduardo Valentin 2016-11-07 85 ret = tz->ops->get_trip_temp(tz, count, cd221c7b638f83 Eduardo Valentin 2016-11-07 86 &crit_temp); cd221c7b638f83 Eduardo Valentin 2016-11-07 87 break; cd221c7b638f83 Eduardo Valentin 2016-11-07 88 } cd221c7b638f83 Eduardo Valentin 2016-11-07 89 } cd221c7b638f83 Eduardo Valentin 2016-11-07 90 cd221c7b638f83 Eduardo Valentin 2016-11-07 91 /* cd221c7b638f83 Eduardo Valentin 2016-11-07 92 * Only allow emulating a temperature when the real temperature cd221c7b638f83 Eduardo Valentin 2016-11-07 93 * is below the critical temperature so that the emulation code cd221c7b638f83 Eduardo Valentin 2016-11-07 94 * cannot hide critical conditions. cd221c7b638f83 Eduardo Valentin 2016-11-07 95 */ cd221c7b638f83 Eduardo Valentin 2016-11-07 96 if (!ret && *temp < crit_temp) cd221c7b638f83 Eduardo Valentin 2016-11-07 97 *temp = tz->emul_temperature; cd221c7b638f83 Eduardo Valentin 2016-11-07 98 } cd221c7b638f83 Eduardo Valentin 2016-11-07 99 cd221c7b638f83 Eduardo Valentin 2016-11-07 100 return ret; cd221c7b638f83 Eduardo Valentin 2016-11-07 101 } cd221c7b638f83 Eduardo Valentin 2016-11-07 102 :::::: The code at line 79 was first introduced by commit :::::: cd221c7b638f83193ffcacf9c2e3f087033fd4cf thermal: core: introduce thermal_helpers.c :::::: TO: Eduardo Valentin <[email protected]> :::::: CC: Zhang Rui <[email protected]> -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
