On 30 Dec 2001 10:35:53 +0200, Tommi Virtanen <[EMAIL PROTECTED]> wrote: >Keith Owens <[EMAIL PROTECTED]> writes: > >> Other way around. Calls to kdb from non-kdb code need to be wrapped in >> #ifdef CONFIG_KDB, I missed one. > > Then why do you, in include/linux/kdb.h, do > >#ifdef CONFIG_KDB >extern int kdb(....); >#else >#define kdb(....) (0) >#endif > > then?
Old code. > I understand my suggestion is the approach Linus likes.. The kdb patch is included with other software such as xfs. xfs runs on more systems than kdb does and the kdb bits fail to compile on some systems where xfs will run on its own. I need to ensure that no vestige of kdb is visible unless CONFIG_KDB=y. Also a lot of the kdb patch is not just a function call, it is complete replacements for existing code, you cannot do that without #ifdef. I prefer a consistent coding style, since I have to use #ifdef in some places, I use it everywhere.
