Christoph Hellwig wrote: > > On Sun, Jan 27, 2002 at 07:55:07PM -0500, Jim Houston wrote: > > Run the script "scripts/inline-fix.pl" included in this patch. This > > changes "extern inline" to "static inline" globally. > > What do you think about preparing such a patch for Linus & Marcelo? > I know we've been bitten by extern inline all the time for various > reasons..
I'm not sure if it's my fight or if its the right fight. It would be nice if the kernel were more consistent. Is there a precident for Linus running scripts against the kernel? I suspect that a patch with the global change might be considered large. Would all of the affected maintainers have to sign up? I also wonder if there is a way to make "extern inline" work and produce a single global instance. In the case of my little trace, it would be much more useable if you could filter out all calls to spin_lock() without having to lookup the addresses of all of the static instances. Jim Houston
