Hi,
Yes, your addition to VT100 character sequence works well.
But I wonder why you don't add these translation in architecture
dependent function "static int get_serial_char(void);". I think it is better
to return the meaningful ASCII characters in these architecture dependent
functions.
Regards.
Sonic Zhang
-----Original Message-----
From: Keith Owens [mailto:[EMAIL PROTECTED]]
Sent: 2003?2?8? 13:15
To: Zhang, Sonic
Cc: KDB (E-mail)
Subject: Re: 1 bug cause the kdb-3.0-2.4.20 patch fail to compile
On Sat, 8 Feb 2003 12:21:25 +0800 ,
"Zhang, Sonic" <[EMAIL PROTECTED]> wrote:
> After I applied the kdb-3.0-2.4.20 patch to kernel 2.4.20, I failed
>to compile the new kernel with USB keyboard supported in KDB. I find one
>type is used before defined in file arch/i386/kdb/kdba_io.c. I changed the
>type and compile the kernel successfully.
> Please see my change.
>
>--- linux/arch/i386/kdb/kdba_io.c Sat Feb 8 12:07:19 2003
>+++ linux-tmp/arch/i386/kdb/kdba_io.c Sat Feb 8 12:09:01 2003
>@@ -90,7 +90,7 @@
> return -1;
>
> /* Transfer char if they are present */
>- (*kdb_usb_infos.poll_func)(kdb_usb_infos.uhci, (urb_t
>*)kdb_usb_infos.urb);
>+ (*kdb_usb_infos.poll_func)(kdb_usb_infos.uhci, (struct urb
>*)kdb_usb_infos.urb);
>
> spec = kdb_usb_infos.buffer[0];
> keycode = kdb_usb_infos.buffer[2];
Thanks, nobody has volunteered to support the usb code in kdb. I have
given up with the usb code and planning to remove it.
Your mailer is still mangling patches, the wrapped lines are from your
end.
BTW, are you happy with the command editting in v3.0, especially my
changes to add vt100 sequences?