-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

My hack was too lame to post, I thought--I set i=0 before the indirect
call to urb_complete. :)

I didn't sort all the cases out, but on some exits from the loop for i
to KDB_USB_NUM_KEYBOARDS, i has a value corresponding to a non-present
keyboard--so the attempt to get a urb_complete function pointer (last
statement in get_usb_char) from that element in the keyboard array is
illegal.

Matt

Jay Lan wrote:
> Matt Benjamin wrote:
> 
> Hi Matt,
> 
>> I just wanted to let folks know that I
>>
>> 1. got this working on x86 (x86_64, Dell Vostro 200)
> 
> Great!
> 
>>   1.a after moving some static function definitions around to deal with
>> issues mentioned by Jay
> 
> What kind of problem was that? I did not have problem building on
> x86_64? My problem was on ia64.
> 
>>   1.b and after hacking around an apparent bug in get_usb_char
>> (kdba_io_64.c)
> 
> I assume it is in arch/x86/kdba_io_64.c? Can you share your hacking
> with us and what problem did it fix? Maybe you hit something
> Konstantin did not see.
> 
> Thanks,
>  - jay
> 
> 
>> The proximate issue is that in (at least) the case where we (I think) we
>> got no keypress, i has the value KDB_USB_NUM_KEYBOARDS, which provokes a
>> trap when we call urb_complete.
>>
>> Thanks for getting this in, KDB developers.  I absolutely needed a KDB
>> on these boxes, and this arrived just in time.
>>
>> Matt
>>
>> --
>>
>> Matt Benjamin
>>
>> The Linux Box
>> 206 South Fifth Ave. Suite 150
>> Ann Arbor, MI  48104
>>
>> http://linuxbox.com
>>
>> tel. 734-761-4689
>> fax. 734-769-8938
>> cel. 734-216-5309
>>
> ---------------------------
> Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
> 
> ---------------------------
> Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.




- --

Matt Benjamin

The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHaCEUJiSUUSaRdSURCBHTAKCJ+7+evuNbK8yE/My1L03rRynR6gCdFVwU
lziIdv1mm1ZzXOwoL9N2wPs=
=zVo+
-----END PGP SIGNATURE-----
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.

Reply via email to