https://bugs.kde.org/show_bug.cgi?id=355918
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |http://commits.kde.org/plas
| |ma-workspace/0dc7f6c3e5d62f
| |6d8211e5d024ee3080b2baae37
--- Comment #2 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 0dc7f6c3e5d62f6d8211e5d024ee3080b2baae37 by David Edmundson.
Committed on 28/12/2015 at 16:23.
Pushed by davidedmundson into branch 'master'.
Don't rely graphic objects in panel script engine
The basic design of Plasma is that scripts and and the shell (in theory)
manipulate a tree of basic applet geometry and configs.
Plasmashell then reacts to those changes and displays them visually with
a distinct separation between the layout and UI.
Panel's scriptengine seemed to do away with all, and try and manipulate
the graphic object directly..which might not exist and that leads to
complex code.
This changes it to read/write from the same config object as
PanelView will use. More akin to how the script engine for applet and
contiainment works.
If there's a view for this panel, we update immediately, otherwise it'll
just get loaded when it's needed. PanelView::reload() has the error
checking/bounds management so no point duplicating that.
REVIEW: 125921
M +12 -35 shell/panelview.cpp
M +3 -0 shell/panelview.h
M +89 -277 shell/scripting/panel.cpp
M +1 -0 shell/scripting/panel.h
http://commits.kde.org/plasma-workspace/0dc7f6c3e5d62f6d8211e5d024ee3080b2baae37
--
You are receiving this mail because:
You are watching all bug changes.
