https://bugs.kde.org/show_bug.cgi?id=506217
--- Comment #3 from Rik Mills <[email protected]> --- (In reply to Nate Graham from comment #2) > I imagine we don't just need to change the test; probably some code or > providers file needs adjusting as well? > > Feels very weird that this test depends on the content of a file under > someone else's control TBH. Assuming the test is parsing the first matching code in the uptream providers data file (which would now not match what the test expects), then yes the code AND the test would presumably need to be adjusted to take account of cases where that might happen. That is assuming that duplicate Mcc/Mnc codes are legitimate in the data due to MVNO (https://en.wikipedia.org/wiki/Mobile_virtual_network_operator), which is beyond my knowledge. I don't think it is really odd that the test depends on the external data, as the whole point is to see whether KDE's approach to using that data is working ok or not. If that data changes content or formatting our code may no longer be adequate to parse/use it. Which is why a test is useful. -- You are receiving this mail because: You are watching all bug changes.
