https://bugs.kde.org/show_bug.cgi?id=506806
--- Comment #3 from Mark Wielaard <[email protected]> --- (In reply to Mark Wielaard from comment #2) > > + if (!ML_(fd_allowed)(arg_1, "execveat", tid, False) && arg_1 != > > VKI_AT_FDCWD) { > > SET_STATUS_Failure( VKI_EBADF ); > > return; > > } > > > > > > nitpick. swapping the checks might be a tiny optimization, since the arg_1 > != VKI_AT_FDCWD is fast and cheap, but ML_(fd_allowed) might (with fd > tracking) do a lot more work. O, not really a nitpick. We really don't want ML_(fd_allowed) on VKI_AT_FDCWD because that will generate bogus warning. So please swap them. -- You are receiving this mail because: You are watching all bug changes.
