https://bugs.kde.org/show_bug.cgi?id=505879

--- Comment #3 from nyanpasu64 <[email protected]> ---
I came up with a simpler fix (for an astral character, output multiple QChar
over multiple calls to EncodedDataStream::readChar()). I found you also have to
override atEnd() to return false when the stream is at end but we're not done
outputting characters, otherwise an emoji at the end of a file will be
truncated while reading.

- I'm beginning to think that inheriting from QDataStream was a leaky
abstraction.

Saving works fine without changes, and emoji are saved properly both within and
at the end of a file.

I've pushed my code to
https://invent.kde.org/nyanpasu/kdiff3/-/commits/fix-emoji?ref_type=heads . I
didn't create a pull request since the upstream repo seems to be set up to make
them to master, but I can't build master on my Fedora machine.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to