https://bugs.kde.org/show_bug.cgi?id=331311
--- Comment #8 from Alexandra Hajkova <[email protected]> --- > > + if (VG_(strcmp)(name, ".") != 0 && VG_(strcmp)(name, "..") != 0) { > > + Bool is_numeric = True; > > + > > + /* Check if filename is numeric (potential FD number) */ > > + for (Int i = 0; name[i] != '\0'; i++) { > > + if (name[i] < '0' || name[i] > '9') { > > + is_numeric = False; > > + break; > > + } > > + } > > So, this is an should not happen? > Should it have an assert? > Or is it OK to silently keep these entries? > > > + The goal of this function is to filter out Valgrind's fd. Non numeric fd value is some weird thing and I'm not sure how to treat such a thing. I think it's kind of ok to silently keep them because they are not Valgrind's for sure and they should not bother us? Or we we could warn about them maybe? Also I don't think we should put an assert there because then we won't filter the Valgrind's fds because of some junk in that directory. -- You are receiving this mail because: You are watching all bug changes.
