[valgrind] [Bug 331311] Valgrind shows open files in /proc/self/fd that don't work for the process

[Mark Wielaard]

https://bugs.kde.org/show_bug.cgi?id=331311

--- Comment #15 from Mark Wielaard <m...@klomp.org> ---
(In reply to Mark Wielaard from comment #14)
> I think the filter_valgrind_fds_from_getdents_with_refill functions should
> return a SysRes instead of a SizeT so you can also return a failing (retry)
> syscall. 

Note that on irc I tried to explain this in a very complicate way.
Don't listen to me :)
The simplest way is for filter_valgrind_fds_from_getdents_with_refill
to just do something like:

SysRes retry = VG_(do_syscall3)(...)
if (sr_isError(retry)) {
  SET_STATUS_from_SysRes(retry);
  return -1;
}

And then in the POST handler just check for ret < 0.

-- 
You are receiving this mail because:
You are watching all bug changes.