https://bugs.kde.org/show_bug.cgi?id=510115
A D <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Ever confirmed|0 |1 Status|RESOLVED |REOPENED --- Comment #7 from A D <[email protected]> --- (In reply to Stephane MANKOWSKI from comment #6) > Git commit 54959d105b60c76d32952950a11917fc0e42d905 by Stéphane MANKOWSKI. > Committed on 03/10/2025 at 16:36. > Pushed by smankowski into branch 'master'. > > 510115: MS Money import: Ignore (/import?) Classifications Thanks, that looked easier than I thought it might be! :-) It's a step in the right direction, but (unfortunately) not quite the full solution needed. This only handles Classification 1 and ignores Classification 2 (I use "Holidays" as Classification 1 and "Projects" as Classification 2, with various items in two levels in both of those). 1) When creating the trackers (at line 208), it needs to be (classificationId == 1 || classificationId == 2) (or even just else ...) 2) In Money, Classifications are trees (like Categories), but the Trackers in Skrooge are just a list, so the Tracker name (line 214) needs to include the path through the tree, not just the leaf name from the category list. (Some of my "Projects" have the same "sub-sub-classifications", so without the "path", there would be several Trackers with the same name.) Something like... If category["parentId"] is null, then the Tacker name needs to be category["classTypeName"] + " : " + category["name"] else (when "parentId" is not null) the Tracker name needs to be m_mapIdTracker[parentId].name + " : " + category["name"] 3) Adding trackers to the transactions needs to consider operation["class2"], as well as "class1". If they're both not empty, then just use one of them (probably "class1") but either emit a warning (similar to the "split repaired" warning) or maybe add the name of the missing Tracker ("class2") to the end of the transaction comment? If class1 is empty and class2 is not empty, use class2 as the tracker. The test file should result in 8 trackers. The third transaction has both class1 and class2 set. I'm sorry that's extra work. If you've had enough of Money importer changes, I'm quite happy to code this and provide a patch - just let me know (but I suspect as you know the code, it will be quicker for you to do it). Thank you! -- You are receiving this mail because: You are watching all bug changes.
