https://bugs.kde.org/show_bug.cgi?id=510864
Mark Wielaard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REPORTED |ASSIGNED Ever confirmed|0 |1 --- Comment #5 from Mark Wielaard <[email protected]> --- (In reply to Alexandra Hajkova from comment #4) > Created attachment 186696 [details] > patch > > Add pmaxsd support for x86 32 bit > > Support pmaxsd instruction in guest_x86_toIR.c and host_x86_isel.c > and modify the none/tests/x86/sse4-x86.stdout.exp to match pmaxsd > support. This looks very nice. I would also handle PMINSD in the guest decoder and add test_PMINSD, since you already have it in the instruction selector. Nitpick, some extra whitespace in VEX/priv/guest_amd64_toIR.c The patch buildup is nice too. First pulling out the common code. Then making it usable for building on 32bit. Then implementing the instructions and testing them. -- You are receiving this mail because: You are watching all bug changes.
