https://bugs.kde.org/show_bug.cgi?id=512363

Akseli Lahtinen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |INTENTIONAL

--- Comment #2 from Akseli Lahtinen <[email protected]> ---
First of all, I apologize for cherrypicking this change too early. It would
have been better to release it with next release of Plasma, where changes like
this are more expected.

The change itself is intentional: Our Breeze QtWidgets style has been woefully
out of date for long time now. It has not followed the standard values we have
for menus, which have been declared by Kirigami. This has caused inconsistency
between the two styles for longer time.

This change was done in this MR:
https://invent.kde.org/plasma/breeze/-/merge_requests/563

Now the values are mostly the same, though there were bugs that caused it to
have too much padding than it supposed to have. I did not notice this due to
difference in font choices causing different values! However, it has now been
fixed and cherrypicked to next release:

- https://invent.kde.org/plasma/breeze/-/merge_requests/568
- https://invent.kde.org/plasma/breeze/-/merge_requests/570

So I apologize for this sudden, and understandably bit jarring change. But I
believe it was a good change: It allows us better to evaluate the sizes for
context menus now since they're same across QtQuick and QtWidgets apps. And now
if we want to make the size smaller/bigger, we have same starting point and
avoid this pixel hunting.

The point of these changes was not to make thing bigger/smaller, but unify the
values used across our stack. QtWidgets style has been using wrong values for
years! And the values are wrong, because they were not using the standardized
values depicted in our HIG:
https://develop.kde.org/hig/layout_and_nav/#spacings-and-sizes

So technically we all got used to a bug, so now that we fix this bug, it's
going to be jarring. 

Again, apologies for being too hasty with the cherrypick to the stable branch.
I should have waited. But this change would have happened later anyway, with
probably same reaction. 

We'll be monitoring for the sizing here over time now. I hope users can give it
some time to get used to, especially when the fixes linked above land to your
system.

> This should be adjustable

Sadly this is not as easy as I'd like it to be. I would have done it already
otherwise. It will take a lot of changes across the stack to keep our margins
synced between QtWidgets and QtQuick styles to avoid any weirdness. However,
Union will alleviate this issue by allowing people to change these values to
whatever they wish. I can't promise anything, but I am hoping to add somekind
of density setting, so people can choose whatever amount whitespace is
comfortable for them.

I will set this as resolved intentional for now. Again, apologies for merging
this in "too soon." I'll do better next time.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to